[PATCH v1] rust: error: add ERESTARTSYS error code

[PATCH v1] rust: error: add ERESTARTSYS error code

[Alice Ryhl]

This error code was probably excluded here originally because it never
actually reaches user programs when a syscall returns it. However, from
the perspective of a kernel driver, it is still a perfectly valid error
type, that the driver might need to return. E.g., this can be necessary
when a signal occurs during sleep.

Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
 rust/kernel/error.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
index 5f4114b30b94..cbde1b2d29f4 100644
--- a/rust/kernel/error.rs
+++ b/rust/kernel/error.rs
@@ -58,6 +58,7 @@ pub mod code {
     declare_err!(EPIPE, "Broken pipe.");
     declare_err!(EDOM, "Math argument out of domain of func.");
     declare_err!(ERANGE, "Math result not representable.");
+    declare_err!(ERESTARTSYS, "Restart the system call.");
 }
 
 /// Generic integer kernel error.

base-commit: ea76e08f4d901a450619831a255e9e0a4c0ed162
-- 
2.40.1.495.gc816e09b53d-goog

Re: [PATCH v1] rust: error: add ERESTARTSYS error code

[Miguel Ojeda]

On Wed, May 3, 2023 at 10:40 AM Alice Ryhl <aliceryhl@google.com> wrote:
>
> This error code was probably excluded here originally because it never
> actually reaches user programs when a syscall returns it. However, from

The reason is that commit 266def2a0f5b ("rust: error: add codes from
`errno-base.h`") only introduced the ones from
`include/uapi/asm-generic/errno-base.h`, but not the ones from
`include/linux/errno.h` (or `include/uapi/asm-generic/errno.h`).

Given this is an independent patch, should we introduce the rest too, at once?

Cheers,
Miguel

[PATCH] rust: bindings: fix sorting of rust/bindings/bindings_helper.h's #includes

[materoy]

From: Roy Matero <materoy@proton.me>

Fix sorting of rust/bindings/binding_helper.h's includes,
to maintain consistency and rust idoms

Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1002

Signed-off-by: Roy Matero <materoy@proton.me>
---
 rust/bindings/bindings_helper.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
index 50e7a76d5455..dc8d97272e71 100644
--- a/rust/bindings/bindings_helper.h
+++ b/rust/bindings/bindings_helper.h
@@ -6,10 +6,10 @@
  * Sorted alphabetically.
  */

-#include <linux/slab.h>
 #include <linux/refcount.h>
-#include <linux/wait.h>
 #include <linux/sched.h>
+#include <linux/slab.h>
+#include <linux/wait.h>

 /* `bindgen` gets confused at certain things. */
 const gfp_t BINDINGS_GFP_KERNEL = GFP_KERNEL;
--
2.40.1

Re: [PATCH v1] rust: error: add ERESTARTSYS error code

[Alice Ryhl]

On 27.04.23 00:57, Roy Matero <materoy@proton.me> wrote:
> Fix sorting of rust/bindings/binding_helper.h's includes,
> to maintain consistency and rust idoms
> 
> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1002
> 
> Signed-off-by: Roy Matero <materoy@proton.me>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

Re: [PATCH v1] rust: error: add ERESTARTSYS error code

[Alice Ryhl]

Seems like I messed up something with this email. It's supposed to be a reply to
https://lore.kernel.org/all/20230426224748.34056-1-materoy@proton.me/

On Wed, May 3, 2023 at 12:59 PM Alice Ryhl <aliceryhl@google.com> wrote:
>
> On 27.04.23 00:57, Roy Matero <materoy@proton.me> wrote:
> > Fix sorting of rust/bindings/binding_helper.h's includes,
> > to maintain consistency and rust idoms
> >
> > Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> > Link: https://github.com/Rust-for-Linux/linux/issues/1002
> >
> > Signed-off-by: Roy Matero <materoy@proton.me>
>
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>