Rust for Linux List
 help / color / mirror / Atom feed
From: FUJITA Tomonori <fujita.tomonori@gmail.com>
To: netdev@vger.kernel.org
Cc: rust-for-linux@vger.kernel.org, andrew@lunn.ch,
	tmgross@umich.edu, miguel.ojeda.sandonis@gmail.com,
	benno.lossin@proton.me, aliceryhl@google.com
Subject: [PATCH net-next v3 3/6] rust: net::phy implement AsRef<kernel::device::Device> trait
Date: Mon,  5 Aug 2024 08:38:32 +0900	[thread overview]
Message-ID: <20240804233835.223460-4-fujita.tomonori@gmail.com> (raw)
In-Reply-To: <20240804233835.223460-1-fujita.tomonori@gmail.com>

Implement AsRef<kernel::device::Device> trait for Device. A PHY driver
needs a reference to device::Device to call the firmware API.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
---
 rust/kernel/net/phy.rs | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/rust/kernel/net/phy.rs b/rust/kernel/net/phy.rs
index 60d3d8f8b44f..bd9fc7a84cd4 100644
--- a/rust/kernel/net/phy.rs
+++ b/rust/kernel/net/phy.rs
@@ -7,8 +7,7 @@
 //! C headers: [`include/linux/phy.h`](srctree/include/linux/phy.h).
 
 use crate::{error::*, prelude::*, types::Opaque};
-
-use core::marker::PhantomData;
+use core::{marker::PhantomData, ptr::addr_of_mut};
 
 /// PHY state machine states.
 ///
@@ -302,6 +301,15 @@ pub fn genphy_read_abilities(&mut self) -> Result {
     }
 }
 
+impl AsRef<kernel::device::Device> for Device {
+    fn as_ref(&self) -> &kernel::device::Device {
+        let phydev = self.0.get();
+        // SAFETY: The struct invariant ensures that we may access
+        // this field without additional synchronization.
+        unsafe { kernel::device::Device::as_ref(addr_of_mut!((*phydev).mdio.dev)) }
+    }
+}
+
 /// Defines certain other features this PHY supports (like interrupts).
 ///
 /// These flag values are used in [`Driver::FLAGS`].
-- 
2.34.1


  parent reply	other threads:[~2024-08-04 23:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-04 23:38 [PATCH net-next v3 0/6] net: phy: add Applied Micro QT2025 PHY driver FUJITA Tomonori
2024-08-04 23:38 ` [PATCH net-next v3 1/6] rust: sizes: add commonly used constants FUJITA Tomonori
2024-08-16  0:37   ` Andrew Lunn
2024-08-16  5:21     ` FUJITA Tomonori
2024-08-04 23:38 ` [PATCH net-next v3 2/6] rust: net::phy support probe callback FUJITA Tomonori
2024-08-16  0:40   ` Andrew Lunn
2024-08-16  5:21     ` FUJITA Tomonori
2024-08-04 23:38 ` FUJITA Tomonori [this message]
2024-08-16  0:41   ` [PATCH net-next v3 3/6] rust: net::phy implement AsRef<kernel::device::Device> trait Andrew Lunn
2024-08-04 23:38 ` [PATCH net-next v3 4/6] rust: net::phy unified read/write API for C22 and C45 registers FUJITA Tomonori
2024-08-16  1:09   ` Andrew Lunn
2024-08-16  5:27     ` FUJITA Tomonori
2024-08-04 23:38 ` [PATCH net-next v3 5/6] rust: net::phy unified genphy_read_status function " FUJITA Tomonori
2024-08-16  1:19   ` Andrew Lunn
2024-08-16  5:30     ` FUJITA Tomonori
2024-08-16 20:41       ` Andrew Lunn
2024-08-04 23:38 ` [PATCH net-next v3 6/6] net: phy: add Applied Micro QT2025 PHY driver FUJITA Tomonori
2024-08-16  1:45   ` Andrew Lunn
2024-08-16  6:17     ` FUJITA Tomonori
2024-08-16 20:47       ` Andrew Lunn
2024-08-17  4:50         ` FUJITA Tomonori
2024-08-05  1:10 ` [PATCH net-next v3 0/6] " Andrew Lunn
2024-08-14  2:57   ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240804233835.223460-4-fujita.tomonori@gmail.com \
    --to=fujita.tomonori@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=andrew@lunn.ch \
    --cc=benno.lossin@proton.me \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox