From: Andrew Lunn <andrew@lunn.ch>
To: FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: netdev@vger.kernel.org, rust-for-linux@vger.kernel.org,
tmgross@umich.edu, miguel.ojeda.sandonis@gmail.com,
benno.lossin@proton.me, aliceryhl@google.com
Subject: Re: [PATCH net-next v3 5/6] rust: net::phy unified genphy_read_status function for C22 and C45 registers
Date: Fri, 16 Aug 2024 22:41:38 +0200 [thread overview]
Message-ID: <7dbf30ef-4908-4600-8898-cb812024392b@lunn.ch> (raw)
In-Reply-To: <20240816.053009.1420518753499945384.fujita.tomonori@gmail.com>
On Fri, Aug 16, 2024 at 05:30:09AM +0000, FUJITA Tomonori wrote:
> On Fri, 16 Aug 2024 03:19:51 +0200
> Andrew Lunn <andrew@lunn.ch> wrote:
>
> >> +///
> >> +/// // Checks the link status and updates current link state via C22.
> >> +/// dev.genphy_read_status::<phy::C22>();
> >> +/// // Checks the link status and updates current link state via C45.
> >> +/// dev.genphy_read_status::<phy::C45>();
> >
> > Again, the word `via` is wrong here. You are looking at the link state
> > as reported by registers in the C22 namespace, or the C45 namespace.
>
> Yeah, how about the followings?
>
> /// // Checks the link status as reported by registers in the C22 namespace
> /// // and updates current link state.
> /// dev.genphy_read_status::<phy::C22>();
> /// // Checks the link status as reported by registers in the C45 namespace
> /// // and updates current link state.
> /// dev.genphy_read_status::<phy::C45>();
Yes, that is good.
Andrew
next prev parent reply other threads:[~2024-08-16 20:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 23:38 [PATCH net-next v3 0/6] net: phy: add Applied Micro QT2025 PHY driver FUJITA Tomonori
2024-08-04 23:38 ` [PATCH net-next v3 1/6] rust: sizes: add commonly used constants FUJITA Tomonori
2024-08-16 0:37 ` Andrew Lunn
2024-08-16 5:21 ` FUJITA Tomonori
2024-08-04 23:38 ` [PATCH net-next v3 2/6] rust: net::phy support probe callback FUJITA Tomonori
2024-08-16 0:40 ` Andrew Lunn
2024-08-16 5:21 ` FUJITA Tomonori
2024-08-04 23:38 ` [PATCH net-next v3 3/6] rust: net::phy implement AsRef<kernel::device::Device> trait FUJITA Tomonori
2024-08-16 0:41 ` Andrew Lunn
2024-08-04 23:38 ` [PATCH net-next v3 4/6] rust: net::phy unified read/write API for C22 and C45 registers FUJITA Tomonori
2024-08-16 1:09 ` Andrew Lunn
2024-08-16 5:27 ` FUJITA Tomonori
2024-08-04 23:38 ` [PATCH net-next v3 5/6] rust: net::phy unified genphy_read_status function " FUJITA Tomonori
2024-08-16 1:19 ` Andrew Lunn
2024-08-16 5:30 ` FUJITA Tomonori
2024-08-16 20:41 ` Andrew Lunn [this message]
2024-08-04 23:38 ` [PATCH net-next v3 6/6] net: phy: add Applied Micro QT2025 PHY driver FUJITA Tomonori
2024-08-16 1:45 ` Andrew Lunn
2024-08-16 6:17 ` FUJITA Tomonori
2024-08-16 20:47 ` Andrew Lunn
2024-08-17 4:50 ` FUJITA Tomonori
2024-08-05 1:10 ` [PATCH net-next v3 0/6] " Andrew Lunn
2024-08-14 2:57 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dbf30ef-4908-4600-8898-cb812024392b@lunn.ch \
--to=andrew@lunn.ch \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=fujita.tomonori@gmail.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).