Re: [PATCH] rust: acpi: add `acpi::DeviceId` abstraction

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, May 30, 2025 at 05:11:29PM +0100, Igor Korotin wrote:
> On Fri, May 30, 2025 at 3:43 PM Danilo Krummrich <dakr@kernel.org> wrote:
> >
> > On Fri, May 30, 2025 at 01:38:06PM +0100, Igor Korotin wrote:
> > > `acpi::DeviceId` is an abstraction around `struct acpi_device_id`.
> > >
> > > This is used by subsequent patches, in particular the i2c driver
> > > abstractions, to create ACPI device ID tables.
> > >
> > > Signed-off-by: Igor Korotin <igor.korotin.linux@gmail.com>
> >
> > As Greg mentioned it would be nice to see the subsequent patches.
> 
> Ok. There's a little misunderstanding from my side. I'm in the
> progress of implementation
> of I2C driver abstractions. I2C drivers can use either "of" or "acpi".
> The idea was to push this
> change first, because:
>  - It's quite standalone one.
>  - I'm not sure how much time it will take me to finalize I2C drivers
> abstractions.

If you don't need it now, then there's no rush to get it merged now :)

> If it is not appropriate way of commits, I'll then keep it until all is done.

We would like to see it be used first, to ensure that the code is
actually correct.

thanks,

greg k-h