[PATCH V1 0/2] Rust DRM build fix

[PATCH V1 0/2] Rust DRM build fix

[Mukesh Kumar Chaurasiya (IBM)]

rust drm gem shmem doesn't builds due to an import error of ARef from
types instead of sync.

This series fixes that and also makes CONFIG_RUST_DRM_GEM_SHMEM_HELPER
dependent of RUST and making it selectable from menuconfig.

Mukesh Kumar Chaurasiya (IBM) (2):
  rust/drm: import ARef from sync crate
  drm: Make CONFIG_RUST_DRM_GEM_SHMEM_HELPER selectable from menuconfig

 drivers/gpu/drm/Kconfig      | 4 ++--
 rust/kernel/drm/gem/shmem.rs | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.53.0

[PATCH V1 1/2] rust/drm: import ARef from sync crate

[Mukesh Kumar Chaurasiya (IBM)]

ARef is defined in sync and is getting used from types causing the
build to fail.

Fix this by using ARef from sync crate.

Signed-off-by: Mukesh Kumar Chaurasiya (IBM) <mkchauras@gmail.com>
---
 rust/kernel/drm/gem/shmem.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/drm/gem/shmem.rs b/rust/kernel/drm/gem/shmem.rs
index d025fb035195..50aa57bf78ca 100644
--- a/rust/kernel/drm/gem/shmem.rs
+++ b/rust/kernel/drm/gem/shmem.rs
@@ -19,8 +19,8 @@
     },
     error::to_result,
     prelude::*,
+    sync::aref::ARef,
     types::{
-        ARef,
         Opaque, //
     }, //
 };
-- 
2.53.0

[PATCH V1 2/2] drm: Make CONFIG_RUST_DRM_GEM_SHMEM_HELPER selectable from menuconfig

[Mukesh Kumar Chaurasiya (IBM)]

CONFIG_RUST_DRM_GEM_SHMEM_HELPER doesn't have a description leading to
not show up as a selectable menu item in menuconfig. Along side it's not
dependent on rust.

Fix this by making CONFIG_RUST_DRM_GEM_SHMEM_HELPER dependent on
CONFIG_RUST and give it a description string so that it can be selected
from menuconfig.

Signed-off-by: Mukesh Kumar Chaurasiya (IBM) <mkchauras@gmail.com>
---
 drivers/gpu/drm/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 8f5a8d3012e4..89adb700d710 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -269,8 +269,8 @@ config DRM_GEM_SHMEM_HELPER
 	  Choose this if you need the GEM shmem helper functions
 
 config RUST_DRM_GEM_SHMEM_HELPER
-	bool
-	depends on DRM && MMU
+	bool "Rust GEM shmem helper functions"
+	depends on DRM && MMU && RUST
 	select DRM_GEM_SHMEM_HELPER
 	help
 	  Choose this if you need the GEM shmem helper functions In Rust
-- 
2.53.0

Re: [PATCH V1 0/2] Rust DRM build fix

[Thomas Zimmermann]

Hi

Am 26.04.26 um 10:22 schrieb Mukesh Kumar Chaurasiya (IBM):
> rust drm gem shmem doesn't builds due to an import error of ARef from
> types instead of sync.
>
> This series fixes that and also makes CONFIG_RUST_DRM_GEM_SHMEM_HELPER
> dependent of RUST and making it selectable from menuconfig.

Memory managers are selected by drivers, not by users. You have to fix 
the driver rules instead.

Best regards
Thomas

>
> Mukesh Kumar Chaurasiya (IBM) (2):
>    rust/drm: import ARef from sync crate
>    drm: Make CONFIG_RUST_DRM_GEM_SHMEM_HELPER selectable from menuconfig
>
>   drivers/gpu/drm/Kconfig      | 4 ++--
>   rust/kernel/drm/gem/shmem.rs | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)