[PATCH v2] rust: bug: fix warn_on macro build error on UML

[PATCH v2] rust: bug: fix warn_on macro build error on UML

[FUJITA Tomonori]

From: FUJITA Tomonori <fujita.tomonori@gmail.com>

Callers that go through `kernel::prelude` have `CStrExt` in scope, but
code inside the `kernel` crate imports explicitly and may not. Using
`warn_on!` from such a module fails to build on UML, which is the only
configuration where `warn_flags!` needs a C string pointer rather than an
inline asm bug entry:

error[E0599]: no method named `as_char_ptr` found for reference `&ffi::CStr` in the current scope
   --> linux/rust/kernel/bug.rs:83:49
    |
 83 |                 $crate::c_str!(::core::file!()).as_char_ptr(),
    |                                                 ^^^^^^^^^^^
    |
   ::: linux/rust/kernel/time.rs:427:9
    |
427 |         warn_on!(self.nanos < 0);
    |         ------------------------ in this macro invocation
    |
    = help: items from traits can only be used if the trait is in scope
    = note: this error originates in the macro `$crate::warn_flags` which comes from the expansion of the macro `warn_on` (in Nightly builds, run with -Z mac)
help: trait `CStrExt` which provides `as_char_ptr` is implemented but not in scope; perhaps you want to import it
   --> linux/rust/kernel/time.rs:27:1
    |
 27 + use crate::str::CStrExt;

Call the method through its fully qualified path, which resolves
without any import at the expansion site.

Cc: stable@vger.kernel.org
Fixes: dff64b072708 ("rust: Add warn_on macro")
Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
---
v2
- Use the fully qualified path to CStrExt::as_char_ptr() instead of the free function
v1: https://lore.kernel.org/rust-for-linux/20260801022501.722493-1-tomo@flapping.org/

---
 rust/kernel/bug.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/bug.rs b/rust/kernel/bug.rs
index ed943960f851..40633a516a8f 100644
--- a/rust/kernel/bug.rs
+++ b/rust/kernel/bug.rs
@@ -80,7 +80,7 @@ macro_rules! warn_flags {
         // with a valid null-terminated string.
         unsafe {
             $crate::bindings::warn_slowpath_fmt(
-                $crate::c_str!(::core::file!()).as_char_ptr(),
+                $crate::str::CStrExt::as_char_ptr($crate::c_str!(::core::file!())),
                 line!() as $crate::ffi::c_int,
                 $flags as $crate::ffi::c_uint,
                 ::core::ptr::null(),

base-commit: 075b74841bd0065a3bda3440873c747938e69b68
-- 
2.43.0

Re: [PATCH v2] rust: bug: fix warn_on macro build error on UML

[Miguel Ojeda]

On Fri, Aug 7, 2026 at 1:24 PM FUJITA Tomonori <tomo@flapping.org> wrote:
>
> From: FUJITA Tomonori <fujita.tomonori@gmail.com>
>
> Callers that go through `kernel::prelude` have `CStrExt` in scope, but
> code inside the `kernel` crate imports explicitly and may not. Using
> `warn_on!` from such a module fails to build on UML, which is the only
> configuration where `warn_flags!` needs a C string pointer rather than an
> inline asm bug entry:
>
> error[E0599]: no method named `as_char_ptr` found for reference `&ffi::CStr` in the current scope
>    --> linux/rust/kernel/bug.rs:83:49
>     |
>  83 |                 $crate::c_str!(::core::file!()).as_char_ptr(),
>     |                                                 ^^^^^^^^^^^
>     |
>    ::: linux/rust/kernel/time.rs:427:9
>     |
> 427 |         warn_on!(self.nanos < 0);
>     |         ------------------------ in this macro invocation
>     |
>     = help: items from traits can only be used if the trait is in scope
>     = note: this error originates in the macro `$crate::warn_flags` which comes from the expansion of the macro `warn_on` (in Nightly builds, run with -Z mac)
> help: trait `CStrExt` which provides `as_char_ptr` is implemented but not in scope; perhaps you want to import it
>    --> linux/rust/kernel/time.rs:27:1
>     |
>  27 + use crate::str::CStrExt;
>
> Call the method through its fully qualified path, which resolves
> without any import at the expansion site.
>
> Cc: stable@vger.kernel.org
> Fixes: dff64b072708 ("rust: Add warn_on macro")
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>

Applied to `rust-next` -- thanks!

Cheers,
Miguel