From: FUJITA Tomonori <tomo@flapping.org>
To: a.hindborg@kernel.org, aliceryhl@google.com, arve@android.com,
boqun@kernel.org, brauner@kernel.org, cmllamas@google.com,
gary@garyguo.net, gregkh@linuxfoundation.org, ojeda@kernel.org,
tj@kernel.org, tkjos@android.com
Cc: acourbot@nvidia.com, anna-maria@linutronix.de,
bjorn3_gh@protonmail.com, dakr@kernel.org,
daniel.almeida@collabora.com, frederic@kernel.org,
jstultz@google.com, lossin@kernel.org, lyude@redhat.com,
sboyd@kernel.org, tamird@kernel.org, tglx@kernel.org,
tmgross@umich.edu, work@onurozkan.dev,
rust-for-linux@vger.kernel.org, jiangshanlai@gmail.com,
markus.probst@posteo.de,
FUJITA Tomonori <fujita.tomonori@gmail.com>
Subject: [PATCH v8 2/4] rust: time: add Delta::as_jiffies_unsigned()
Date: Fri, 2 Oct 2026 14:04:26 +0900 [thread overview]
Message-ID: <20261002050428.2746277-3-tomo@flapping.org> (raw)
In-Reply-To: <20261002050428.2746277-1-tomo@flapping.org>
From: FUJITA Tomonori <fujita.tomonori@gmail.com>
Delta<Jiffy> is signed, but some C functions, such as
queue_delayed_work_on(), take a span in jiffies as unsigned long. So
each caller has to clamp a negative value to zero and cast it before
it passes the value to C. Add a helper that does both.
Suggested-by: Gary Guo <gary@garyguo.net>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
---
rust/kernel/time.rs | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/rust/kernel/time.rs b/rust/kernel/time.rs
index 9f231bf25ead..b6a2aab12a50 100644
--- a/rust/kernel/time.rs
+++ b/rust/kernel/time.rs
@@ -363,6 +363,27 @@ pub const fn from_jiffies(jiffies: isize) -> Self {
pub const fn as_jiffies(self) -> isize {
self.value
}
+
+ /// Return the number of jiffies in the [`Delta`] as an unsigned value.
+ ///
+ /// If the number of jiffies is negative, zero is returned.
+ ///
+ /// # Examples
+ ///
+ /// ```
+ /// use kernel::time::Delta;
+ ///
+ /// // A negative span returns zero.
+ /// assert_eq!(Delta::from_jiffies(-1).as_jiffies_unsigned(), 0);
+ ///
+ /// // A positive span returns its value.
+ /// assert_eq!(Delta::from_jiffies(1).as_jiffies_unsigned(), 1);
+ /// ```
+ #[inline]
+ pub fn as_jiffies_unsigned(self) -> usize {
+ // CAST: `isize::max()` makes the value non-negative, so the cast keeps it.
+ isize::max(self.value, 0) as usize
+ }
}
impl ops::Add for Delta {
--
2.43.0
next prev parent reply other threads:[~2026-10-02 5:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <uhEZnSETYdRTGg0YbynELBmOxAIhnGrslFSPb14RUm57hPflUhCWVyZ6zzbLwhu6_fx6hv9DSrHnMCGE3v4sIQ==@protonmail.internalid>
2026-10-02 5:04 ` [PATCH v8 0/4] rust: use Delta instead of raw jiffies for timeouts and delays FUJITA Tomonori
2026-10-02 5:04 ` [PATCH v8 1/4] rust: time: make Delta::ZERO generic over the time unit FUJITA Tomonori
2026-10-08 12:54 ` Andreas Hindborg
2026-10-02 5:04 ` FUJITA Tomonori [this message]
2026-10-08 12:55 ` [PATCH v8 2/4] rust: time: add Delta::as_jiffies_unsigned() Andreas Hindborg
2026-10-02 5:04 ` [PATCH v8 3/4] rust: workqueue: take a Delta<Jiffy> for the enqueue delay FUJITA Tomonori
2026-10-02 5:04 ` [PATCH v8 4/4] rust: sync: condvar: use Delta<Jiffy> for timeout and result FUJITA Tomonori
2026-10-02 10:00 ` Gary Guo
2026-10-02 11:05 ` FUJITA Tomonori
2026-10-02 13:03 ` Gary Guo
2026-10-02 10:01 ` [PATCH v8 0/4] rust: use Delta instead of raw jiffies for timeouts and delays Gary Guo
2026-10-08 12:57 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002050428.2746277-3-tomo@flapping.org \
--to=tomo@flapping.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=arve@android.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=jiangshanlai@gmail.com \
--cc=jstultz@google.com \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=markus.probst@posteo.de \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tamird@kernel.org \
--cc=tglx@kernel.org \
--cc=tj@kernel.org \
--cc=tkjos@android.com \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox