Re: [PATCH v8 0/4] rust: use Delta instead of raw jiffies for timeouts and delays

["Gary Guo" <gary@garyguo.net>]

On Fri Oct 2, 2026 at 6:04 AM BST, FUJITA Tomonori wrote:
> From: FUJITA Tomonori <fujita.tomonori@gmail.com>
>
> CondVar::wait_interruptible_timeout() and Queue::enqueue_delayed() use
> a raw jiffies count (a plain c_ulong alias with no type safety).
> Callers have to know on their own that the value means jiffies and
> convert to/from it themselves, which is easy to get wrong (e.g.
> passing a millisecond value where a jiffies value is expected).
>
> Both APIs just take a span of time, so they can use Delta<Jiffy>
> instead. The condvar patch also updates binder's ioctl_freeze(), the
> only caller of wait_interruptible_timeout().
>
> This series is based on timekeeping-next, because the binder change
> uses Delta::to_jiffies_timeout(). The workqueue patch conflicts with
> Danilo's workqueue series [1], which also changes the signature of
> enqueue_delayed(). The conflict is trivial.
>
> Binder and workqueue maintainers, could you take a look at the changes
> to your code? Andreas and Boqun, which tree should this series go
> through?
>
> [1] https://lore.kernel.org/rust-for-linux/20260807165252.3849875-1-dakr@kernel.org/
>
> ---
> v8:
> - Add a patch to make Delta::ZERO generic over the time unit (Markus, Gary)
> - Add a patch to add Delta::as_jiffies_unsigned() (Gary)
> - workqueue: use as_jiffies_unsigned()
> - condvar: use Delta::ZERO in binder (Gary)
> v7: https://lore.kernel.org/rust-for-linux/20260930014124.1454138-1-tomo@flapping.org/
>
> FUJITA Tomonori (4):
>   rust: time: make Delta::ZERO generic over the time unit
>   rust: time: add Delta::as_jiffies_unsigned()
>   rust: workqueue: take a Delta<Jiffy> for the enqueue delay
>   rust: sync: condvar: use Delta<Jiffy> for timeout and result

For the series:

Reviewed-by: Gary Guo <gary@garyguo.net>

>
>  drivers/android/binder/process.rs |  7 ++++---
>  rust/kernel/sync/condvar.rs       | 31 ++++++++++++++++++++--------
>  rust/kernel/time.rs               | 34 ++++++++++++++++++++++++++++---
>  rust/kernel/workqueue.rs          | 13 ++++++++----
>  4 files changed, 66 insertions(+), 19 deletions(-)
>
>
> base-commit: 2ea0119f72dba597aa8a98cbdb72c564bfc5cb38