Re: [PATCH 4/6] gpu: nova-core: add FbHal::frts_size() for GA100 support

[Timur Tabi <ttabi@nvidia.com>]

On Tue, 2026-04-14 at 10:04 +0900, Alexandre Courbot wrote:
> > Note that we cannot use supports_display() to determine the FRTS
> > size because there are other GPUs (e.g. GA102GL) that have display
> > disabled (and so supports_display() returns False), but the FRTS
> > window size still needs to be 1MB.
> 
> Order-wise this should probably come before patch 3 - I was a bit
> confused about the fact that we are checking the size of the frts region
> since it is defined as a constant until this patch.

I put it in this order because we don't want to call run_fwsec_frts() if frts is empty. 
Otherwise, frts could be empty because of this patch, and we would call run_fwsec_frts() anyway.

> > +
> > +    fn frts_size(&self) -> u64 {
> > +        usize_as_u64(SZ_1M)
> > +    }
> 
> This implementation is identical to the one in `tu102.rs`. As a pattern,
> when different HALs use different implementations, we define it into a
> function that both HALs can call instead of repeating the code (see for
> instance how `read_sysmem_flush_page` is handled between ga100 and
> ga102).
> 

I figured since all it did is return a constant, that it would be simpler to just do that, but I
will change it.