From: Timur Tabi <ttabi@nvidia.com>
To: Alexandre Courbot <acourbot@nvidia.com>,
"dakr@kernel.org" <dakr@kernel.org>,
Eliot Courtney <ecourtney@nvidia.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH 3/6] gpu: nova-core: only boot FRTS if it actually exists
Date: Mon, 13 Apr 2026 19:49:51 +0000 [thread overview]
Message-ID: <befb74f0523b01622fef9f18691b97481c5875f4.camel@nvidia.com> (raw)
In-Reply-To: <DHRQL0KVSETV.2YWE5W5JFGHJE@nvidia.com>
On Mon, 2026-04-13 at 13:19 +0900, Eliot Courtney wrote:
> > - Self::run_fwsec_frts(dev, chipset, gsp_falcon, bar, &bios, &fb_layout)?;
> > + // Only boot FRTS if it actually exists.
> > + if !fb_layout.frts.is_empty() {
> > + Self::run_fwsec_frts(dev, chipset, gsp_falcon, bar, &bios, &fb_layout)?;
> > + }
> >
> > let booter_loader = BooterFirmware::new(
> > dev,
>
> If FRTS is optional, WDYT about making fb_layout.frts an Option<FbRange>
> and having the frts_size hal method return Option<NonZeroUsize> for
> example? I think it will make it clearer in other locations that use
> FRTS that it possibly might not exist.
Yeah, I like that.
next prev parent reply other threads:[~2026-04-13 19:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 20:37 [PATCH 0/6] gpu: nova-core: add GA100 support Timur Tabi
2026-04-10 20:37 ` [PATCH 1/6] gpu: nova-core: use correct fwsignature for GA100 Timur Tabi
2026-04-13 4:10 ` Eliot Courtney
2026-04-10 20:37 ` [PATCH 2/6] gpu: nova-core: do not consider 0xBB77 as a valid PCI ROM header signature Timur Tabi
2026-04-13 4:11 ` Eliot Courtney
2026-04-10 20:37 ` [PATCH 3/6] gpu: nova-core: only boot FRTS if it actually exists Timur Tabi
2026-04-13 4:19 ` Eliot Courtney
2026-04-13 19:49 ` Timur Tabi [this message]
2026-04-13 23:48 ` Timur Tabi
2026-04-14 18:10 ` Timur Tabi
2026-04-15 2:35 ` Eliot Courtney
2026-04-10 20:37 ` [PATCH 4/6] gpu: nova-core: add FbHal::frts_size() for GA100 support Timur Tabi
2026-04-14 1:04 ` Alexandre Courbot
2026-04-14 3:13 ` Timur Tabi
2026-04-14 6:03 ` Alexandre Courbot
2026-04-10 20:37 ` [PATCH 5/6] gpu: nova-core: skip the IFR header if present Timur Tabi
2026-04-13 4:53 ` Eliot Courtney
2026-04-14 20:42 ` Timur Tabi
2026-04-10 20:37 ` [PATCH 6/6] gpu: nova-core: enable GA100 Timur Tabi
2026-04-13 4:20 ` Eliot Courtney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=befb74f0523b01622fef9f18691b97481c5875f4.camel@nvidia.com \
--to=ttabi@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=dakr@kernel.org \
--cc=ecourtney@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox