From: Benno Lossin <benno.lossin@proton.me>
To: Alice Ryhl <aliceryhl@google.com>
Cc: Danilo Krummrich <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] rust: alloc: add Vec::pop
Date: Fri, 21 Mar 2025 09:23:51 +0000 [thread overview]
Message-ID: <D8LU2SGJ1T4U.1JPJWNV09A5UT@proton.me> (raw)
In-Reply-To: <Z90YyLPhil2vBTc_@google.com>
On Fri Mar 21, 2025 at 8:44 AM CET, Alice Ryhl wrote:
> On Thu, Mar 20, 2025 at 10:11:09PM +0000, Benno Lossin wrote:
>> On Thu Mar 20, 2025 at 2:52 PM CET, Alice Ryhl wrote:
>> > +
>> > + // INVARIANT: If the first `len` elements are valid, then the first `len-1` elements are
>>
>> Please add spaces around `-`.
>
> I can do that, but does it really read better?
That's how rustfmt would format it and I do think it improves
readability for me.
>> > + // valid.
>> > + self.len = len_sub_1;
>> > +
>> > + // INVARIANT: This invalidates a value in this vector's allocation, but the Vec invariants
>> > + // do not require it to be valid because `self.len <= len_sub_1`.
>>
>> I don't think this should be an `INVARIANT` comment. Maybe we don't even
>> need it.
>
> I can drop the INVARIANT: prefix.
Sounds good.
---
Cheers,
Benno
next prev parent reply other threads:[~2025-03-21 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 22:11 [PATCH 2/5] rust: alloc: add Vec::pop Benno Lossin
2025-03-21 7:44 ` Alice Ryhl
2025-03-21 9:23 ` Benno Lossin [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-03-20 13:52 [PATCH 0/5] Additional methods for Vec Alice Ryhl
2025-03-20 13:52 ` [PATCH 2/5] rust: alloc: add Vec::pop Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8LU2SGJ1T4U.1JPJWNV09A5UT@proton.me \
--to=benno.lossin@proton.me \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox