Re: [PATCH v2 1/4] rust: sync: Add i8/i16 atomic_load_acquire/atomic_store_release helpers

["Alexandre Courbot" <acourbot@nvidia.com>]

On Mon Nov 17, 2025 at 9:10 AM JST, FUJITA Tomonori wrote:
> Add helper functions to expose smp_load_acquire() and
> smp_store_release() for i8 and i16 types.
>
> The smp_load_acquire() and smp_store_release() macros require type
> information (sizeof) to generate appropriate architecture-specific
> memory ordering instructions. Therefore, separate helper functions are
> needed for each type size.
>
> These helpers will be used by the upcoming Atomic<i8> and Atomic<i16>
> implementation to provide proper Acquire/Release semantics across all
> architectures.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
> ---
>  rust/helpers/atomic_ext.c | 23 +++++++++++++++++++++++
>  rust/helpers/helpers.c    |  1 +
>  2 files changed, 24 insertions(+)
>  create mode 100644 rust/helpers/atomic_ext.c

Why not add these to `rust/helpers/atomic.c`?

>
> diff --git a/rust/helpers/atomic_ext.c b/rust/helpers/atomic_ext.c
> new file mode 100644
> index 000000000000..d05f6f7ba10c
> --- /dev/null
> +++ b/rust/helpers/atomic_ext.c
> @@ -0,0 +1,23 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include <asm/barrier.h>
> +
> +s8 rust_helper_atomic_i8_load_acquire(s8 *ptr)

I guess you will want to prefix these with `__rust_helper` in the next
revision.