Re: [PATCH v2 0/4] rust: Add i8 and i16 atomic support

[Boqun Feng <boqun.feng@gmail.com>]

On Wed, Dec 03, 2025 at 12:41:48PM +0900, FUJITA Tomonori wrote:
> On Mon, 17 Nov 2025 09:10:31 +0900
> FUJITA Tomonori <fujita.tomonori@gmail.com> wrote:
> 
> > This adds Atomic<i8> and Atomic<i16> support; including
> > load/store(Relaxed) and load(Acquire)/store(Release) operations.
> > 
> > Relaxed operations are implemented in C's READ_ONCE() and
> > WRITE_ONCE() macros.
> > 
> > load(Acquire)/store(Release) use C's smp_load_acquire() and
> > smp_store_release() macros. They internally use the appropriate
> > architecture-specific instructions.
> > 
> > v2:
> > - Implement relaxed operations by using C's READ_ONCE/WRITE_ONCE
> > - Rename smp_load_acquire() and smp_store_release() helpers
> > - Simplify the macro to generate atomic methods
> > v1: https://lore.kernel.org/rust-for-linux/20251115050305.3872412-1-fujita.tomonori@gmail.com/
> > 
> > FUJITA Tomonori (4):
> >   rust: sync: Add i8/i16 atomic_load_acquire/atomic_store_release
> >     helpers
> >   rust: helpers: Add i8/i16 relaxed atomic helpers
> >   rust: sync: atomic: Add i8/i16 load and store support
> >   rust: sync: atomic: Add store_release/load_acquire tests
> > 
> >  rust/helpers/atomic_ext.c            | 44 +++++++++++++++++++++++++
> >  rust/helpers/helpers.c               |  1 +
> >  rust/kernel/sync/atomic/internal.rs  | 48 ++++++++++++++++++++++++++++
> >  rust/kernel/sync/atomic/predefine.rs | 24 +++++++++++++-
> >  4 files changed, 116 insertions(+), 1 deletion(-)
> >  create mode 100644 rust/helpers/atomic_ext.c
> 
> Boqun, any thoughts on this?
> 

Sorry for the late response, the patchset looks good to me, I'm just
waiting for more reviews and some free time to take it.

Regards,
Boqun

> If we build Atomic<bool> on top of this patch's Atomic<u8> support, it
> seems we could replace all of the Rust native atomic types currently
> in use.
>