* [PATCH] rust: module_param: use `pr_warn_once!` for null pointer warning
@ 2026-04-27 8:11 Andreas Hindborg
2026-04-27 11:28 ` Daniel Gomez
2026-04-27 13:36 ` Gary Guo
0 siblings, 2 replies; 3+ messages in thread
From: Andreas Hindborg @ 2026-04-27 8:11 UTC (permalink / raw)
To: Luis Chamberlain, Petr Pavlu, Daniel Gomez, Sami Tolvanen,
Aaron Tomlin, Miguel Ojeda, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Alice Ryhl, Trevor Gross,
Danilo Krummrich
Cc: linux-modules, linux-kernel, rust-for-linux, Andreas Hindborg
Replace `pr_warn!` and the accompanying TODO with `pr_warn_once!`, now that
the macro is available.
Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
---
rust/kernel/module_param.rs | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/rust/kernel/module_param.rs b/rust/kernel/module_param.rs
index 6a8a7a875643..dd6d663a0a3c 100644
--- a/rust/kernel/module_param.rs
+++ b/rust/kernel/module_param.rs
@@ -62,8 +62,7 @@ pub trait ModuleParam: Sized + Copy {
// NOTE: If we start supporting arguments without values, val _is_ allowed
// to be null here.
if val.is_null() {
- // TODO: Use pr_warn_once available.
- crate::pr_warn!("Null pointer passed to `module_param::set_param`");
+ crate::pr_warn_once!("Null pointer passed to `module_param::set_param`");
return EINVAL.to_errno();
}
---
base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
change-id: 20260427-params-pr-once-481c03df3e2a
Best regards,
--
Andreas Hindborg <a.hindborg@kernel.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: module_param: use `pr_warn_once!` for null pointer warning
2026-04-27 8:11 [PATCH] rust: module_param: use `pr_warn_once!` for null pointer warning Andreas Hindborg
@ 2026-04-27 11:28 ` Daniel Gomez
2026-04-27 13:36 ` Gary Guo
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Gomez @ 2026-04-27 11:28 UTC (permalink / raw)
To: Andreas Hindborg, Luis Chamberlain, Petr Pavlu, Sami Tolvanen,
Aaron Tomlin, Miguel Ojeda, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Alice Ryhl, Trevor Gross,
Danilo Krummrich
Cc: linux-modules, linux-kernel, rust-for-linux
On 27/04/2026 10.11, Andreas Hindborg wrote:
> Replace `pr_warn!` and the accompanying TODO with `pr_warn_once!`, now that
> the macro is available.
>
> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
Available since v7.0-rc1. LGTM,
Reviewed-by: Daniel Gomez <da.gomez@samsung.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: module_param: use `pr_warn_once!` for null pointer warning
2026-04-27 8:11 [PATCH] rust: module_param: use `pr_warn_once!` for null pointer warning Andreas Hindborg
2026-04-27 11:28 ` Daniel Gomez
@ 2026-04-27 13:36 ` Gary Guo
1 sibling, 0 replies; 3+ messages in thread
From: Gary Guo @ 2026-04-27 13:36 UTC (permalink / raw)
To: Andreas Hindborg, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Miguel Ojeda, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Alice Ryhl, Trevor Gross,
Danilo Krummrich
Cc: linux-modules, linux-kernel, rust-for-linux
On Mon Apr 27, 2026 at 9:11 AM BST, Andreas Hindborg wrote:
> Replace `pr_warn!` and the accompanying TODO with `pr_warn_once!`, now that
> the macro is available.
>
> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
Reviewed-by: Gary Guo <gary@garyguo.net>
> ---
> rust/kernel/module_param.rs | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-27 13:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-27 8:11 [PATCH] rust: module_param: use `pr_warn_once!` for null pointer warning Andreas Hindborg
2026-04-27 11:28 ` Daniel Gomez
2026-04-27 13:36 ` Gary Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox