Rust for Linux List
 help / color / mirror / Atom feed
* Re: [PATCH 7.3 0000/2651] 7.3.6-rc1 review
       [not found] <20261118150247.972732815@linuxfoundation.org>
@ 2026-11-18 19:02 ` Thorsten Leemhuis
  2026-11-18 20:39   ` Gary Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Thorsten Leemhuis @ 2026-11-18 19:02 UTC (permalink / raw)
  To: Greg Kroah-Hartman, stable
  Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
	lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee,
	rwarsow, conor, hargar, broonie, achill, sr, Miguel Ojeda, RUST

On 11/18/26 15:20, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 7.3.6 release.
> There are 2651 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Fri, 20 Nov 2026 14:55:47 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v7.x/stable-review/patch-7.3.6-rc1.gz
> [...]

This failed to build for me due to a problem with rust during the "make
bzimage" stage:

"""> error[E0432]: unresolved import `crate::util`
>   --> rust/pin-init/internal/src/init.rs:17:5
>    |
> 17 |     util::*,
>    |     ^^^^ could not find `util` in the crate root
> 
> error[E0599]: no method named `extract_cfg_attrs` found for struct `Vec<Attribute>` in the current scope
>    --> rust/pin-init/internal/src/init.rs:171:39
>     |
> 171 |                 let cfg = field.attrs.extract_cfg_attrs();
>     |                                       ^^^^^^^^^^^^^^^^^
>     |
> help: there is a method `extract_if` with a similar name, but with different arguments
>    --> library/alloc/src/vec/mod.rs:4245:4
> 
> error[E0599]: no method named `as_ident` found for reference `&Member` in the current scope
>    --> rust/pin-init/internal/src/init.rs:413:28
>     |
> 413 |         let ident = member.as_ident();
>     |                            ^^^^^^^^ method not found in `&Member`
> 
> error: aborting due to 3 previous errors
> 
> Some errors have detailed explanations: E0432, E0599.
> For more information about an error, try `rustc --explain E0432`.
> make[2]: *** [rust/Makefile:649: rust/libpin_init_internal.so] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builddir/build/BUILD/kernel-7.3.6-build/kernel-7.3.6-rc1/linux-7.3.6-0.rc1.400.vanilla.fc45.x86_64/Makefile:1440: prepare] Error 2
> make: *** [Makefile:256: __sub-make] Error 2
"""
Full log:
https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/fedora-rc/fedora-45-x86_64/11350094-stablerc-fedorarc-releases/builder-live.log.gz

Have to run, so not time to look at where this is coming from right now,
sorry.

Ciao, Thorsten

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 7.3 0000/2651] 7.3.6-rc1 review
  2026-11-18 19:02 ` [PATCH 7.3 0000/2651] 7.3.6-rc1 review Thorsten Leemhuis
@ 2026-11-18 20:39   ` Gary Guo
  2026-11-19  3:23     ` Alice C. Munduruca
  0 siblings, 1 reply; 3+ messages in thread
From: Gary Guo @ 2026-11-18 20:39 UTC (permalink / raw)
  To: Thorsten Leemhuis, Greg Kroah-Hartman, stable
  Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
	lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee,
	rwarsow, conor, hargar, broonie, achill, sr, Miguel Ojeda, RUST

On Wed Nov 18, 2026 at 7:02 PM GMT, Thorsten Leemhuis wrote:
> On 11/18/26 15:20, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 7.3.6 release.
>> There are 2651 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>> 
>> Responses should be made by Fri, 20 Nov 2026 14:55:47 +0000.
>> Anything received after that time might be too late.
>> 
>> The whole patch series can be found in one patch at:
>> 	https://www.kernel.org/pub/linux/kernel/v7.x/stable-review/patch-7.3.6-rc1.gz
>> [...]
>
> This failed to build for me due to a problem with rust during the "make
> bzimage" stage:
>
> """> error[E0432]: unresolved import `crate::util`
>>   --> rust/pin-init/internal/src/init.rs:17:5
>>    |
>> 17 |     util::*,
>>    |     ^^^^ could not find `util` in the crate root
>> 
>> error[E0599]: no method named `extract_cfg_attrs` found for struct `Vec<Attribute>` in the current scope
>>    --> rust/pin-init/internal/src/init.rs:171:39
>>     |
>> 171 |                 let cfg = field.attrs.extract_cfg_attrs();
>>     |                                       ^^^^^^^^^^^^^^^^^
>>     |
>> help: there is a method `extract_if` with a similar name, but with different arguments
>>    --> library/alloc/src/vec/mod.rs:4245:4
>> 
>> error[E0599]: no method named `as_ident` found for reference `&Member` in the current scope
>>    --> rust/pin-init/internal/src/init.rs:413:28
>>     |
>> 413 |         let ident = member.as_ident();
>>     |                            ^^^^^^^^ method not found in `&Member`
>> 
>> error: aborting due to 3 previous errors
>> 
>> Some errors have detailed explanations: E0432, E0599.
>> For more information about an error, try `rustc --explain E0432`.
>> make[2]: *** [rust/Makefile:649: rust/libpin_init_internal.so] Error 1
>> make[2]: *** Waiting for unfinished jobs....
>> make[1]: *** [/builddir/build/BUILD/kernel-7.3.6-build/kernel-7.3.6-rc1/linux-7.3.6-0.rc1.400.vanilla.fc45.x86_64/Makefile:1440: prepare] Error 2

It looks like there's missing dependency not picked for pin-init changes.

Greg, can you drop

    [PATCH 7.3 0580/2651] rust: pin-init: internal: init: emit `slot` using mixed site hygiene
    [PATCH 7.3 0579/2651] rust: pin-init: internal: init: support tuple struct constructor syntax
    [PATCH 7.3 0578/2651] rust: pin-init: internal: init: support tuple structs in `[pin_]init!`

? While patch 0580 is a fix, pin-init is not used in a way that manifested the
issue in 7.3, so it's simpler to just drop it and the other two picked as dep of
it.

Best,
Gary

>> make: *** [Makefile:256: __sub-make] Error 2
> """
> Full log:
> https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/fedora-rc/fedora-45-x86_64/11350094-stablerc-fedorarc-releases/builder-live.log.gz
>
> Have to run, so not time to look at where this is coming from right now,
> sorry.
>
> Ciao, Thorsten



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 7.3 0000/2651] 7.3.6-rc1 review
  2026-11-18 20:39   ` Gary Guo
@ 2026-11-19  3:23     ` Alice C. Munduruca
  0 siblings, 0 replies; 3+ messages in thread
From: Alice C. Munduruca @ 2026-11-19  3:23 UTC (permalink / raw)
  To: Gary Guo, Thorsten Leemhuis, Greg Kroah-Hartman, stable
  Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
	lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee,
	rwarsow, conor, hargar, broonie, achill, sr, Miguel Ojeda, RUST

On Wed Nov 18, 2026 at 3:39 PM EST, Gary Guo wrote:
> On Wed Nov 18, 2026 at 7:02 PM GMT, Thorsten Leemhuis wrote:
>> On 11/18/26 15:20, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 7.3.6 release.
>>> There are 2651 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>> 
>>> Responses should be made by Fri, 20 Nov 2026 14:55:47 +0000.
>>> Anything received after that time might be too late.
>>> 
>>> The whole patch series can be found in one patch at:
>>> 	https://www.kernel.org/pub/linux/kernel/v7.x/stable-review/patch-7.3.6-rc1.gz
>>> [...]
>>
>> This failed to build for me due to a problem with rust during the "make
>> bzimage" stage:
>>
>> """> error[E0432]: unresolved import `crate::util`
>>>   --> rust/pin-init/internal/src/init.rs:17:5
>>>    |
>>> 17 |     util::*,
>>>    |     ^^^^ could not find `util` in the crate root
>>> 
>>> error[E0599]: no method named `extract_cfg_attrs` found for struct `Vec<Attribute>` in the current scope
>>>    --> rust/pin-init/internal/src/init.rs:171:39
>>>     |
>>> 171 |                 let cfg = field.attrs.extract_cfg_attrs();
>>>     |                                       ^^^^^^^^^^^^^^^^^
>>>     |
>>> help: there is a method `extract_if` with a similar name, but with different arguments
>>>    --> library/alloc/src/vec/mod.rs:4245:4
>>> 
>>> error[E0599]: no method named `as_ident` found for reference `&Member` in the current scope
>>>    --> rust/pin-init/internal/src/init.rs:413:28
>>>     |
>>> 413 |         let ident = member.as_ident();
>>>     |                            ^^^^^^^^ method not found in `&Member`
>>> 
>>> error: aborting due to 3 previous errors
>>> 
>>> Some errors have detailed explanations: E0432, E0599.
>>> For more information about an error, try `rustc --explain E0432`.
>>> make[2]: *** [rust/Makefile:649: rust/libpin_init_internal.so] Error 1
>>> make[2]: *** Waiting for unfinished jobs....
>>> make[1]: *** [/builddir/build/BUILD/kernel-7.3.6-build/kernel-7.3.6-rc1/linux-7.3.6-0.rc1.400.vanilla.fc45.x86_64/Makefile:1440: prepare] Error 2
>
> It looks like there's missing dependency not picked for pin-init changes.
>
> Greg, can you drop
>
>     [PATCH 7.3 0580/2651] rust: pin-init: internal: init: emit `slot` using mixed site hygiene
>     [PATCH 7.3 0579/2651] rust: pin-init: internal: init: support tuple struct constructor syntax
>     [PATCH 7.3 0578/2651] rust: pin-init: internal: init: support tuple structs in `[pin_]init!`
>
> ? While patch 0580 is a fix, pin-init is not used in a way that manifested the
> issue in 7.3, so it's simpler to just drop it and the other two picked as dep of
> it.
>
> Best,
> Gary
>

Hey all,

After dropping the above patches there remain a few compilation errors with LLVM=1. They all seem to
relate to pointers in bindings being sent across threads. I am unable to diagnose the issue farther
than this, as I'm just starting to dabble in rust/ so hopefully someone more experienced can track
down the patch at issue.

I've uploaded the build log alongside the config used in the pastebin links below.

>>> make: *** [Makefile:256: __sub-make] Error 2
>> """
>> Full log:
>> https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/fedora-rc/fedora-45-x86_64/11350094-stablerc-fedorarc-releases/builder-live.log.gz
>>
>> Have to run, so not time to look at where this is coming from right now,
>> sorry.
>>
>> Ciao, Thorsten

Link: https://pastebin.com/WCpUdkaC
Link: https://pastebin.com/5BUM2Cys

Sorry and best of luck,
 - Alice C. Munduruca

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-19  3:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20261118150247.972732815@linuxfoundation.org>
2026-11-18 19:02 ` [PATCH 7.3 0000/2651] 7.3.6-rc1 review Thorsten Leemhuis
2026-11-18 20:39   ` Gary Guo
2026-11-19  3:23     ` Alice C. Munduruca

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox