Rust for Linux List
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Alice Ryhl" <aliceryhl@google.com>
Cc: "Gary Guo" <gary@garyguo.net>, <daniel.almeida@collabora.com>,
	<airlied@gmail.com>, <simona@ffwll.ch>, <lossin@kernel.org>,
	<ojeda@kernel.org>, <boqun@kernel.org>,
	<bjorn3_gh@protonmail.com>, <a.hindborg@kernel.org>,
	<tmgross@umich.edu>, <tamird@kernel.org>, <acourbot@nvidia.com>,
	<work@onurozkan.dev>, <dri-devel@lists.freedesktop.org>,
	<rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] drm/tyr: name resource lifetimes after their types
Date: Thu, 19 Nov 2026 17:38:11 +0100	[thread overview]
Message-ID: <DMZC2LXTA7IC.5BU39FYHJU1J@kernel.org> (raw)
In-Reply-To: <20261119154430.918072-1-aliceryhl@google.com>

On Thu Nov 19, 2026 at 4:44 PM CET, Alice Ryhl wrote:
> On Thu, Nov 19, 2026 at 02:57:37PM +0100, Danilo Krummrich wrote:
>> I think in the end it comes down to personal preference, so this is fine with me
>> too.
>>
>> Though, I'd use a generic name in the latter case too, such that it doesn't need
>> to be changed once a second resource is referenced later on.
>
> Agreed, using a generic name like `'a` (or borrowed-resource names for
> invariant lifetimes) sounds good to me too.
>
> Also, when updating this for v2, note that `VmAsData<'drm>` in
> `mmu/address_space.rs` and `GpuVmData<'drm>` (along with `VmMapArgs`,
> `VmOpType`, `VmOpResources`, `VmOpRequest`, and `PtUpdateContext` in
> `vm.rs`) were still left using `'drm`.

Before I respin I'll wait for Gary to look into how the existential lifetime
could be moved to Vm (which is what I considered initially, but couldn't really
get to work).

I think having it on Firmware is reasonable, but I think having it on Vm would
probably be better.

  reply	other threads:[~2026-11-19 16:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 23:37 [PATCH 0/4] drm/tyr: use pin-init self-referential support Danilo Krummrich
2026-11-18 23:37 ` [PATCH 1/4] drm/tyr: name resource lifetimes after their types Danilo Krummrich
2026-11-19  2:08   ` Gary Guo
2026-11-19 10:34     ` Danilo Krummrich
2026-11-19 11:28       ` Gary Guo
2026-11-19 12:28         ` Danilo Krummrich
2026-11-19 12:56           ` Gary Guo
2026-11-19 13:57             ` Danilo Krummrich
2026-11-19 15:44               ` Alice Ryhl
2026-11-19 16:38                 ` Danilo Krummrich [this message]
2026-11-18 23:37 ` [PATCH 2/4] rust: pin-init: internal: suppress multiple_bound_locations Danilo Krummrich
2026-11-19  2:23   ` Gary Guo
2026-11-18 23:37 ` [PATCH 3/4] drm/tyr: use pin-init self-referential support Danilo Krummrich
2026-11-18 23:37 ` [PATCH 4/4] drm/tyr: use ScopeGuard for firmware loading cleanup Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMZC2LXTA7IC.5BU39FYHJU1J@kernel.org \
    --to=dakr@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox