From: Boqun Feng <boqun.feng@gmail.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Jason Devers" <dev.json2@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org, boris.chen.czy@gmail.com
Subject: Re: [PATCH v6] rust: sync: add #[must_use] to Lock::try_lock
Date: Wed, 15 Jan 2025 10:12:50 -0800 [thread overview]
Message-ID: <Z4f6onexz3Nuv3u8@tardis.local> (raw)
In-Reply-To: <CAH5fLggqU+58A0c3btSkwMRHZ+=X=cHnzy3cHbB5Oc6kUi8Z=A@mail.gmail.com>
On Thu, Jan 09, 2025 at 02:05:41PM +0100, Alice Ryhl wrote:
> On Thu, Dec 12, 2024 at 4:48 PM Jason Devers <dev.json2@gmail.com> wrote:
> >
> > The `Lock::try_lock` function returns an `Option<Guard<...>>`, but it
> > currently does not issue a warning if the return value is unused.
> > To avoid potential bugs, the `#[must_use]` annotation is added to ensure proper usage.
> >
> > Note that `T` is `#[must_use]` but `Option<T>` is not.
> > For more context, see: https://github.com/rust-lang/rust/issues/71368.
> >
> > Suggested-by: Alice Ryhl <aliceryhl@google.com>
> > Link: https://github.com/Rust-for-Linux/linux/issues/1133
> > Signed-off-by: Jason Devers <dev.json2@gmail.com>
>
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Queued. I reworded a bit on the commit log because of the tip maintainer
guideline. Thank you both!
Regards,
Boqun
next prev parent reply other threads:[~2025-01-15 18:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-08 18:48 [PATCH] rust: sync: add #[must_use] to Lock::try_lock Jason Devers
2024-12-08 19:11 ` Boqun Feng
[not found] ` <CAOJvc-bi6ym6ZMAbDSh4H_L6LQXoTs8oNY07SZ1crzXxY9BodQ@mail.gmail.com>
2024-12-08 19:43 ` jos
2024-12-08 20:02 ` Boqun Feng
2024-12-08 20:50 ` Jason Devers
2024-12-08 21:57 ` Tamir Duberstein
2024-12-08 22:09 ` jos
2024-12-08 22:26 ` Jason Devers
2024-12-09 11:57 ` Miguel Ojeda
2024-12-09 17:09 ` jos
2024-12-11 2:05 ` [PATCH v4] " Jason Devers
2024-12-11 9:17 ` Alice Ryhl
2024-12-11 9:45 ` Miguel Ojeda
2024-12-11 17:05 ` jos
2024-12-11 18:57 ` Boqun Feng
2024-12-12 3:11 ` [PATCH v5] " Jason Devers
2024-12-12 11:25 ` Miguel Ojeda
2024-12-12 15:47 ` [PATCH v6] " Jason Devers
2024-12-15 20:05 ` Boqun Feng
2025-01-09 13:05 ` Alice Ryhl
2025-01-15 18:12 ` Boqun Feng [this message]
2024-12-08 21:28 ` [PATCH] " Miguel Ojeda
2024-12-09 7:11 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4f6onexz3Nuv3u8@tardis.local \
--to=boqun.feng@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boris.chen.czy@gmail.com \
--cc=dev.json2@gmail.com \
--cc=gary@garyguo.net \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox