* [PATCH] rust: fix sorting of rust/bindings/bindings_helper.h's #includes Suggested by: Miguel Ojeda <ojeda@kernel.org> Link: https://github.com/Rust-for-Linux/linux/issues/1002
@ 2023-04-26 21:45 Roy Matero
2023-04-26 22:06 ` Miguel Ojeda
0 siblings, 1 reply; 2+ messages in thread
From: Roy Matero @ 2023-04-26 21:45 UTC (permalink / raw)
To: alex.gaynor, wedsonaf, boqun.feng, gary, bjorn3_gh, benno.lossin,
yakoyoku, aliceryhl, materoy, rust-for-linux, linux-kernel
Cc: ojeda
Signed-off-by: Roy Matero <materoy@proton.me>
---
rust/bindings/bindings_helper.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
index 50e7a76d5455..dc8d97272e71 100644
--- a/rust/bindings/bindings_helper.h
+++ b/rust/bindings/bindings_helper.h
@@ -6,10 +6,10 @@
* Sorted alphabetically.
*/
-#include <linux/slab.h>
#include <linux/refcount.h>
-#include <linux/wait.h>
#include <linux/sched.h>
+#include <linux/slab.h>
+#include <linux/wait.h>
/* `bindgen` gets confused at certain things. */
const gfp_t BINDINGS_GFP_KERNEL = GFP_KERNEL;
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rust: fix sorting of rust/bindings/bindings_helper.h's #includes Suggested by: Miguel Ojeda <ojeda@kernel.org> Link: https://github.com/Rust-for-Linux/linux/issues/1002
2023-04-26 21:45 [PATCH] rust: fix sorting of rust/bindings/bindings_helper.h's #includes Suggested by: Miguel Ojeda <ojeda@kernel.org> Link: https://github.com/Rust-for-Linux/linux/issues/1002 Roy Matero
@ 2023-04-26 22:06 ` Miguel Ojeda
0 siblings, 0 replies; 2+ messages in thread
From: Miguel Ojeda @ 2023-04-26 22:06 UTC (permalink / raw)
To: Roy Matero
Cc: alex.gaynor, wedsonaf, boqun.feng, gary, bjorn3_gh, benno.lossin,
yakoyoku, aliceryhl, rust-for-linux, linux-kernel, ojeda
On Wed, Apr 26, 2023 at 11:46 PM Roy Matero <materoy@proton.me> wrote:
>
> Signed-off-by: Roy Matero <materoy@proton.me>
Thank you for the patch!
Something strange happened -- it looks like the body went into the
subject line. Did you use `git-send-email`?
Also, please use a dash in `Suggested-by` and a title like "rust:
bindings: sort includes". Also, please add a commit description --
please see Ariel's recent patch [1] and discussion for some more
details.
[1] https://lore.kernel.org/rust-for-linux/20230426204923.16195-1-amiculas@cisco.com/
Cheers,
Miguel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-26 22:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-26 21:45 [PATCH] rust: fix sorting of rust/bindings/bindings_helper.h's #includes Suggested by: Miguel Ojeda <ojeda@kernel.org> Link: https://github.com/Rust-for-Linux/linux/issues/1002 Roy Matero
2023-04-26 22:06 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox