public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
* `Option::filter` in nova-core/firmware.rs
@ 2026-04-27 15:09 Alice Ryhl
  2026-04-27 15:11 ` Danilo Krummrich
  0 siblings, 1 reply; 2+ messages in thread
From: Alice Ryhl @ 2026-04-27 15:09 UTC (permalink / raw)
  To: Danilo Krummrich, Alexandre Courbot; +Cc: nova-gpu, rust-for-linux

Hi Nova folks,

I'm seeing this clippy warning with latest nightly rust:

error: manual implementation of `Option::filter`
   --> drivers/gpu/nova-core/firmware.rs:391:14
    |
391 |               .and_then(|hdr| {
    |  ______________^
392 | |                 if hdr.bin_magic == BIN_MAGIC {
393 | |                     Some(hdr)
394 | |                 } else {
...   |
397 | |             })
    | |______________^ help: try: `filter(|hdr| hdr.bin_magic == BIN_MAGIC)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_filter
    = note: `-D clippy::manual-filter` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::manual_filter)]`

Alice

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-27 15:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-27 15:09 `Option::filter` in nova-core/firmware.rs Alice Ryhl
2026-04-27 15:11 ` Danilo Krummrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox