From: Bart Van Assche <bvanassche@acm.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Jan Kara <jack@suse.cz>,
linux-block <linux-block@vger.kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Brian Foster <bfoster@redhat.com>,
Damien Le Moal <dlemoal@kernel.org>,
Hillf Danton <hdanton@sina.com>,
Markus Elfring <Markus.Elfring@web.de>,
Ming Lei <tom.leiming@gmail.com>, Qu Wenruo <wqu@suse.com>,
Tao Cui <cui.tao@linux.dev>, kernel test robot <lkp@intel.com>,
rust-for-linux@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Nilay Shroff <nilay@linux.ibm.com>
Subject: Re: [PATCH v4 2/2] loop: Perform __loop_clr_fd() from run_todo callback.
Date: Mon, 21 Sep 2026 10:30:52 -0700 [thread overview]
Message-ID: <d4c22222-07ee-47ea-9877-1c30b7222c91@acm.org> (raw)
In-Reply-To: <1b6728b4-3232-4ba6-8114-a3d04d694c62@I-love.SAKURA.ne.jp>
On 9/19/26 3:51 AM, Tetsuo Handa wrote:
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 758c20678bf6..86ddcd9dadf0 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -75,6 +75,7 @@ struct loop_device {
> struct gendisk *lo_disk;
> struct mutex lo_mutex;
> bool idr_visible;
> + struct task_struct *rundown_owner; /* current or NULL */
The comment next to rundown_owner is not useful. Please improve it or
remove it. Once this issue has been addressed, feel free to add:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2026-09-21 17:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 10:50 [PATCH v4 1/2] block: Add run_todo() operation Tetsuo Handa
2026-09-19 10:51 ` [PATCH v4 2/2] loop: Perform __loop_clr_fd() from run_todo callback Tetsuo Handa
2026-09-21 17:30 ` Bart Van Assche [this message]
2026-09-21 17:27 ` [PATCH v4 1/2] block: Add run_todo() operation Bart Van Assche
2026-09-22 5:08 ` Tetsuo Handa
2026-09-22 18:09 ` Bart Van Assche
2026-09-23 5:26 ` Tetsuo Handa
2026-09-23 17:05 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4c22222-07ee-47ea-9877-1c30b7222c91@acm.org \
--to=bvanassche@acm.org \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bfoster@redhat.com \
--cc=cui.tao@linux.dev \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=hdanton@sina.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nilay@linux.ibm.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rust-for-linux@vger.kernel.org \
--cc=tom.leiming@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox