* Re: [PATCH 1/2] dt-bindings: PCI: qcom: Document the Hawi PCIe Controller
[not found] ` <20260508012135.76B34C2BCB2@smtp.kernel.org>
@ 2026-05-13 22:53 ` Rob Herring
0 siblings, 0 replies; only message in thread
From: Rob Herring @ 2026-05-13 22:53 UTC (permalink / raw)
To: sashiko; +Cc: Matthew Leung, linux-pci
On Fri, May 08, 2026 at 01:21:34AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The compatible string and filename violate the established Qualcomm PCIe naming pattern.
> --
>
> commit 332996956780b2d8736ee1fcd6b38c1627f71689
> Author: Matthew Leung <matthew.leung@oss.qualcomm.com>
>
> dt-bindings: PCI: qcom: Document the Hawi PCIe Controller
>
> Add a dedicated schema for the PCIe controllers found on the Hawi
> platform.
>
> > diff --git a/Documentation/devicetree/bindings/pci/qcom,hawi-pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,hawi-pcie.yaml
> > new file mode 100644
> > index 0000000000000..154bc88e59694
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pci/qcom,hawi-pcie.yaml
>
> This isn't a bug, but is there a reason this file isn't named
> qcom,pcie-hawi.yaml? The rest of the Qualcomm PCIe Root Complex bindings
> strictly follow the qcom,pcie-<soc> naming pattern, such as
> qcom,pcie-sc7280.yaml and qcom,pcie-sm8550.yaml.
Sashiko is wrong here.
>
> [ ... ]
>
> > +properties:
> > + compatible:
> > + const: qcom,hawi-pcie
>
> Should this compatible string also be changed to qcom,pcie-hawi to maintain
> consistency with the other Qualcomm Root Complex definitions across the
> subsystem?
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20260508-hawi-pcie-v1-0-0c910906f7e5@oss.qualcomm.com?part=1
^ permalink raw reply [flat|nested] only message in thread