* Re: [PATCH bpf-next v10 06/11] selftests/bpf: Tolerate test file compilation failures
[not found] ` <20260430131052.3E683C2BCB3@smtp.kernel.org>
@ 2026-04-30 13:13 ` Ricardo B. Marlière
0 siblings, 0 replies; only message in thread
From: Ricardo B. Marlière @ 2026-04-30 13:13 UTC (permalink / raw)
To: sashiko, Ricardo B. Marlière; +Cc: bpf
On Thu Apr 30, 2026 at 10:10 AM -03, sashiko-bot wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The inline condition `$(if $(V))` incorrectly suppresses the `BTFIDS` pretty output when `V=0` or `V=2`.
> --
>
> commit 0d69d461adbd02ed2bb765aad81f923aeaf2a8da
> Author: Ricardo B. Marlière <rbm@suse.com>
>
> selftests/bpf: Tolerate test file compilation failures
>
> This commit makes per-test compilation non-fatal for test_progs, skipping
> missing objects during linking. It adjusts the BTFIDS step to use standard
> printf instead of the msg macro within the shell conditionals.
>
>> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
>> index 608e6dff03926..9becc077eb231 100644
>> --- a/tools/testing/selftests/bpf/Makefile
>> +++ b/tools/testing/selftests/bpf/Makefile
>
> [ ... ]
>
>> @@ -717,11 +723,14 @@ $(TRUNNER_TEST_OBJS): $(TRUNNER_OUTPUT)/%.test.o: \
>> $(TRUNNER_TESTS_DIR)/%.c \
>> | $(TRUNNER_OUTPUT)/%.test.d
>> $$(call msg,TEST-OBJ,$(TRUNNER_BINARY),$$@)
>> - $(Q)cd $$(@D) && $$(CC) -I. $$(CFLAGS) -MMD -MT $$@ -c $(CURDIR)/$$< $$(LDLIBS) -o $$(@F)
>> + $(Q)(cd $$(@D) && $$(CC) -I. $$(CFLAGS) -MMD -MT $$@ -c $(CURDIR)/$$< $$(LDLIBS) -o $$(@F)) $(if $(filter test_progs%,$1),$(if $(PERMISSIVE),|| \
>> + ($(RM) $$@; printf ' %-12s %s\n' 'SKIP-TEST' '$$(notdir $$@)' 1>&2)))
>> $$(if $$(TEST_NEEDS_BTFIDS), \
>> - $$(call msg,BTFIDS,$(TRUNNER_BINARY),$$@) \
>> + $(Q)if [ -f $$@ ]; then \
>> + $(if $(V),true,printf ' %-8s%s %s\n' "BTFIDS" " [$(TRUNNER_BINARY)]" "$$(notdir $$@)"); \
>
> Does this condition correctly handle V=0 or V=2?
>
> In GNU Make, the $(if) function evaluates to true if the condition expands to
> any non-empty string. If a user sets make V=0, $(V) expands to the string "0",
> which Make considers true.
>
> Consequently, `$(if $(V),true,printf ...)` will execute `true;`, silencing the
> BTFIDS output entirely. The standard msg macro used for other compilation steps
> explicitly checks `ifeq ($(V),1)`.
>
> This results in inconsistent behavior where V=0 correctly prints brief messages
> like TEST-OBJ but silently skips BTFIDS.
>
> Could this explicitly check for "1", such as using
> `$(if $(filter 1,$(V)),true,printf ...)` to accurately match the behavior of
> the msg macro?
ugh I forgot about this one
>
>> $(RESOLVE_BTFIDS) --btf $(TRUNNER_OUTPUT)/btf_data.bpf.o $$@; \
>> - $(RESOLVE_BTFIDS) --patch_btfids $$@.BTF_ids $$@)
>> + $(RESOLVE_BTFIDS) --patch_btfids $$@.BTF_ids $$@; \
>> + fi)
^ permalink raw reply [flat|nested] only message in thread