From: Lukas Wunner <lukas@wunner.de>
To: sashiko@lists.linux.dev
Cc: alistair23@gmail.com, linux-pci@vger.kernel.org, ojeda@kernel.org
Subject: Re: [PATCH 04/18] X.509: Move certificate length retrieval into new helper
Date: Thu, 14 May 2026 08:59:18 +0200 [thread overview]
Message-ID: <agVyxrFLL8xI3sB1@wunner.de> (raw)
In-Reply-To: <20260508033917.B5873C2BCB0@smtp.kernel.org>
On Fri, May 08, 2026 at 03:39:17AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] The exported helper `x509_get_certificate_length()` uses a flawed logical condition (`&&` instead of `||`) that fails to properly validate ASN.1 headers, leading to parser differentials, incorrect length calculations, and functional failures.
Fixed by:
https://lore.kernel.org/r/782bc59d5939aa69b58cad42f71946f1c0a6dccb.1778741457.git.lukas@wunner.de/
parent reply other threads:[~2026-05-14 6:59 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20260508033917.B5873C2BCB0@smtp.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agVyxrFLL8xI3sB1@wunner.de \
--to=lukas@wunner.de \
--cc=alistair23@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox