* Re: [PATCH 04/18] X.509: Move certificate length retrieval into new helper
[not found] ` <20260508033917.B5873C2BCB0@smtp.kernel.org>
@ 2026-05-14 6:59 ` Lukas Wunner
0 siblings, 0 replies; only message in thread
From: Lukas Wunner @ 2026-05-14 6:59 UTC (permalink / raw)
To: sashiko; +Cc: alistair23, linux-pci, ojeda
On Fri, May 08, 2026 at 03:39:17AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] The exported helper `x509_get_certificate_length()` uses a flawed logical condition (`&&` instead of `||`) that fails to properly validate ASN.1 headers, leading to parser differentials, incorrect length calculations, and functional failures.
Fixed by:
https://lore.kernel.org/r/782bc59d5939aa69b58cad42f71946f1c0a6dccb.1778741457.git.lukas@wunner.de/
^ permalink raw reply [flat|nested] only message in thread