Sashiko discussions
 help / color / mirror / Atom feed
* Re: [PATCH v4 3/4] x86/vmware: Add the vmware_record_panic_msg sysctl
       [not found]     ` <av1IuMZ2W0SXWcNn@MiWiFi-R3L-srv>
@ 2026-11-18  7:02       ` Andrew Morton
  2026-11-18  7:51         ` Baoquan He
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2026-11-18  7:02 UTC (permalink / raw)
  To: Baoquan He
  Cc: sashiko-reviews, Zack Rusin, Petr Mladek, Mike Rapoport,
	Pasha Tatashin, Pratyush Yadav, Dave Young, Borislav Petkov,
	Ajay Kaher, Alexey Makhalov, x86, Joel Granados, Thomas Gleixner,
	Ingo Molnar, Dave Hansen, H. Peter Anvin, virtualization,
	bcm-kernel-feedback-list, John Ogness, Steven Rostedt,
	Sergey Senozhatsky, Kees Cook, Jonathan Corbet, Bo Gan,
	Brennan Lamoreaux, kexec, Guilherme G. Piccoli, Maaz Mombasawala,
	Shuah Khan, Randy Dunlap, Stephen Brennan, Michael Kelley,
	Ian Forbes, Bradley Morgan, Michael S. Tsirkin, Eugenio Perez,
	sashiko

On Wed, 18 Nov 2026 14:42:00 +0800 Baoquan He <baoquan.he@linux.dev> wrote:

> On 11/18/26 at 06:14am, sashiko-bot@kernel.org wrote:
> > > Allow administrators to disable host log transfer on ordinary guests or
> > > opt in on encrypted guests. Expose the boolean recording policy through
> > > kernel.vmware_record_panic_msg using proc_dobool(), as Joel suggested.
> > > Zero disables recording, nonzero integers enable it, and reads return
> > > 0 or 1.
> > > 
> > > Register the sysctl only after the logger is ready. A registration failure
> > > leaves the internal default in force. Document that the log is sent
> > > before kdump, and that disable_panic_notifiers_platform_list also skips
> > > it.
> > > 
> > > Link: https://lore.kernel.org/r/4e73yd2ofpdzl6rptzvd74no3hnyfblknoq7wzxlw7f3zjbz7c@srfabx6lsusj
> > > Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
> > 
> > Sashiko has reviewed this patch and found no issues.
> 
> It might be better to turn off this message if not issues found, just
> like what LKP bot has been doing.

(+sashiko@lists.linux.dev)

Yes please.

These emails do have a little bit of value: they tell you that Sashiko
was able to apply the patch and to review it.  I guess.  Or something.


Me:

:0 D:
* ^From:[ 	]*sashiko-bot@kernel\.org[ 	]*$
* B ?? ^Sashiko has reviewed this patch and found no issues\.$
/home/akpm/.nsmail-zip/Trash

hp2:/home/akpm> grep "From:.*sashiko-bot" .nsmail-zip/Trash | wc -l
1140
hp2:/home/akpm> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v4 3/4] x86/vmware: Add the vmware_record_panic_msg sysctl
  2026-11-18  7:02       ` [PATCH v4 3/4] x86/vmware: Add the vmware_record_panic_msg sysctl Andrew Morton
@ 2026-11-18  7:51         ` Baoquan He
  2026-11-18  7:53           ` Bradley Morgan
  0 siblings, 1 reply; 4+ messages in thread
From: Baoquan He @ 2026-11-18  7:51 UTC (permalink / raw)
  To: Andrew Morton
  Cc: sashiko-reviews, Zack Rusin, Petr Mladek, Mike Rapoport,
	Pasha Tatashin, Pratyush Yadav, Dave Young, Borislav Petkov,
	Ajay Kaher, Alexey Makhalov, x86, Joel Granados, Thomas Gleixner,
	Ingo Molnar, Dave Hansen, H. Peter Anvin, virtualization,
	bcm-kernel-feedback-list, John Ogness, Steven Rostedt,
	Sergey Senozhatsky, Kees Cook, Jonathan Corbet, Bo Gan,
	Brennan Lamoreaux, kexec, Guilherme G. Piccoli, Maaz Mombasawala,
	Shuah Khan, Randy Dunlap, Stephen Brennan, Michael Kelley,
	Ian Forbes, Bradley Morgan, Michael S. Tsirkin, Eugenio Perez,
	sashiko

On 11/17/26 at 11:02pm, Andrew Morton wrote:
> On Wed, 18 Nov 2026 14:42:00 +0800 Baoquan He <baoquan.he@linux.dev> wrote:
> 
> > On 11/18/26 at 06:14am, sashiko-bot@kernel.org wrote:
> > > > Allow administrators to disable host log transfer on ordinary guests or
> > > > opt in on encrypted guests. Expose the boolean recording policy through
> > > > kernel.vmware_record_panic_msg using proc_dobool(), as Joel suggested.
> > > > Zero disables recording, nonzero integers enable it, and reads return
> > > > 0 or 1.
> > > > 
> > > > Register the sysctl only after the logger is ready. A registration failure
> > > > leaves the internal default in force. Document that the log is sent
> > > > before kdump, and that disable_panic_notifiers_platform_list also skips
> > > > it.
> > > > 
> > > > Link: https://lore.kernel.org/r/4e73yd2ofpdzl6rptzvd74no3hnyfblknoq7wzxlw7f3zjbz7c@srfabx6lsusj
> > > > Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
> > > 
> > > Sashiko has reviewed this patch and found no issues.
> > 
> > It might be better to turn off this message if not issues found, just
> > like what LKP bot has been doing.
> 
> (+sashiko@lists.linux.dev)
> 
> Yes please.
> 
> These emails do have a little bit of value: they tell you that Sashiko
> was able to apply the patch and to review it.  I guess.  Or something.

In that case a message saying Sashiko can't apply the entire patchset
is better.

> 
> Me:
> 
> :0 D:
> * ^From:[ 	]*sashiko-bot@kernel\.org[ 	]*$
> * B ?? ^Sashiko has reviewed this patch and found no issues\.$
> /home/akpm/.nsmail-zip/Trash
> 
> hp2:/home/akpm> grep "From:.*sashiko-bot" .nsmail-zip/Trash | wc -l
> 1140
> hp2:/home/akpm> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v4 3/4] x86/vmware: Add the vmware_record_panic_msg sysctl
  2026-11-18  7:51         ` Baoquan He
@ 2026-11-18  7:53           ` Bradley Morgan
  2026-11-18  8:09             ` Baoquan He
  0 siblings, 1 reply; 4+ messages in thread
From: Bradley Morgan @ 2026-11-18  7:53 UTC (permalink / raw)
  To: Baoquan He, Andrew Morton
  Cc: sashiko-reviews, Zack Rusin, Petr Mladek, Mike Rapoport,
	Pasha Tatashin, Pratyush Yadav, Dave Young, Borislav Petkov,
	Ajay Kaher, Alexey Makhalov, x86, Joel Granados, Thomas Gleixner,
	Ingo Molnar, Dave Hansen, H. Peter Anvin, virtualization,
	bcm-kernel-feedback-list, John Ogness, Steven Rostedt,
	Sergey Senozhatsky, Kees Cook, Jonathan Corbet, Bo Gan,
	Brennan Lamoreaux, kexec, Guilherme G. Piccoli, Maaz Mombasawala,
	Shuah Khan, Randy Dunlap, Stephen Brennan, Michael Kelley,
	Ian Forbes, Michael S. Tsirkin, Eugenio Perez, sashiko

On 18 November 2026 07:51:35 GMT, Baoquan He <baoquan.he@linux.dev> wrote:
>On 11/17/26 at 11:02pm, Andrew Morton wrote:
>> On Wed, 18 Nov 2026 14:42:00 +0800 Baoquan He <baoquan.he@linux.dev>
>wrote:
>> 
>> > On 11/18/26 at 06:14am, sashiko-bot@kernel.org wrote:
>> > > > Allow administrators to disable host log transfer on ordinary
>guests or
>> > > > opt in on encrypted guests. Expose the boolean recording policy
>through
>> > > > kernel.vmware_record_panic_msg using proc_dobool(), as Joel
>suggested.
>> > > > Zero disables recording, nonzero integers enable it, and reads
>return
>> > > > 0 or 1.
>> > > > 
>> > > > Register the sysctl only after the logger is ready. A registration
>failure
>> > > > leaves the internal default in force. Document that the log is
>sent
>> > > > before kdump, and that disable_panic_notifiers_platform_list also
>skips
>> > > > it.
>> > > > 
>> > > > Link:
>https://lore.kernel.org/r/4e73yd2ofpdzl6rptzvd74no3hnyfblknoq7wzxlw7f3zjbz7c@srfabx6lsusj
>> > > > Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
>> > > 
>> > > Sashiko has reviewed this patch and found no issues.
>> > 
>> > It might be better to turn off this message if not issues found, just
>> > like what LKP bot has been doing.
>> 
>> (+sashiko@lists.linux.dev)
>> 
>> Yes please.
>> 
>> These emails do have a little bit of value: they tell you that Sashiko
>> was able to apply the patch and to review it.  I guess.  Or something.
>
>In that case a message saying Sashiko can't apply the entire patchset
>is better.

yes my sashiko emails go to spam automatically (not cuz I set it, but 
cuz I get so much "no issues!" Emails, that it clogs up my inbox. 

What even is the need to have the no issues emails? If one was THAT
interested in sashiko, they could search for it?

>
>> 
>> Me:
>> 
>> :0 D:
>> * ^From:[ 	]*sashiko-bot@kernel\.org[ 	]*$
>> * B ?? ^Sashiko has reviewed this patch and found no issues\.$
>> /home/akpm/.nsmail-zip/Trash
>> 
>> hp2:/home/akpm> grep "From:.*sashiko-bot" .nsmail-zip/Trash | wc -l
>> 1140
>> hp2:/home/akpm> 
>> 

--- Thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v4 3/4] x86/vmware: Add the vmware_record_panic_msg sysctl
  2026-11-18  7:53           ` Bradley Morgan
@ 2026-11-18  8:09             ` Baoquan He
  0 siblings, 0 replies; 4+ messages in thread
From: Baoquan He @ 2026-11-18  8:09 UTC (permalink / raw)
  To: Bradley Morgan
  Cc: Andrew Morton, sashiko-reviews, Zack Rusin, Petr Mladek,
	Mike Rapoport, Pasha Tatashin, Pratyush Yadav, Dave Young,
	Borislav Petkov, Ajay Kaher, Alexey Makhalov, x86, Joel Granados,
	Thomas Gleixner, Ingo Molnar, Dave Hansen, H. Peter Anvin,
	virtualization, bcm-kernel-feedback-list, John Ogness,
	Steven Rostedt, Sergey Senozhatsky, Kees Cook, Jonathan Corbet,
	Bo Gan, Brennan Lamoreaux, kexec, Guilherme G. Piccoli,
	Maaz Mombasawala, Shuah Khan, Randy Dunlap, Stephen Brennan,
	Michael Kelley, Ian Forbes, Michael S. Tsirkin, Eugenio Perez,
	sashiko

On 11/18/26 at 07:53am, Bradley Morgan wrote:
> On 18 November 2026 07:51:35 GMT, Baoquan He <baoquan.he@linux.dev> wrote:
> >On 11/17/26 at 11:02pm, Andrew Morton wrote:
> >> On Wed, 18 Nov 2026 14:42:00 +0800 Baoquan He <baoquan.he@linux.dev>
> >wrote:
> >> 
> >> > On 11/18/26 at 06:14am, sashiko-bot@kernel.org wrote:
> >> > > > Allow administrators to disable host log transfer on ordinary
> >guests or
> >> > > > opt in on encrypted guests. Expose the boolean recording policy
> >through
> >> > > > kernel.vmware_record_panic_msg using proc_dobool(), as Joel
> >suggested.
> >> > > > Zero disables recording, nonzero integers enable it, and reads
> >return
> >> > > > 0 or 1.
> >> > > > 
> >> > > > Register the sysctl only after the logger is ready. A registration
> >failure
> >> > > > leaves the internal default in force. Document that the log is
> >sent
> >> > > > before kdump, and that disable_panic_notifiers_platform_list also
> >skips
> >> > > > it.
> >> > > > 
> >> > > > Link:
> >https://lore.kernel.org/r/4e73yd2ofpdzl6rptzvd74no3hnyfblknoq7wzxlw7f3zjbz7c@srfabx6lsusj
> >> > > > Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
> >> > > 
> >> > > Sashiko has reviewed this patch and found no issues.
> >> > 
> >> > It might be better to turn off this message if not issues found, just
> >> > like what LKP bot has been doing.
> >> 
> >> (+sashiko@lists.linux.dev)
> >> 
> >> Yes please.
> >> 
> >> These emails do have a little bit of value: they tell you that Sashiko
> >> was able to apply the patch and to review it.  I guess.  Or something.
> >
> >In that case a message saying Sashiko can't apply the entire patchset
> >is better.
> 
> yes my sashiko emails go to spam automatically (not cuz I set it, but 
> cuz I get so much "no issues!" Emails, that it clogs up my inbox. 
> 
> What even is the need to have the no issues emails? If one was THAT
> interested in sashiko, they could search for it?

Yeah, searching for it is one good way. Not sure if it's convenient for
people like Andrew and Mike who need pick patch. They may need check
patchset one by one if Sashiko can't apply patch while keep silent. And
some patch authors could be new, they could mistake sashiko being silent
as no issue. I did that before until Andrew told me in a private message.

If there's a document telling people where and how to search, that's
also good.

> 
> >
> >> 
> >> Me:
> >> 
> >> :0 D:
> >> * ^From:[ 	]*sashiko-bot@kernel\.org[ 	]*$
> >> * B ?? ^Sashiko has reviewed this patch and found no issues\.$
> >> /home/akpm/.nsmail-zip/Trash
> >> 
> >> hp2:/home/akpm> grep "From:.*sashiko-bot" .nsmail-zip/Trash | wc -l
> >> 1140
> >> hp2:/home/akpm> 
> >> 
> 
> --- Thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-18  8:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <cover.1794980455.git.zack.rusin@broadcom.com>
     [not found] ` <4c5de34b10f579368b890eaa9333a2755886bad3.1794980455.git.zack.rusin@broadcom.com>
     [not found]   ` <sashiko-outbox-220212@kernel.org>
     [not found]     ` <av1IuMZ2W0SXWcNn@MiWiFi-R3L-srv>
2026-11-18  7:02       ` [PATCH v4 3/4] x86/vmware: Add the vmware_record_panic_msg sysctl Andrew Morton
2026-11-18  7:51         ` Baoquan He
2026-11-18  7:53           ` Bradley Morgan
2026-11-18  8:09             ` Baoquan He

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox