From: Krzysztof Kozlowski <krzk@kernel.org>
To: sashiko@lists.linux.dev, Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
Cc: devicetree@vger.kernel.org, krzk+dt@kernel.org, robh@kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: agilex5: add support for debug daughter card
Date: Wed, 13 May 2026 20:09:55 +0200 [thread overview]
Message-ID: <bcdfd465-b830-4ca1-9e4a-4776ae11fd28@kernel.org> (raw)
In-Reply-To: <20260508204237.ADF26C2BCB0@smtp.kernel.org>
On 08/05/2026 22:42, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Low] Abuse of the 'rohm,dh2228fv' compatible string to force the 'spidev' driver to bind.
> - [Low] Including a '.dts' file directly instead of using a '.dtsi' include file.
> --
>
> commit 3916af69e58bdb9bf4d736172238dd0b03e9465b
> Author: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
>
> arm64: dts: agilex5: add support for debug daughter card
>
> This commit adds a new device tree for the Agilex 5 SoCDK when fitted with
> the debug daughter card. It disables several peripherals such as gpio0 and
> gmac2 while enabling gmac0 and spi0 for debugging purposes.
>
>> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts
>> new file mode 100644
>> index 0000000000000..3981a9e876b0a
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts
>> @@ -0,0 +1,50 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (C) 2026, Altera Corporation
>> + */
>> +#include "socfpga_agilex5_socdk.dts"
>
> This isn't a bug, but does this include a final board .dts file instead of a
> shared .dtsi include?
>
> Standard Device Tree conventions typically involve refactoring shared
> configurations into a common .dtsi file, as .dts files are meant to be the
> final top-level compilation unit for a board.
>
> [ ... ]
>
>> +&spi0 {
>> + status = "okay";
>> + spidev@0 {
>> + compatible = "rohm,dh2228fv";
>
> Is there actually a Rohm DH2228FV hardware device present on this debug
> daughter card?
>
> The commit message indicates this exposes the SPI interface for debugging.
> Does this code use the 'rohm,dh2228fv' compatible string solely to force the
> Linux spidev driver to bind?
Why did you completely ignore the review?
Best regards,
Krzysztof
parent reply other threads:[~2026-05-13 18:09 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20260508204237.ADF26C2BCB0@smtp.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcdfd465-b830-4ca1-9e4a-4776ae11fd28@kernel.org \
--to=krzk@kernel.org \
--cc=adrian.ho.yin.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox