* Re: [PATCH 2/2] arm64: dts: agilex5: add support for debug daughter card
[not found] ` <20260508204237.ADF26C2BCB0@smtp.kernel.org>
@ 2026-05-13 18:09 ` Krzysztof Kozlowski
0 siblings, 0 replies; only message in thread
From: Krzysztof Kozlowski @ 2026-05-13 18:09 UTC (permalink / raw)
To: sashiko, Adrian Ng Ho Yin; +Cc: devicetree, krzk+dt, robh, conor+dt
On 08/05/2026 22:42, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Low] Abuse of the 'rohm,dh2228fv' compatible string to force the 'spidev' driver to bind.
> - [Low] Including a '.dts' file directly instead of using a '.dtsi' include file.
> --
>
> commit 3916af69e58bdb9bf4d736172238dd0b03e9465b
> Author: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
>
> arm64: dts: agilex5: add support for debug daughter card
>
> This commit adds a new device tree for the Agilex 5 SoCDK when fitted with
> the debug daughter card. It disables several peripherals such as gpio0 and
> gmac2 while enabling gmac0 and spi0 for debugging purposes.
>
>> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts
>> new file mode 100644
>> index 0000000000000..3981a9e876b0a
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts
>> @@ -0,0 +1,50 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (C) 2026, Altera Corporation
>> + */
>> +#include "socfpga_agilex5_socdk.dts"
>
> This isn't a bug, but does this include a final board .dts file instead of a
> shared .dtsi include?
>
> Standard Device Tree conventions typically involve refactoring shared
> configurations into a common .dtsi file, as .dts files are meant to be the
> final top-level compilation unit for a board.
>
> [ ... ]
>
>> +&spi0 {
>> + status = "okay";
>> + spidev@0 {
>> + compatible = "rohm,dh2228fv";
>
> Is there actually a Rohm DH2228FV hardware device present on this debug
> daughter card?
>
> The commit message indicates this exposes the SPI interface for debugging.
> Does this code use the 'rohm,dh2228fv' compatible string solely to force the
> Linux spidev driver to bind?
Why did you completely ignore the review?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] only message in thread