Sashiko discussions
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@linux.ibm.com>
To: debarbos@redhat.com
Cc: sashiko@lists.linux.dev, Paolo Bonzini <pbonzini@redhat.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>
Subject: Re: cover letter not considered Fwd: [GIT PULL 0/7] KVM: s390: Fixes for 7.2
Date: Mon, 3 Aug 2026 09:34:37 +0200	[thread overview]
Message-ID: <ed23ce9e-2cdd-472a-85e4-c0cdf81359b9@linux.ibm.com> (raw)
In-Reply-To: <amy0kq7Dh2TzsWlj@debarbos-thinkpadt14gen5.rmtusma.csb>

Am 31.07.26 um 17:02 schrieb Derek Barbosa:
> Hi Christian, sorry for the delay
> 
> On Thu, Jul 30, 2026 at 06:42:10PM +0200, Christian Borntraeger wrote:
>> Folks,
>>
>> I am a bit puzzled. Looking at https://sashiko.dev/#/?list=org.kernel.vger.linux-s390
>> I do see  1,2,3,4,5,6,7 but not 0 for the PULL request above
>>   Clicking on on of those mails then also has the 0 mail so its there
>> https://sashiko.dev/#/patchset/20260727095720.9150-2-borntraeger%40linux.ibm.com
>>
>> but during review this seems to have been lost. This is unfortunate as the cover letter might
>> help to find the right tree and with 3 failed applies several already fixed
>> things (in those 3 patches) are reported instead.
> 
> IIUC in the current code, cover letters are not considered patches in
> the DB and therfore do not get forwarded to the reviewer processes.
> 
> I have been working on improving the concept of a "patch series summary" that
> propagates a small snippet of "context" to all reviewer threads. Currently, the
> individual worker threads only get a range from base..HEAD and use git log
> --format=%s to get insight into other patches in a series.
> 
> So the cover letter never really makes it's way into the "working context" of a
> single worker in isolation.
> 
> Is your concern not being able to quickly view the '0'-indexed mail? or that it
> may help with review accuracy if it were to make it's way into the review
> process?
My concern is more that we get reports about issues that are fixed in a subsequent patch.
But maybe this is just due to random email delay that sashiko receives some mails later?
Maybe we could delay review for 5 minutes or so if this seems to be part of a series.
But I think we already detect that?

  reply	other threads:[~2026-08-03  7:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260727095720.9150-1-borntraeger@linux.ibm.com>
2026-07-30 16:42 ` cover letter not considered Fwd: [GIT PULL 0/7] KVM: s390: Fixes for 7.2 Christian Borntraeger
2026-07-31 15:02   ` Derek Barbosa
2026-08-03  7:34     ` Christian Borntraeger [this message]
2026-08-04 20:01       ` Derek Barbosa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed23ce9e-2cdd-472a-85e4-c0cdf81359b9@linux.ibm.com \
    --to=borntraeger@linux.ibm.com \
    --cc=debarbos@redhat.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=sashiko@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox