* [PATCH sched_ext/for-7.3] sched_ext: Parenthesize local SCX_EVENT defines to fix checkpatch error
@ 2026-06-30 17:05 Cheng-Yang Chou
2026-06-30 17:46 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Cheng-Yang Chou @ 2026-06-30 17:05 UTC (permalink / raw)
To: sched-ext, Tejun Heo, David Vernet, Andrea Righi, Changwoo Min
Cc: Ching-Chun Huang, Chia-Ping Tsai, chengyang.chou, Cheng-Yang Chou
Fix checkpatch "Macros with complex values should be enclosed in
parentheses" error.
Suggested-by: Andrea Righi <arighi@nvidia.com>
Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
---
kernel/sched/ext/ext.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/ext/ext.c b/kernel/sched/ext/ext.c
index 0c51f9826a77..a9d23d9f5947 100644
--- a/kernel/sched/ext/ext.c
+++ b/kernel/sched/ext/ext.c
@@ -4979,7 +4979,7 @@ static ssize_t scx_attr_events_show(struct kobject *kobj,
int at = 0;
scx_read_events(sch, &events);
-#define SCX_EVENT(name) at += scx_attr_event_show(buf, at, &events, name)
+#define SCX_EVENT(name) (at += scx_attr_event_show(buf, at, &events, name))
SCX_EVENTS_LIST(SCX_EVENT);
#undef SCX_EVENT
return at;
@@ -10309,7 +10309,7 @@ static void scx_read_events(struct scx_sched *sch, struct scx_event_stats *event
memset(events, 0, sizeof(*events));
for_each_possible_cpu(cpu) {
struct scx_event_stats *e_cpu = &per_cpu_ptr(sch->pcpu, cpu)->event_stats;
-#define SCX_EVENT(name) events->name += READ_ONCE(e_cpu->name)
+#define SCX_EVENT(name) (events->name += READ_ONCE(e_cpu->name))
SCX_EVENTS_LIST(SCX_EVENT);
#undef SCX_EVENT
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH sched_ext/for-7.3] sched_ext: Parenthesize local SCX_EVENT defines to fix checkpatch error
2026-06-30 17:05 [PATCH sched_ext/for-7.3] sched_ext: Parenthesize local SCX_EVENT defines to fix checkpatch error Cheng-Yang Chou
@ 2026-06-30 17:46 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2026-06-30 17:46 UTC (permalink / raw)
To: Cheng-Yang Chou
Cc: sched-ext, David Vernet, Andrea Righi, Changwoo Min,
Ching-Chun Huang, Chia-Ping Tsai, chengyang.chou
Hello,
On Wed, Jul 01, 2026 at 01:05:35AM +0800, Cheng-Yang Chou wrote:
> Fix checkpatch "Macros with complex values should be enclosed in
> parentheses" error.
Applied to sched_ext/for-7.3.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-30 17:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-30 17:05 [PATCH sched_ext/for-7.3] sched_ext: Parenthesize local SCX_EVENT defines to fix checkpatch error Cheng-Yang Chou
2026-06-30 17:46 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox