From: bauen1 <j2468h@googlemail.com>
To: James Carter <jwcart2@gmail.com>, bauen1 <j2468h@googlemail.com>
Cc: SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] secilc/docs: add syntax highlighting for secil
Date: Mon, 8 Feb 2021 20:35:45 +0100 [thread overview]
Message-ID: <79fcad29-da9c-7084-c081-b5d4b529f04f@gmail.com> (raw)
In-Reply-To: <CAP+JOzQBiEHBS7TFAGpyJJ0+G3u2aGKpkDRTxH_PgU7pQrogVA@mail.gmail.com>
On 2/8/21 6:43 PM, James Carter wrote:
> On Sat, Feb 6, 2021 at 4:05 PM bauen1 <j2468h@googlemail.com> wrote:
>>
>> + <list name="function">
>> + <item>blockinherit</item>
>> + <item>call</item>
>> + <item>in</item>
>> + <item>macro</item>
>> + </list>
>> +
>
> I am not sure it adds a lot to have these as separate colors.
I would at least like to have `macro`, `call` and `blockinherit` as separate colors, as these behave very differently from "normal" keywords / statements and more like function calls from a programming language.
They are usually also quite important when looking over policy so I think it's warranted.
I'm less sure about the arrangement of `in`, but due to its special interaction I've also included it.
> Also, when call is used as a permission, it is highlighted. It would
> be nice if that could be fixed.
I don't think this could be fixed easily, the same is also true if e.g. `allow` (a keyword) is used as permission, e.g.
(allow t1 (file (call)))
(allow t1 (file (allow)))
This is harder to fix as currently the syntax has no concept of what a "permission" is and I don't want to make things too complicated.
--
bauen1
https://dn42.bauen1.xyz/
next prev parent reply other threads:[~2021-02-08 19:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 17:05 [PATCH 0/2] secilc/docs: add syntax highlighting for cil examples bauen1
2021-02-04 20:17 ` James Carter
2021-02-04 21:28 ` bauen1
2021-02-04 23:19 ` James Carter
2021-02-05 9:31 ` Nicolas Iooss
2021-02-06 20:29 ` bauen1
2021-02-06 21:04 ` [PATCH v2 1/3] secilc/docs: use fenced code blocks " bauen1
2021-02-08 17:40 ` James Carter
2021-02-08 19:38 ` bauen1
2021-02-11 23:35 ` James Carter
2021-02-06 21:04 ` [PATCH v2 2/3] secilc/docs: add syntax highlighting for secil bauen1
2021-02-08 17:43 ` James Carter
2021-02-08 19:35 ` bauen1 [this message]
2021-02-08 19:45 ` James Carter
2021-02-08 19:46 ` James Carter
2021-02-11 23:35 ` James Carter
2021-02-16 14:41 ` James Carter
2021-02-06 21:05 ` [PATCH v2 3/3] secilc/docs: add custom color theme bauen1
2021-02-08 17:44 ` James Carter
2021-02-10 15:58 ` [PATCH v3 1/3] secilc/docs: use fenced code blocks for cil examples bauen1
2021-02-11 23:38 ` James Carter
2021-02-16 14:40 ` James Carter
2021-02-10 15:59 ` [PATCH v3 2/3] secilc/docs: add syntax highlighting for secil bauen1
2021-02-10 15:59 ` [PATCH v3 3/3] secilc/docs: add custom color theme bauen1
2021-02-11 23:37 ` James Carter
2021-02-16 14:41 ` James Carter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79fcad29-da9c-7084-c081-b5d4b529f04f@gmail.com \
--to=j2468h@googlemail.com \
--cc=jwcart2@gmail.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox