Re: [PATCH 0/2] secilc/docs: add syntax highlighting for cil examples

[bauen1 <j2468h@googlemail.com>]

On 2/5/21 12:19 AM, James Carter wrote:
> On Thu, Feb 4, 2021 at 4:28 PM bauen1 <j2468h@googlemail.com> wrote:
>
>>
>> https://glados.bauen1.xyz/misc_stuff_might_disappear/CIL_Reference_Guide3.html
>>
> 
> I like version 3 the best, but I really don't like the color used for
> "self", "object_r", "h1" , etc. It just stands out too much.

This was originally meant to be a test color scheme to showcase all different "classes" of keywords that could be highlighted, not intended as an actual color theme.

I've changed the purple to a lighter pink:

https://glados.bauen1.xyz/misc_stuff_might_disappear/CIL_Reference_Guide4.html

In case someone can come up with 6 different colors that go well together, I can put together an updated theme (Colors for Strings+SpecialChars, Function, Operator, BuiltIns, Comment, Keyword).

I will send a v2 of the patch, including the color theme as a separate patch.

> ...
> I find it easier to maintain if the items were sorted in alphabetical
> order (this enables inserting new items if the need comes one day,
> without wondering whether the new items should be at the end of the
> list or if the order should match the one used in some source
> files...). Or, if you want to keep this order, please add comments
> describing how the lists were created, in order to ease future
> modifications.

Thanks for the feedback, will be implemented.

-- 
bauen1
https://dn42.bauen1.xyz/