[PATCH] selinux: use isdigit() in selinux_genfs_get_sid()

[PATCH] selinux: use isdigit() in selinux_genfs_get_sid()

[Thorsten Blum]

Use isdigit() to replace the open-coded implementation.

Signed-off-by: Thorsten Blum <blum@kernel.org>
---
 security/selinux/hooks.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 30776b0107f2..d1304afa42fd 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -31,6 +31,7 @@
 #include <linux/lsm_hooks.h>
 #include <linux/xattr.h>
 #include <linux/capability.h>
+#include <linux/ctype.h>
 #include <linux/unistd.h>
 #include <linux/mm.h>
 #include <linux/mman.h>
@@ -1357,7 +1358,7 @@ static int selinux_genfs_get_sid(struct dentry *dentry,
 			/* each process gets a /proc/PID/ entry. Strip off the
 			 * PID part to get a valid selinux labeling.
 			 * e.g. /proc/1/net/rpc/nfs -> /net/rpc/nfs */
-			while (path[1] >= '0' && path[1] <= '9') {
+			while (isdigit(path[1])) {
 				path[1] = '/';
 				path++;
 			}

Re: [PATCH] selinux: use isdigit() in selinux_genfs_get_sid()

[sashiko-bot]

> Use isdigit() to replace the open-coded implementation.
> 
> Signed-off-by: Thorsten Blum <blum@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014160741.222219-3-blum@kernel.org?part=1

Re: [PATCH] selinux: use isdigit() in selinux_genfs_get_sid()

[Stephen Smalley]

On Wed, Oct 14, 2026 at 12:10 PM Thorsten Blum <blum@kernel.org> wrote:
>
> Use isdigit() to replace the open-coded implementation.
>
> Signed-off-by: Thorsten Blum <blum@kernel.org>

I seem to recall seeing this same patch possibly from someone else but
regardless:
Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>

Re: [PATCH] selinux: use isdigit() in selinux_genfs_get_sid()

[Paul Moore]

On Thu, Oct 15, 2026 at 10:01 AM Stephen Smalley
<stephen.smalley.work@gmail.com> wrote:
> On Wed, Oct 14, 2026 at 12:10 PM Thorsten Blum <blum@kernel.org> wrote:
> >
> > Use isdigit() to replace the open-coded implementation.
> >
> > Signed-off-by: Thorsten Blum <blum@kernel.org>
>
> I seem to recall seeing this same patch possibly from someone else but
> regardless:
> Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>

https://lore.kernel.org/selinux/20260928174643.2458710-9-cgoettsche@seltendoof.de/

-- 
paul-moore.com