Smatch (Semantic Matching Tool) development
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Norbert Manthey <nmanthey@amazon.de>
Cc: Norbert Manthey <norbertmanthey@googlemail.com>,
	smatch@vger.kernel.org, jsteckli@amazon.com,
	tautschn@amazon.co.uk
Subject: Re: Smatch for Xen
Date: Mon, 13 Aug 2018 20:58:45 +0300	[thread overview]
Message-ID: <20180813175845.muweaoh6s5rxcr57@mwanda> (raw)
In-Reply-To: <cbd1c9fc-1d04-7713-7d92-6cc37015f7ed@amazon.de>

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

On Mon, Aug 13, 2018 at 04:25:46PM +0200, Norbert Manthey wrote:
> Dear Dan,
> 
> I just split the output in one-line-scan, and also use your cgcc wrapper
> by now. Furthermore, I log all calls to cgcc so that replaying single
> calls is easy now. The relevant info is logged in the file
> 
> SMATCH/smatch/smatch-preprocess.log
> 
> However, I do not see a reason not to use the --file-output flag, in
> case you are more used to that. That should simply result in my output
> files being empty, but that's fine. This way, your tooling should work,
> i.e. collecting all the .smatch files should behave as in case of
> working with the kernel.
> 
> If there is anything else I can help with, please let me know. I would
> love to use your taint analysis for Xen as well.
>

Sorry for all this headache.

Yeah.  You don't need --fileoutput if you're using one-line-scan.  But
one-line-scan mixes stdout and stderr which doesn't work for Smatch.  We
only want stdout.

I've just pushed some changes which should help a bit.  And I'm
attaching some scripts to run Smatch on xen.  You're going to want to
change the SCRIPT_DIR in build_xen_data.sh and it assumes that
one-line-scan is in the ../one-line-scan/.  Also you need to save the
script in path/to/xen/../  Sorry, it's not very beautiful.

regards,
dan carpenter


[-- Attachment #2: build_xen_data.sh --]
[-- Type: application/x-sh, Size: 1845 bytes --]

[-- Attachment #3: check.sh --]
[-- Type: application/x-sh, Size: 374 bytes --]

  reply	other threads:[~2018-08-13 20:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30 12:40 Smatch for Xen Norbert Manthey
2018-07-30 16:34 ` [PATCH 0/3] add support for mode __pointer__ & __byte__ Luc Van Oostenryck
2018-07-30 16:34   ` [PATCH 1/3] mode keywords don't need MOD_{CHAR,LONG,...} Luc Van Oostenryck
2018-07-30 16:34   ` [PATCH 2/3] add support for mode __pointer__ Luc Van Oostenryck
2018-07-30 16:34   ` [PATCH 3/3] add support for mode __byte__ Luc Van Oostenryck
2018-08-06 10:31 ` Smatch for Xen Dan Carpenter
2018-08-06 11:20   ` Dan Carpenter
2018-08-06 13:16     ` Dan Carpenter
     [not found]       ` <CAByO1we3OABkX8XCwh7Vq8iHyXAuFtJ3t+Ta3DVCLe9pP6K8ew@mail.gmail.com>
2018-08-06 13:54         ` Dan Carpenter
2018-08-13 14:25           ` Norbert Manthey
2018-08-13 17:58             ` Dan Carpenter [this message]
2018-08-13 18:31               ` Dan Carpenter
2018-08-14 13:27                 ` Norbert Manthey
2018-08-14 14:21                   ` Dan Carpenter
2018-08-14 14:33                     ` Norbert Manthey
2018-08-14 14:52                       ` Dan Carpenter
2018-08-14 15:05                         ` Norbert Manthey
2018-08-15  9:03                       ` Dan Carpenter
2018-08-15 13:44                         ` Norbert Manthey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180813175845.muweaoh6s5rxcr57@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=jsteckli@amazon.com \
    --cc=nmanthey@amazon.de \
    --cc=norbertmanthey@googlemail.com \
    --cc=smatch@vger.kernel.org \
    --cc=tautschn@amazon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox