From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: smatch@vger.kernel.org, Norbert Manthey <nmanthey@amazon.de>,
Dan Carpenter <dan.carpenter@oracle.com>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 1/3] mode keywords don't need MOD_{CHAR,LONG,...}
Date: Mon, 30 Jul 2018 18:34:38 +0200 [thread overview]
Message-ID: <20180730163440.2303-2-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20180730163440.2303-1-luc.vanoostenryck@gmail.com>
The keywords for modes (SI, DI, ...) don't need a length modifier
like MOD_CHAR or MOD_LONG as the corresponding type (and thus its
length) is given by the the '.to_mode' method.
Remove these modifiers from the keyword definitions, their presence
while unneeded is confusing.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
parse.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/parse.c b/parse.c
index 270ab7bfd..0cafb4e6c 100644
--- a/parse.c
+++ b/parse.c
@@ -538,18 +538,18 @@ static struct init_keyword {
{"__const__", NS_KEYWORD, MOD_PURE, .op = &attr_mod_op },
{ "__mode__", NS_KEYWORD, .op = &mode_op },
- { "QI", NS_KEYWORD, MOD_CHAR, .op = &mode_QI_op },
- { "__QI__", NS_KEYWORD, MOD_CHAR, .op = &mode_QI_op },
- { "HI", NS_KEYWORD, MOD_SHORT, .op = &mode_HI_op },
- { "__HI__", NS_KEYWORD, MOD_SHORT, .op = &mode_HI_op },
- { "SI", NS_KEYWORD, .op = &mode_SI_op },
- { "__SI__", NS_KEYWORD, .op = &mode_SI_op },
- { "DI", NS_KEYWORD, MOD_LONGLONG, .op = &mode_DI_op },
- { "__DI__", NS_KEYWORD, MOD_LONGLONG, .op = &mode_DI_op },
- { "TI", NS_KEYWORD, MOD_LONGLONGLONG, .op = &mode_TI_op },
- { "__TI__", NS_KEYWORD, MOD_LONGLONGLONG, .op = &mode_TI_op },
- { "word", NS_KEYWORD, MOD_LONG, .op = &mode_word_op },
- { "__word__", NS_KEYWORD, MOD_LONG, .op = &mode_word_op },
+ { "QI", NS_KEYWORD, .op = &mode_QI_op },
+ { "__QI__", NS_KEYWORD, .op = &mode_QI_op },
+ { "HI", NS_KEYWORD, .op = &mode_HI_op },
+ { "__HI__", NS_KEYWORD, .op = &mode_HI_op },
+ { "SI", NS_KEYWORD, .op = &mode_SI_op },
+ { "__SI__", NS_KEYWORD, .op = &mode_SI_op },
+ { "DI", NS_KEYWORD, .op = &mode_DI_op },
+ { "__DI__", NS_KEYWORD, .op = &mode_DI_op },
+ { "TI", NS_KEYWORD, .op = &mode_TI_op },
+ { "__TI__", NS_KEYWORD, .op = &mode_TI_op },
+ { "word", NS_KEYWORD, .op = &mode_word_op },
+ { "__word__", NS_KEYWORD, .op = &mode_word_op },
};
--
2.18.0
next prev parent reply other threads:[~2018-07-30 18:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 12:40 Smatch for Xen Norbert Manthey
2018-07-30 16:34 ` [PATCH 0/3] add support for mode __pointer__ & __byte__ Luc Van Oostenryck
2018-07-30 16:34 ` Luc Van Oostenryck [this message]
2018-07-30 16:34 ` [PATCH 2/3] add support for mode __pointer__ Luc Van Oostenryck
2018-07-30 16:34 ` [PATCH 3/3] add support for mode __byte__ Luc Van Oostenryck
2018-08-06 10:31 ` Smatch for Xen Dan Carpenter
2018-08-06 11:20 ` Dan Carpenter
2018-08-06 13:16 ` Dan Carpenter
[not found] ` <CAByO1we3OABkX8XCwh7Vq8iHyXAuFtJ3t+Ta3DVCLe9pP6K8ew@mail.gmail.com>
2018-08-06 13:54 ` Dan Carpenter
2018-08-13 14:25 ` Norbert Manthey
2018-08-13 17:58 ` Dan Carpenter
2018-08-13 18:31 ` Dan Carpenter
2018-08-14 13:27 ` Norbert Manthey
2018-08-14 14:21 ` Dan Carpenter
2018-08-14 14:33 ` Norbert Manthey
2018-08-14 14:52 ` Dan Carpenter
2018-08-14 15:05 ` Norbert Manthey
2018-08-15 9:03 ` Dan Carpenter
2018-08-15 13:44 ` Norbert Manthey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730163440.2303-2-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-sparse@vger.kernel.org \
--cc=nmanthey@amazon.de \
--cc=smatch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox