[PATCH] arch: add missing predefines: __amd64 & __amd64__

[PATCH] arch: add missing predefines: __amd64 & __amd64__

[john.levon]

From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

These seem to be defined whenever the __x86_64 and
__x86_64__ macros are defined.

So, do the same here too.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
 lib.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib.c b/lib.c
index ee62eac1..9e72e8c4 100644
--- a/lib.c
+++ b/lib.c
@@ -1390,6 +1390,8 @@ static void predefined_macros(void)
 		if (arch_m64 != ARCH_LP32) {
 			predefine("__x86_64__", 1, "1");
 			predefine("__x86_64", 1, "1");
+			predefine("__amd64__", 1, "1");
+			predefine("__amd64", 1, "1");
 			break;
 		}
 		/* fall-through */
-- 
2.23.0

Re: [PATCH] arch: add missing predefines: __amd64 & __amd64__

[Dan Carpenter]

On Mon, Jan 20, 2020 at 01:51:52AM -0800, john.levon@joyent.com wrote:
> From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> 
> These seem to be defined whenever the __x86_64 and
> __x86_64__ macros are defined.
> 
> So, do the same here too.
> 
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---

I already applied this but looking at it now, could you add your
Signed-off-by so that I can see this came from you?  Right now it
looks like I cherry picking it from upstream Sparse.

regards,
dan carpenter

Re: [PATCH] arch: add missing predefines: __amd64 & __amd64__

[John Levon]

On Wed, Jan 22, 2020 at 06:44:57PM +0300, Dan Carpenter wrote:

> On Mon, Jan 20, 2020 at 01:51:52AM -0800, john.levon@joyent.com wrote:
> > From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> > 
> > These seem to be defined whenever the __x86_64 and
> > __x86_64__ macros are defined.
> > 
> > So, do the same here too.
> > 
> > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> > ---
> 
> I already applied this but looking at it now, could you add your
> Signed-off-by so that I can see this came from you?  Right now it
> looks like I cherry picking it from upstream Sparse.

Signed-off-by: John Levon <john.levon@joyent.com>

OK?

thanks
john

Re: [PATCH] arch: add missing predefines: __amd64 & __amd64__

[Dan Carpenter]

On Wed, Jan 22, 2020 at 03:55:06PM +0000, John Levon wrote:
> On Wed, Jan 22, 2020 at 06:44:57PM +0300, Dan Carpenter wrote:
> 
> > On Mon, Jan 20, 2020 at 01:51:52AM -0800, john.levon@joyent.com wrote:
> > > From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> > > 
> > > These seem to be defined whenever the __x86_64 and
> > > __x86_64__ macros are defined.
> > > 
> > > So, do the same here too.
> > > 
> > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> > > ---
> > 
> > I already applied this but looking at it now, could you add your
> > Signed-off-by so that I can see this came from you?  Right now it
> > looks like I cherry picking it from upstream Sparse.
> 
> Signed-off-by: John Levon <john.levon@joyent.com>
> 
> OK?

I had already applied it so no worries.  I meant next time.

regards,
dan carpenter