* [PATCH] soc: ixp4xx/qmgr: Fix unused match warning
@ 2022-05-23 8:55 Linus Walleij
2022-05-27 14:20 ` patchwork-bot+linux-soc
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2022-05-23 8:55 UTC (permalink / raw)
To: arm, soc; +Cc: linux-arm-kernel, Linus Walleij, kernel test robot
The kernel test robot found this inconsistency:
>> drivers/soc/ixp4xx/ixp4xx-npe.c:737:34: warning:
'ixp4xx_npe_of_match' defined but not used [-Wunused-const-variable=]
737 | static const struct of_device_id ixp4xx_npe_of_match[] = {
This is because the match is enclosed in the of_match_ptr()
which compiles into NULL when OF is disabled and this
is unnecessary.
Fix it by dropping of_match_ptr() around the match.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
SoC maintainers: please apply this directly for fixes for v5.19.
---
drivers/soc/ixp4xx/ixp4xx-qmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/ixp4xx/ixp4xx-qmgr.c b/drivers/soc/ixp4xx/ixp4xx-qmgr.c
index 9154c7029b05..291086bb9313 100644
--- a/drivers/soc/ixp4xx/ixp4xx-qmgr.c
+++ b/drivers/soc/ixp4xx/ixp4xx-qmgr.c
@@ -459,7 +459,7 @@ static const struct of_device_id ixp4xx_qmgr_of_match[] = {
static struct platform_driver ixp4xx_qmgr_driver = {
.driver = {
.name = "ixp4xx-qmgr",
- .of_match_table = of_match_ptr(ixp4xx_qmgr_of_match),
+ .of_match_table = ixp4xx_qmgr_of_match,
},
.probe = ixp4xx_qmgr_probe,
.remove = ixp4xx_qmgr_remove,
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soc: ixp4xx/qmgr: Fix unused match warning
2022-05-23 8:55 [PATCH] soc: ixp4xx/qmgr: Fix unused match warning Linus Walleij
@ 2022-05-27 14:20 ` patchwork-bot+linux-soc
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+linux-soc @ 2022-05-27 14:20 UTC (permalink / raw)
To: Linus Walleij; +Cc: soc
Hello:
This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:
On Mon, 23 May 2022 10:55:20 +0200 you wrote:
> The kernel test robot found this inconsistency:
>
> >> drivers/soc/ixp4xx/ixp4xx-npe.c:737:34: warning:
> 'ixp4xx_npe_of_match' defined but not used [-Wunused-const-variable=]
> 737 | static const struct of_device_id ixp4xx_npe_of_match[] = {
>
> This is because the match is enclosed in the of_match_ptr()
> which compiles into NULL when OF is disabled and this
> is unnecessary.
>
> [...]
Here is the summary with links:
- soc: ixp4xx/qmgr: Fix unused match warning
https://git.kernel.org/soc/soc/c/526f3f3b102f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-27 14:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-23 8:55 [PATCH] soc: ixp4xx/qmgr: Fix unused match warning Linus Walleij
2022-05-27 14:20 ` patchwork-bot+linux-soc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox