Linux SOC development
 help / color / mirror / Atom feed
* [GIT PULL 1/2] arm64: dts: samsung: DTS for v6.11
@ 2024-07-02  6:35 Krzysztof Kozlowski
  2024-07-02  6:35 ` [GIT PULL 2/2 PATCH - drivers] soc: samsung: exynos-pmu: add support for PMU_ALIVE non atomic registers Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-02  6:35 UTC (permalink / raw)
  To: Olof Johansson, Arnd Bergmann, arm, soc; +Cc: Krzysztof Kozlowski

The following changes since commit 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0:

  Linux 6.10-rc1 (2024-05-26 15:20:12 -0700)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-dt64-6.11

for you to fetch changes up to 64c7ea42fcc2b972fc8d108642f4b8fabf0999c3:

  arm64: dts: exynos850: Enable TRNG (2024-07-01 14:27:09 +0200)

----------------------------------------------------------------
Samsung DTS ARM64 changes for v6.10

1. Google GS101: Minor cleanup and add fake regulators to USB phy, to
   satisfy dtbs_check.  The PMIC providing these regulators is not yet
   implemented.

2. Exynos850: Add True Random Number Generator.

----------------------------------------------------------------
André Draszik (2):
      arm64: dts: exynos: gs101: reorder properties as per guidelines
      arm64: dts: exynos: gs101-oriole: add placeholder regulators for USB phy

Sam Protsenko (1):
      arm64: dts: exynos850: Enable TRNG

 arch/arm64/boot/dts/exynos/exynos850.dtsi          |  8 ++++++++
 arch/arm64/boot/dts/exynos/google/gs101-oriole.dts |  9 ++++++++-
 arch/arm64/boot/dts/exynos/google/gs101.dtsi       | 22 +++++++++++-----------
 3 files changed, 27 insertions(+), 12 deletions(-)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [GIT PULL 2/2 PATCH - drivers] soc: samsung: exynos-pmu: add support for PMU_ALIVE non atomic registers
  2024-07-02  6:35 [GIT PULL 1/2] arm64: dts: samsung: DTS for v6.11 Krzysztof Kozlowski
@ 2024-07-02  6:35 ` Krzysztof Kozlowski
  2024-07-08 15:11 ` [GIT PULL 1/2] arm64: dts: samsung: DTS for v6.11 patchwork-bot+linux-soc
  2024-07-09  9:30 ` patchwork-bot+linux-soc
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-02  6:35 UTC (permalink / raw)
  To: Olof Johansson, Arnd Bergmann, arm, soc; +Cc: Krzysztof Kozlowski

From: Peter Griffin <peter.griffin@linaro.org>

Not all registers in PMU_ALIVE block support atomic set/clear operations.
GS101_SYSIP_DAT0 and GS101_SYSTEM_CONFIGURATION registers are two regs
where attempting atomic access fails.

As documentation on exactly which registers support atomic operations is
not forthcoming. We default to atomic access, unless the register is
explicitly added to the tensor_is_atomic() function. Update the comment
to reflect this as well.

Reviewed-by: Will McVicker <willmcvicker@google.com>
Tested-by: Will McVicker <willmcvicker@google.com>
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/r/20240628223506.1237523-4-peter.griffin@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/soc/samsung/exynos-pmu.c            | 22 ++++++++++++++++++---
 include/linux/soc/samsung/exynos-regs-pmu.h |  4 ++++
 2 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c
index fd8b6ac06656..a0123070a816 100644
--- a/drivers/soc/samsung/exynos-pmu.c
+++ b/drivers/soc/samsung/exynos-pmu.c
@@ -129,14 +129,30 @@ static int tensor_set_bits_atomic(void *ctx, unsigned int offset, u32 val,
 	return ret;
 }
 
-static int tensor_sec_update_bits(void *ctx, unsigned int reg,
-				  unsigned int mask, unsigned int val)
+static bool tensor_is_atomic(unsigned int reg)
 {
 	/*
 	 * Use atomic operations for PMU_ALIVE registers (offset 0~0x3FFF)
-	 * as the target registers can be accessed by multiple masters.
+	 * as the target registers can be accessed by multiple masters. SFRs
+	 * that don't support atomic are added to the switch statement below.
 	 */
 	if (reg > PMUALIVE_MASK)
+		return false;
+
+	switch (reg) {
+	case GS101_SYSIP_DAT0:
+	case GS101_SYSTEM_CONFIGURATION:
+		return false;
+	default:
+		return true;
+	}
+}
+
+static int tensor_sec_update_bits(void *ctx, unsigned int reg,
+				  unsigned int mask, unsigned int val)
+{
+
+	if (!tensor_is_atomic(reg))
 		return tensor_sec_reg_rmw(ctx, reg, mask, val);
 
 	return tensor_set_bits_atomic(ctx, reg, val, mask);
diff --git a/include/linux/soc/samsung/exynos-regs-pmu.h b/include/linux/soc/samsung/exynos-regs-pmu.h
index aa840ed043e1..f411c176536d 100644
--- a/include/linux/soc/samsung/exynos-regs-pmu.h
+++ b/include/linux/soc/samsung/exynos-regs-pmu.h
@@ -657,4 +657,8 @@
 #define EXYNOS5433_PAD_RETENTION_UFS_OPTION			(0x3268)
 #define EXYNOS5433_PAD_RETENTION_FSYSGENIO_OPTION		(0x32A8)
 
+/* For Tensor GS101 */
+#define GS101_SYSIP_DAT0					(0x810)
+#define GS101_SYSTEM_CONFIGURATION				(0x3A00)
+
 #endif /* __LINUX_SOC_EXYNOS_REGS_PMU_H */
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [GIT PULL 1/2] arm64: dts: samsung: DTS for v6.11
  2024-07-02  6:35 [GIT PULL 1/2] arm64: dts: samsung: DTS for v6.11 Krzysztof Kozlowski
  2024-07-02  6:35 ` [GIT PULL 2/2 PATCH - drivers] soc: samsung: exynos-pmu: add support for PMU_ALIVE non atomic registers Krzysztof Kozlowski
@ 2024-07-08 15:11 ` patchwork-bot+linux-soc
  2024-07-09  9:30 ` patchwork-bot+linux-soc
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-soc @ 2024-07-08 15:11 UTC (permalink / raw)
  To: Krzysztof Kozlowski; +Cc: soc

Hello:

This pull request was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Tue,  2 Jul 2024 08:35:08 +0200 you wrote:
> The following changes since commit 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0:
> 
>   Linux 6.10-rc1 (2024-05-26 15:20:12 -0700)
> 
> are available in the Git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-dt64-6.11
> 
> [...]

Here is the summary with links:
  - [GIT,PULL,1/2] arm64: dts: samsung: DTS for v6.11
    https://git.kernel.org/soc/soc/c/c36a19ed7ed0
  - [GIT,PULL,2/2,-,drivers] soc: samsung: exynos-pmu: add support for PMU_ALIVE non atomic registers
    (no matching commit)

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GIT PULL 1/2] arm64: dts: samsung: DTS for v6.11
  2024-07-02  6:35 [GIT PULL 1/2] arm64: dts: samsung: DTS for v6.11 Krzysztof Kozlowski
  2024-07-02  6:35 ` [GIT PULL 2/2 PATCH - drivers] soc: samsung: exynos-pmu: add support for PMU_ALIVE non atomic registers Krzysztof Kozlowski
  2024-07-08 15:11 ` [GIT PULL 1/2] arm64: dts: samsung: DTS for v6.11 patchwork-bot+linux-soc
@ 2024-07-09  9:30 ` patchwork-bot+linux-soc
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-soc @ 2024-07-09  9:30 UTC (permalink / raw)
  To: Krzysztof Kozlowski; +Cc: soc

Hello:

This pull request was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Tue,  2 Jul 2024 08:35:08 +0200 you wrote:
> The following changes since commit 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0:
> 
>   Linux 6.10-rc1 (2024-05-26 15:20:12 -0700)
> 
> are available in the Git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-dt64-6.11
> 
> [...]

Here is the summary with links:
  - [GIT,PULL,1/2] arm64: dts: samsung: DTS for v6.11
    (no matching commit)
  - [GIT,PULL,2/2,-,drivers] soc: samsung: exynos-pmu: add support for PMU_ALIVE non atomic registers
    https://git.kernel.org/soc/soc/c/97c4264f62a7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-07-09  9:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-02  6:35 [GIT PULL 1/2] arm64: dts: samsung: DTS for v6.11 Krzysztof Kozlowski
2024-07-02  6:35 ` [GIT PULL 2/2 PATCH - drivers] soc: samsung: exynos-pmu: add support for PMU_ALIVE non atomic registers Krzysztof Kozlowski
2024-07-08 15:11 ` [GIT PULL 1/2] arm64: dts: samsung: DTS for v6.11 patchwork-bot+linux-soc
2024-07-09  9:30 ` patchwork-bot+linux-soc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox