From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Daniel Palmer <daniel@0x0f.com>
Cc: devicetree@vger.kernel.org, soc@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, olof@lixom.net, arnd@arndb.de,
robh@kernel.org, w@1wt.eu
Subject: Re: [PATCH v2 10/10] ARM: mstar: SMP support
Date: Tue, 1 Dec 2020 15:04:25 +0000 [thread overview]
Message-ID: <20201201150425.GC1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20201201134330.3037007-11-daniel@0x0f.com>
On Tue, Dec 01, 2020 at 10:43:30PM +0900, Daniel Palmer wrote:
> + np = of_find_compatible_node(NULL, NULL, "mstar,smpctrl");
> + smpctrl = of_iomap(np, 0);
> +
> + if (!smpctrl)
> + return -ENODEV;
Wouldn't -ENOMEM be more appropriate here?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Daniel Palmer <daniel@0x0f.com>
Cc: devicetree@vger.kernel.org, arnd@arndb.de, robh@kernel.org,
linux-kernel@vger.kernel.org, soc@kernel.org, olof@lixom.net,
w@1wt.eu, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 10/10] ARM: mstar: SMP support
Date: Tue, 1 Dec 2020 15:04:25 +0000 [thread overview]
Message-ID: <20201201150425.GC1551@shell.armlinux.org.uk> (raw)
Message-ID: <20201201150425.ngodcjMaK_hG0_YcXRPTagwq4M35u2lFYyv2OKzfKp8@z> (raw)
In-Reply-To: <20201201134330.3037007-11-daniel@0x0f.com>
On Tue, Dec 01, 2020 at 10:43:30PM +0900, Daniel Palmer wrote:
> + np = of_find_compatible_node(NULL, NULL, "mstar,smpctrl");
> + smpctrl = of_iomap(np, 0);
> +
> + if (!smpctrl)
> + return -ENODEV;
Wouldn't -ENOMEM be more appropriate here?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-01 15:04 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 13:43 [PATCH v2 00/10] ARM: mstar: Add basic support for i2m and SMP Daniel Palmer
2020-12-01 13:43 ` Daniel Palmer
2020-12-01 13:43 ` [PATCH v2 01/10] dt-bindings: mstar: Add binding details for mstar,smpctrl Daniel Palmer
2020-12-01 13:43 ` [PATCH v2 01/10] dt-bindings: mstar: Add binding details for mstar, smpctrl Daniel Palmer
2020-12-09 16:35 ` [PATCH v2 01/10] dt-bindings: mstar: Add binding details for mstar,smpctrl Rob Herring
2020-12-09 16:35 ` Rob Herring
2020-12-09 17:45 ` Arnd Bergmann
2020-12-09 17:45 ` [PATCH v2 01/10] dt-bindings: mstar: Add binding details for mstar, smpctrl Arnd Bergmann
2020-12-10 10:43 ` [PATCH v2 01/10] dt-bindings: mstar: Add binding details for mstar,smpctrl Daniel Palmer
2020-12-10 10:43 ` Daniel Palmer
2020-12-10 10:43 ` [PATCH v2 01/10] dt-bindings: mstar: Add binding details for mstar, smpctrl Daniel Palmer
2020-12-10 10:33 ` [PATCH v2 01/10] dt-bindings: mstar: Add binding details for mstar,smpctrl Daniel Palmer
2020-12-10 10:33 ` Daniel Palmer
2020-12-10 10:33 ` [PATCH v2 01/10] dt-bindings: mstar: Add binding details for mstar, smpctrl Daniel Palmer
2020-12-01 13:43 ` [PATCH v2 02/10] dt-bindings: vendor-prefixes: Add honestar vendor prefix Daniel Palmer
2020-12-01 13:43 ` Daniel Palmer
2020-12-09 16:34 ` Rob Herring
2020-12-09 16:34 ` Rob Herring
2020-12-10 10:39 ` Daniel Palmer
2020-12-10 10:39 ` Daniel Palmer
2020-12-10 10:39 ` Daniel Palmer
2020-12-01 13:43 ` [PATCH v2 03/10] dt-bindings: mstar: Add Honestar SSD201_HT_V2 to mstar boards Daniel Palmer
2020-12-01 13:43 ` Daniel Palmer
2020-12-09 16:36 ` Rob Herring
2020-12-09 16:36 ` Rob Herring
2020-12-01 13:43 ` [PATCH v2 04/10] ARM: mstar: Add infinity2m support Daniel Palmer
2020-12-01 13:43 ` Daniel Palmer
2020-12-01 13:43 ` [PATCH v2 05/10] ARM: mstar: Add common dtsi for SSD201/SSD202D Daniel Palmer
2020-12-01 13:43 ` Daniel Palmer
2020-12-01 13:43 ` [PATCH v2 06/10] ARM: mstar: Add chip level dtsi for SSD202D Daniel Palmer
2020-12-01 13:43 ` Daniel Palmer
2020-12-01 13:43 ` [PATCH v2 07/10] ARM: mstar: Add dts for Honestar ssd201htv2 Daniel Palmer
2020-12-01 13:43 ` Daniel Palmer
2020-12-01 13:43 ` [PATCH v2 08/10] ARM: mstar: Add smp ctrl registers to infinity2m dtsi Daniel Palmer
2020-12-01 13:43 ` Daniel Palmer
2020-12-01 13:43 ` [PATCH v2 09/10] ARM: mstar: Wire up smpctrl for SSD201/SSD202D Daniel Palmer
2020-12-01 13:43 ` Daniel Palmer
2020-12-01 13:43 ` [PATCH v2 10/10] ARM: mstar: SMP support Daniel Palmer
2020-12-01 13:43 ` Daniel Palmer
2020-12-01 15:04 ` Russell King - ARM Linux admin [this message]
2020-12-01 15:04 ` Russell King - ARM Linux admin
2020-12-02 9:10 ` Daniel Palmer
2020-12-02 9:10 ` Daniel Palmer
2020-12-02 9:10 ` Daniel Palmer
2020-12-09 17:10 ` [PATCH v2 00/10] ARM: mstar: Add basic support for i2m and SMP patchwork-bot+linux-soc
2020-12-09 20:30 ` Arnd Bergmann
2020-12-09 20:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201150425.GC1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=arnd@arndb.de \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh@kernel.org \
--cc=soc@kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox