RE: [PATCH v18 05/10] clk: Add Sunplus SP7021 clock driver

[Stephen Boyd <sboyd@kernel.org>]

Quoting qinjian (2022-06-14 19:25:22)
> > > diff --git a/drivers/clk/clk-sp7021.c b/drivers/clk/clk-sp7021.c
> > > new file mode 100644
> > > index 000000000..0caef1bc7
> > > --- /dev/null
> > > +++ b/drivers/clk/clk-sp7021.c
> > > @@ -0,0 +1,725 @@
> > > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > 
> > This isn't a common license on driver files. Is it intended? Or
> > copy/paste from DT?
> 
> Yes, I copy/paste from DT.
> Did I need changed it to 'GPL-2.0-only'?

It's up to you.

> 
> Should I use __devm_clk_hw_register_gate() with parent_data
> or
> devm_clk_hw_register_gate() with parent_name?
> 

Please add a devm_clk_hw_register_gate_parent_data() and use that.