* [PATCH 2/6] arm: dts: spear600: Fix clcd interrupt
[not found] <20221019133208.319626-1-kory.maincent@bootlin.com>
@ 2022-10-19 13:32 ` Köry Maincent
2022-10-20 4:35 ` Viresh Kumar
2022-10-19 13:32 ` [PATCH 4/6] clk: spear: Fix CLCD clock definition on SPEAr600 Köry Maincent
` (2 subsequent siblings)
3 siblings, 1 reply; 12+ messages in thread
From: Köry Maincent @ 2022-10-19 13:32 UTC (permalink / raw)
To: Rajeev Kumar, Bhavna Yadav, Viresh Kumar, Deepak Sikri,
Vijay Kumar Mishra, linux-arm-kernel, devicetree, linux-kernel
Cc: thomas.petazzoni, Kory Maincent, Viresh Kumar, Shiraz Hashim, soc,
Rob Herring, Krzysztof Kozlowski, Vipin Kumar, Vipul Kumar Samar
From: Kory Maincent <kory.maincent@bootlin.com>
Interrupt 12 of the Interrupt controller belongs to the SMI controller,
the right one for the display controller is the interrupt 13.
Fixes: 8113ba917dfa ("ARM: SPEAr: DT: Update device nodes")
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
arch/arm/boot/dts/spear600.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/spear600.dtsi b/arch/arm/boot/dts/spear600.dtsi
index fd41243a0b2c..9d5a04a46b14 100644
--- a/arch/arm/boot/dts/spear600.dtsi
+++ b/arch/arm/boot/dts/spear600.dtsi
@@ -47,7 +47,7 @@ clcd: clcd@fc200000 {
compatible = "arm,pl110", "arm,primecell";
reg = <0xfc200000 0x1000>;
interrupt-parent = <&vic1>;
- interrupts = <12>;
+ interrupts = <13>;
status = "disabled";
};
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 2/6] arm: dts: spear600: Fix clcd interrupt
2022-10-19 13:32 ` [PATCH 2/6] arm: dts: spear600: Fix clcd interrupt Köry Maincent
@ 2022-10-20 4:35 ` Viresh Kumar
0 siblings, 0 replies; 12+ messages in thread
From: Viresh Kumar @ 2022-10-20 4:35 UTC (permalink / raw)
To: Köry Maincent
Cc: Rajeev Kumar, Bhavna Yadav, Deepak Sikri, Vijay Kumar Mishra,
linux-arm-kernel, devicetree, linux-kernel, thomas.petazzoni,
Viresh Kumar, Shiraz Hashim, soc, Rob Herring,
Krzysztof Kozlowski, Vipin Kumar, Vipul Kumar Samar
On 19-10-22, 15:32, Köry Maincent wrote:
> From: Kory Maincent <kory.maincent@bootlin.com>
>
> Interrupt 12 of the Interrupt controller belongs to the SMI controller,
> the right one for the display controller is the interrupt 13.
>
> Fixes: 8113ba917dfa ("ARM: SPEAr: DT: Update device nodes")
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> arch/arm/boot/dts/spear600.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/spear600.dtsi b/arch/arm/boot/dts/spear600.dtsi
> index fd41243a0b2c..9d5a04a46b14 100644
> --- a/arch/arm/boot/dts/spear600.dtsi
> +++ b/arch/arm/boot/dts/spear600.dtsi
> @@ -47,7 +47,7 @@ clcd: clcd@fc200000 {
> compatible = "arm,pl110", "arm,primecell";
> reg = <0xfc200000 0x1000>;
> interrupt-parent = <&vic1>;
> - interrupts = <12>;
> + interrupts = <13>;
> status = "disabled";
> };
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 4/6] clk: spear: Fix CLCD clock definition on SPEAr600
[not found] <20221019133208.319626-1-kory.maincent@bootlin.com>
2022-10-19 13:32 ` [PATCH 2/6] arm: dts: spear600: Fix clcd interrupt Köry Maincent
@ 2022-10-19 13:32 ` Köry Maincent
2022-10-20 4:36 ` Viresh Kumar
2022-10-28 0:21 ` Stephen Boyd
2022-10-19 13:32 ` [PATCH 5/6] arm: dts: spear600: Add ssp controller nodes Köry Maincent
2022-10-19 13:32 ` [PATCH 6/6] clk: spear: Fix SSP clock definition on SPEAr600 Köry Maincent
3 siblings, 2 replies; 12+ messages in thread
From: Köry Maincent @ 2022-10-19 13:32 UTC (permalink / raw)
To: linux-arm-kernel, linux-clk, linux-kernel
Cc: thomas.petazzoni, Kory Maincent, Viresh Kumar, Shiraz Hashim, soc,
Michael Turquette, Stephen Boyd
From: Kory Maincent <kory.maincent@bootlin.com>
There is no SPEAr600 device named "clcd". Instead, the description of the
CLCD (color liquid crystal display controller) name is "fc200000.clcd", so
we should associate the CLCD gateable clock to this device name.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
drivers/clk/spear/spear6xx_clock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/spear/spear6xx_clock.c b/drivers/clk/spear/spear6xx_clock.c
index c192a9141b86..ee0ed89f2954 100644
--- a/drivers/clk/spear/spear6xx_clock.c
+++ b/drivers/clk/spear/spear6xx_clock.c
@@ -207,7 +207,7 @@ void __init spear6xx_clk_init(void __iomem *misc_base)
clk = clk_register_gate(NULL, "clcd_clk", "clcd_mclk", 0,
PERIP1_CLK_ENB, CLCD_CLK_ENB, 0, &_lock);
- clk_register_clkdev(clk, NULL, "clcd");
+ clk_register_clkdev(clk, NULL, "fc200000.clcd");
/* gpt clocks */
clk = clk_register_gpt("gpt0_1_syn_clk", "pll1_clk", 0, PRSC0_CLK_CFG,
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 4/6] clk: spear: Fix CLCD clock definition on SPEAr600
2022-10-19 13:32 ` [PATCH 4/6] clk: spear: Fix CLCD clock definition on SPEAr600 Köry Maincent
@ 2022-10-20 4:36 ` Viresh Kumar
2022-10-28 0:21 ` Stephen Boyd
1 sibling, 0 replies; 12+ messages in thread
From: Viresh Kumar @ 2022-10-20 4:36 UTC (permalink / raw)
To: Köry Maincent
Cc: linux-arm-kernel, linux-clk, linux-kernel, thomas.petazzoni,
Viresh Kumar, Shiraz Hashim, soc, Michael Turquette, Stephen Boyd
On 19-10-22, 15:32, Köry Maincent wrote:
> From: Kory Maincent <kory.maincent@bootlin.com>
>
> There is no SPEAr600 device named "clcd". Instead, the description of the
> CLCD (color liquid crystal display controller) name is "fc200000.clcd", so
> we should associate the CLCD gateable clock to this device name.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> drivers/clk/spear/spear6xx_clock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/spear/spear6xx_clock.c b/drivers/clk/spear/spear6xx_clock.c
> index c192a9141b86..ee0ed89f2954 100644
> --- a/drivers/clk/spear/spear6xx_clock.c
> +++ b/drivers/clk/spear/spear6xx_clock.c
> @@ -207,7 +207,7 @@ void __init spear6xx_clk_init(void __iomem *misc_base)
>
> clk = clk_register_gate(NULL, "clcd_clk", "clcd_mclk", 0,
> PERIP1_CLK_ENB, CLCD_CLK_ENB, 0, &_lock);
> - clk_register_clkdev(clk, NULL, "clcd");
> + clk_register_clkdev(clk, NULL, "fc200000.clcd");
>
> /* gpt clocks */
> clk = clk_register_gpt("gpt0_1_syn_clk", "pll1_clk", 0, PRSC0_CLK_CFG,
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 4/6] clk: spear: Fix CLCD clock definition on SPEAr600
2022-10-19 13:32 ` [PATCH 4/6] clk: spear: Fix CLCD clock definition on SPEAr600 Köry Maincent
2022-10-20 4:36 ` Viresh Kumar
@ 2022-10-28 0:21 ` Stephen Boyd
2022-11-02 8:33 ` Köry Maincent
1 sibling, 1 reply; 12+ messages in thread
From: Stephen Boyd @ 2022-10-28 0:21 UTC (permalink / raw)
To: Köry Maincent, linux-arm-kernel, linux-clk, linux-kernel
Cc: thomas.petazzoni, Kory Maincent, Viresh Kumar, Shiraz Hashim, soc,
Michael Turquette
Quoting Köry Maincent (2022-10-19 06:32:06)
> From: Kory Maincent <kory.maincent@bootlin.com>
>
> There is no SPEAr600 device named "clcd". Instead, the description of the
> CLCD (color liquid crystal display controller) name is "fc200000.clcd", so
> we should associate the CLCD gateable clock to this device name.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Does this need a Fixes tag?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 4/6] clk: spear: Fix CLCD clock definition on SPEAr600
2022-10-28 0:21 ` Stephen Boyd
@ 2022-11-02 8:33 ` Köry Maincent
0 siblings, 0 replies; 12+ messages in thread
From: Köry Maincent @ 2022-11-02 8:33 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-arm-kernel, linux-clk, linux-kernel, thomas.petazzoni,
Viresh Kumar, Shiraz Hashim, soc, Michael Turquette
Hello Stephan,
On Thu, 27 Oct 2022 17:21:47 -0700
Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Köry Maincent (2022-10-19 06:32:06)
> > From: Kory Maincent <kory.maincent@bootlin.com>
> >
> > There is no SPEAr600 device named "clcd". Instead, the description of the
> > CLCD (color liquid crystal display controller) name is "fc200000.clcd", so
> > we should associate the CLCD gateable clock to this device name.
> >
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
>
> Does this need a Fixes tag?
The old commits on SEAr6xx clock names definition update did not have it,
therefore I don't think so.
Regards,
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 5/6] arm: dts: spear600: Add ssp controller nodes
[not found] <20221019133208.319626-1-kory.maincent@bootlin.com>
2022-10-19 13:32 ` [PATCH 2/6] arm: dts: spear600: Fix clcd interrupt Köry Maincent
2022-10-19 13:32 ` [PATCH 4/6] clk: spear: Fix CLCD clock definition on SPEAr600 Köry Maincent
@ 2022-10-19 13:32 ` Köry Maincent
2022-10-20 4:36 ` Viresh Kumar
2022-10-19 13:32 ` [PATCH 6/6] clk: spear: Fix SSP clock definition on SPEAr600 Köry Maincent
3 siblings, 1 reply; 12+ messages in thread
From: Köry Maincent @ 2022-10-19 13:32 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: thomas.petazzoni, Kory Maincent, Viresh Kumar, Shiraz Hashim, soc,
Rob Herring, Krzysztof Kozlowski
From: Kory Maincent <kory.maincent@bootlin.com>
The SPEAr600 has three Synchronous serial port to enables synchronous
serial communication with slave or master peripherals (SPI). Lets add these
nodes to be able to use them.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
arch/arm/boot/dts/spear600.dtsi | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/arch/arm/boot/dts/spear600.dtsi b/arch/arm/boot/dts/spear600.dtsi
index 9d5a04a46b14..6b67c0ceaed9 100644
--- a/arch/arm/boot/dts/spear600.dtsi
+++ b/arch/arm/boot/dts/spear600.dtsi
@@ -207,6 +207,36 @@ adc: adc@d820b000 {
interrupts = <6>;
status = "disabled";
};
+
+ ssp1: spi@d0100000 {
+ compatible = "arm,pl022", "arm,primecell";
+ reg = <0xd0100000 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupt-parent = <&vic0>;
+ interrupts = <26>;
+ status = "disabled";
+ };
+
+ ssp2: spi@d0180000 {
+ compatible = "arm,pl022", "arm,primecell";
+ reg = <0xd0180000 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupt-parent = <&vic0>;
+ interrupts = <27>;
+ status = "disabled";
+ };
+
+ ssp3: spi@d8180000 {
+ compatible = "arm,pl022", "arm,primecell";
+ reg = <0xd8180000 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupt-parent = <&vic1>;
+ interrupts = <5>;
+ status = "disabled";
+ };
};
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 5/6] arm: dts: spear600: Add ssp controller nodes
2022-10-19 13:32 ` [PATCH 5/6] arm: dts: spear600: Add ssp controller nodes Köry Maincent
@ 2022-10-20 4:36 ` Viresh Kumar
0 siblings, 0 replies; 12+ messages in thread
From: Viresh Kumar @ 2022-10-20 4:36 UTC (permalink / raw)
To: Köry Maincent
Cc: linux-arm-kernel, devicetree, linux-kernel, thomas.petazzoni,
Viresh Kumar, Shiraz Hashim, soc, Rob Herring,
Krzysztof Kozlowski
On 19-10-22, 15:32, Köry Maincent wrote:
> From: Kory Maincent <kory.maincent@bootlin.com>
>
> The SPEAr600 has three Synchronous serial port to enables synchronous
> serial communication with slave or master peripherals (SPI). Lets add these
> nodes to be able to use them.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> arch/arm/boot/dts/spear600.dtsi | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/arch/arm/boot/dts/spear600.dtsi b/arch/arm/boot/dts/spear600.dtsi
> index 9d5a04a46b14..6b67c0ceaed9 100644
> --- a/arch/arm/boot/dts/spear600.dtsi
> +++ b/arch/arm/boot/dts/spear600.dtsi
> @@ -207,6 +207,36 @@ adc: adc@d820b000 {
> interrupts = <6>;
> status = "disabled";
> };
> +
> + ssp1: spi@d0100000 {
> + compatible = "arm,pl022", "arm,primecell";
> + reg = <0xd0100000 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + interrupt-parent = <&vic0>;
> + interrupts = <26>;
> + status = "disabled";
> + };
> +
> + ssp2: spi@d0180000 {
> + compatible = "arm,pl022", "arm,primecell";
> + reg = <0xd0180000 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + interrupt-parent = <&vic0>;
> + interrupts = <27>;
> + status = "disabled";
> + };
> +
> + ssp3: spi@d8180000 {
> + compatible = "arm,pl022", "arm,primecell";
> + reg = <0xd8180000 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + interrupt-parent = <&vic1>;
> + interrupts = <5>;
> + status = "disabled";
> + };
> };
> };
> };
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 6/6] clk: spear: Fix SSP clock definition on SPEAr600
[not found] <20221019133208.319626-1-kory.maincent@bootlin.com>
` (2 preceding siblings ...)
2022-10-19 13:32 ` [PATCH 5/6] arm: dts: spear600: Add ssp controller nodes Köry Maincent
@ 2022-10-19 13:32 ` Köry Maincent
2022-10-20 4:33 ` Viresh Kumar
2022-10-28 0:22 ` Stephen Boyd
3 siblings, 2 replies; 12+ messages in thread
From: Köry Maincent @ 2022-10-19 13:32 UTC (permalink / raw)
To: linux-arm-kernel, linux-clk, linux-kernel
Cc: thomas.petazzoni, Kory Maincent, Viresh Kumar, Shiraz Hashim, soc,
Michael Turquette, Stephen Boyd
From: Kory Maincent <kory.maincent@bootlin.com>
There is no SPEAr600 device named "ssp-pl022.x". Instead, the description
of the SSP (Synchronous Serial Port) was recently added to the Device Tree,
and the device name is "xxx.spi", so we should associate the SSP gateable
clock to these device names.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
drivers/clk/spear/spear6xx_clock.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/spear/spear6xx_clock.c b/drivers/clk/spear/spear6xx_clock.c
index ee0ed89f2954..adfa118520c3 100644
--- a/drivers/clk/spear/spear6xx_clock.c
+++ b/drivers/clk/spear/spear6xx_clock.c
@@ -326,13 +326,13 @@ void __init spear6xx_clk_init(void __iomem *misc_base)
clk = clk_register_gate(NULL, "ssp0_clk", "apb_clk", 0, PERIP1_CLK_ENB,
SSP0_CLK_ENB, 0, &_lock);
- clk_register_clkdev(clk, NULL, "ssp-pl022.0");
+ clk_register_clkdev(clk, NULL, "d0100000.spi");
clk = clk_register_gate(NULL, "ssp1_clk", "apb_clk", 0, PERIP1_CLK_ENB,
SSP1_CLK_ENB, 0, &_lock);
- clk_register_clkdev(clk, NULL, "ssp-pl022.1");
+ clk_register_clkdev(clk, NULL, "d0180000.spi");
clk = clk_register_gate(NULL, "ssp2_clk", "apb_clk", 0, PERIP1_CLK_ENB,
SSP2_CLK_ENB, 0, &_lock);
- clk_register_clkdev(clk, NULL, "ssp-pl022.2");
+ clk_register_clkdev(clk, NULL, "d8180000.spi");
}
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 6/6] clk: spear: Fix SSP clock definition on SPEAr600
2022-10-19 13:32 ` [PATCH 6/6] clk: spear: Fix SSP clock definition on SPEAr600 Köry Maincent
@ 2022-10-20 4:33 ` Viresh Kumar
2022-10-28 0:22 ` Stephen Boyd
1 sibling, 0 replies; 12+ messages in thread
From: Viresh Kumar @ 2022-10-20 4:33 UTC (permalink / raw)
To: Köry Maincent
Cc: linux-arm-kernel, linux-clk, linux-kernel, thomas.petazzoni,
Viresh Kumar, Shiraz Hashim, soc, Michael Turquette, Stephen Boyd
On 19-10-22, 15:32, Köry Maincent wrote:
> From: Kory Maincent <kory.maincent@bootlin.com>
>
> There is no SPEAr600 device named "ssp-pl022.x". Instead, the description
> of the SSP (Synchronous Serial Port) was recently added to the Device Tree,
> and the device name is "xxx.spi", so we should associate the SSP gateable
> clock to these device names.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> drivers/clk/spear/spear6xx_clock.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 6/6] clk: spear: Fix SSP clock definition on SPEAr600
2022-10-19 13:32 ` [PATCH 6/6] clk: spear: Fix SSP clock definition on SPEAr600 Köry Maincent
2022-10-20 4:33 ` Viresh Kumar
@ 2022-10-28 0:22 ` Stephen Boyd
2022-11-02 8:32 ` Köry Maincent
1 sibling, 1 reply; 12+ messages in thread
From: Stephen Boyd @ 2022-10-28 0:22 UTC (permalink / raw)
To: Köry Maincent, linux-arm-kernel, linux-clk, linux-kernel
Cc: thomas.petazzoni, Kory Maincent, Viresh Kumar, Shiraz Hashim, soc,
Michael Turquette
Quoting Köry Maincent (2022-10-19 06:32:08)
> From: Kory Maincent <kory.maincent@bootlin.com>
>
> There is no SPEAr600 device named "ssp-pl022.x". Instead, the description
> of the SSP (Synchronous Serial Port) was recently added to the Device Tree,
> and the device name is "xxx.spi", so we should associate the SSP gateable
> clock to these device names.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Does this need a Fixes tag?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 6/6] clk: spear: Fix SSP clock definition on SPEAr600
2022-10-28 0:22 ` Stephen Boyd
@ 2022-11-02 8:32 ` Köry Maincent
0 siblings, 0 replies; 12+ messages in thread
From: Köry Maincent @ 2022-11-02 8:32 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-arm-kernel, linux-clk, linux-kernel, thomas.petazzoni,
Viresh Kumar, Shiraz Hashim, soc, Michael Turquette
Hello Stephen,
On Thu, 27 Oct 2022 17:22:17 -0700
Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Köry Maincent (2022-10-19 06:32:08)
> > From: Kory Maincent <kory.maincent@bootlin.com>
> >
> > There is no SPEAr600 device named "ssp-pl022.x". Instead, the description
> > of the SSP (Synchronous Serial Port) was recently added to the Device Tree,
> > and the device name is "xxx.spi", so we should associate the SSP gateable
> > clock to these device names.
> >
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
>
> Does this need a Fixes tag?
The old commits on SEAr6xx clock names definition update did not have it,
therefore I don't think so.
Regards,
^ permalink raw reply [flat|nested] 12+ messages in thread