* [PATCH linux-next v2] pxa: Remove dev_err() after platform_get_irq()
@ 2022-12-02 2:42 zhang.songyi
2022-12-04 12:20 ` patchwork-bot+linux-soc
0 siblings, 1 reply; 2+ messages in thread
From: zhang.songyi @ 2022-12-02 2:42 UTC (permalink / raw)
To: soc, arnd; +Cc: zhang.songyi, robert.jarzmik, lkundrak, linux-kernel
From: zhang songyi <zhang.songyi@zte.com.cn>
There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
Reviewed-by: Lubomir Rintel <lkundrak@v3.sk>
---
drivers/soc/pxa/ssp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soc/pxa/ssp.c b/drivers/soc/pxa/ssp.c
index 93449fb3519e..bd029e838241 100644
--- a/drivers/soc/pxa/ssp.c
+++ b/drivers/soc/pxa/ssp.c
@@ -146,10 +146,8 @@ static int pxa_ssp_probe(struct platform_device *pdev)
}
ssp->irq = platform_get_irq(pdev, 0);
- if (ssp->irq < 0) {
- dev_err(dev, "no IRQ resource defined\n");
+ if (ssp->irq < 0)
return -ENODEV;
- }
if (dev->of_node) {
const struct of_device_id *id =
--
2.15.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next v2] pxa: Remove dev_err() after platform_get_irq()
2022-12-02 2:42 [PATCH linux-next v2] pxa: Remove dev_err() after platform_get_irq() zhang.songyi
@ 2022-12-04 12:20 ` patchwork-bot+linux-soc
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+linux-soc @ 2022-12-04 12:20 UTC (permalink / raw)
To: zhang.songyi; +Cc: soc
Hello:
This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:
On Fri, 2 Dec 2022 10:42:04 +0800 (CST) you wrote:
> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
>
> [...]
Here is the summary with links:
- [linux-next,v2] pxa: Remove dev_err() after platform_get_irq()
https://git.kernel.org/soc/soc/c/1d9ae5a1356a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-04 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-02 2:42 [PATCH linux-next v2] pxa: Remove dev_err() after platform_get_irq() zhang.songyi
2022-12-04 12:20 ` patchwork-bot+linux-soc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox