[PATCH 0/2] Fixes for turris-omnia-mcu

[PATCH 0/2] Fixes for turris-omnia-mcu

[Marek Behún]

Hello Arnd,

test robots noticed some bugs with the new turris-omnia-mcu driver while
doing randomized compilation tests.

Here come two fixes.

Marek Behún (2):
  platform: cznic: turris-omnia-mcu: Depend on OF
  platform: cznic: turris-omnia-mcu: Depend on WATCHDOG

 drivers/platform/cznic/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.44.2

[PATCH 1/2] platform: cznic: turris-omnia-mcu: Depend on OF

[Marek Behún]

Add depend on OF, otherwise the compilation fails with
  error: no member named 'of_gpio_n_cells' in 'struct gpio_chip'
  error: no member named 'of_xlate' in 'struct gpio_chip'

Fixes: dfa556e45ae9 ("platform: cznic: turris-omnia-mcu: Add support for MCU connected GPIOs")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407031646.trNSwajF-lkp@intel.com/
Signed-off-by: Marek Behún <kabel@kernel.org>
---
 drivers/platform/cznic/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/cznic/Kconfig b/drivers/platform/cznic/Kconfig
index 6edac80d5fa3..8992f7b87223 100644
--- a/drivers/platform/cznic/Kconfig
+++ b/drivers/platform/cznic/Kconfig
@@ -16,6 +16,7 @@ config TURRIS_OMNIA_MCU
 	tristate "Turris Omnia MCU driver"
 	depends on MACH_ARMADA_38X || COMPILE_TEST
 	depends on I2C
+	depends on OF
 	select GPIOLIB
 	select GPIOLIB_IRQCHIP
 	select HW_RANDOM
-- 
2.44.2

[PATCH 2/2] platform: cznic: turris-omnia-mcu: Depend on WATCHDOG

[Marek Behún]

Add depend on WATCHDOG, otherwise modpost fails with
  ERROR: modpost: "watchdog_init_timeout" [drivers/platform/cznic/turris-omnia-mcu.ko] undefined!
  ERROR: modpost: "devm_watchdog_register_device" [drivers/platform/cznic/turris-omnia-mcu.ko] undefined!

Fixes: ab89fb5fb92c ("platform: cznic: turris-omnia-mcu: Add support for MCU watchdog")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407040711.g19y3cWq-lkp@intel.com/
Signed-off-by: Marek Behún <kabel@kernel.org>
---
 drivers/platform/cznic/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/cznic/Kconfig b/drivers/platform/cznic/Kconfig
index 8992f7b87223..2a5235cf6844 100644
--- a/drivers/platform/cznic/Kconfig
+++ b/drivers/platform/cznic/Kconfig
@@ -17,6 +17,7 @@ config TURRIS_OMNIA_MCU
 	depends on MACH_ARMADA_38X || COMPILE_TEST
 	depends on I2C
 	depends on OF
+	depends on WATCHDOG
 	select GPIOLIB
 	select GPIOLIB_IRQCHIP
 	select HW_RANDOM
-- 
2.44.2

Re: [PATCH 0/2] Fixes for turris-omnia-mcu

[patchwork-bot+linux-soc]

Hello:

This series was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Mon,  8 Jul 2024 13:40:00 +0200 you wrote:
> Hello Arnd,
> 
> test robots noticed some bugs with the new turris-omnia-mcu driver while
> doing randomized compilation tests.
> 
> Here come two fixes.
> 
> [...]

Here is the summary with links:
  - [1/2] platform: cznic: turris-omnia-mcu: Depend on OF
    https://git.kernel.org/soc/soc/c/5423a01df8c5
  - [2/2] platform: cznic: turris-omnia-mcu: Depend on WATCHDOG
    https://git.kernel.org/soc/soc/c/dc3c836f9b0f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html