From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Marek Behún" <kabel@kernel.org>
Cc: Gregory CLEMENT <gregory.clement@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>, Arnd Bergmann <arnd@arndb.de>,
soc@kernel.org, arm@kernel.org,
Andy Shevchenko <andy@kernel.org>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 03/19] firmware: turris-mox-rwtm: Use PAGE_SIZE instead of hardcoded 4096
Date: Thu, 13 Jun 2024 11:01:42 +0300 (EEST) [thread overview]
Message-ID: <30b3fba8-117e-a21f-c6d3-2e987792ec90@linux.intel.com> (raw)
In-Reply-To: <20240612135443.30239-4-kabel@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]
On Wed, 12 Jun 2024, Marek Behún wrote:
> The 4096 bytes limit in mox_hwrng_read() is due to the DMA buffer being
> allocated to one PAGE_SIZE bytes. The PAGE_SIZE macro is used when
> allocating the buffer, use it in mox_hwrng_read() as well.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> ---
> drivers/firmware/turris-mox-rwtm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c
> index 3f4758e03c81..5acdde1bb6d9 100644
> --- a/drivers/firmware/turris-mox-rwtm.c
> +++ b/drivers/firmware/turris-mox-rwtm.c
> @@ -287,8 +287,8 @@ static int mox_hwrng_read(struct hwrng *rng, void *data, size_t max, bool wait)
> struct armada_37xx_rwtm_tx_msg msg;
> int ret;
>
> - if (max > 4096)
> - max = 4096;
> + if (max > PAGE_SIZE)
> + max = PAGE_SIZE;
Wouldn't it be better to bind these to the alloc side with a local define
that is set to PAGE_SIZE?
--
i.
next prev parent reply other threads:[~2024-06-13 8:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 13:54 [PATCH 00/19] Updates for turris-mox-rwtm driver Marek Behún
2024-06-12 13:54 ` [PATCH 01/19] firmware: turris-mox-rwtm: Do not complete if there are no waiters Marek Behún
2024-06-12 13:54 ` [PATCH 02/19] firmware: turris-mox-rwtm: Fix checking return value of wait_for_completion_timeout() Marek Behún
2024-06-13 8:06 ` Ilpo Järvinen
2024-06-12 13:54 ` [PATCH 03/19] firmware: turris-mox-rwtm: Use PAGE_SIZE instead of hardcoded 4096 Marek Behún
2024-06-13 8:01 ` Ilpo Järvinen [this message]
2024-06-13 9:54 ` Marek Behún
2024-06-12 13:54 ` [PATCH 04/19] firmware: turris-mox-rwtm: Use ETH_ALEN instead of hardcoded 6 Marek Behún
2024-06-13 8:02 ` Ilpo Järvinen
2024-06-12 13:54 ` [PATCH 05/19] firmware: turris-mox-rwtm: Use the boolean type where appropriate Marek Behún
2024-06-12 13:54 ` [PATCH 06/19] firmware: turris-mox-rwtm: Hide signature related constants behind macros Marek Behún
2024-06-12 13:54 ` [PATCH 07/19] firmware: turris-mox-rwtm: Fix driver includes Marek Behún
2024-06-12 13:54 ` [PATCH 08/19] firmware: turris-mox-rwtm: Use kobj_type's default_groups member for automatic sysfs files creation Marek Behún
2024-06-13 8:14 ` Ilpo Järvinen
2024-06-12 13:54 ` [PATCH 09/19] firmware: turris-mox-rwtm: Simplify debugfs code Marek Behún
2024-06-12 13:54 ` [PATCH 10/19] firmware: turris-mox-rwtm: Simplify driver kobject code Marek Behún
2024-06-13 8:31 ` Ilpo Järvinen
2024-06-13 9:55 ` Marek Behún
2024-06-13 10:19 ` Ilpo Järvinen
2024-06-13 13:31 ` Marek Behún
2024-06-13 13:37 ` Ilpo Järvinen
2024-06-13 15:39 ` Marek Behún
2024-06-13 15:44 ` Ilpo Järvinen
2024-06-12 13:54 ` [PATCH 11/19] firmware: turris-mox-rwtm: Return true error code if kobject_add() fails Marek Behún
2024-06-12 13:54 ` [PATCH 12/19] firmware: turris-mox-rwtm: Convert rest to devm_* and get rid of driver .remove() Marek Behún
2024-06-12 13:54 ` [PATCH 13/19] firmware: turris-mox-rwtm: Use dev_err_probe() where possible Marek Behún
2024-06-12 13:54 ` [PATCH 14/19] firmware: turris-mox-rwtm: Rearrange probe calls Marek Behún
2024-06-12 13:54 ` [PATCH 15/19] firmware: turris-mox-rwtm: Drop redundant device pointer Marek Behún
2024-06-12 13:54 ` [PATCH 16/19] firmware: turris-mox-rwtm: Use devm_mutex_init() instead of mutex_init() Marek Behún
2024-06-12 13:54 ` [PATCH 17/19] firmware: turris-mox-rwtm: Use container_of() instead of hwrng .priv member Marek Behún
2024-06-12 13:54 ` [PATCH 18/19] firmware: turris-mox-rwtm: Deduplicate command execution code Marek Behún
2024-06-12 13:54 ` [PATCH 19/19] firmware: turris-mox-rwtm: Use EOPNOTSUPP instead of ENOSYS Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30b3fba8-117e-a21f-c6d3-2e987792ec90@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andrew@lunn.ch \
--cc=andy@kernel.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=kabel@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox