Re: [PATCH v4 4/4] arm: defconfig: drop RT_GROUP_SCHED=y from bcm2835/tegra/omap2plus

Re: [PATCH v4 4/4] arm: defconfig: drop RT_GROUP_SCHED=y from bcm2835/tegra/omap2plus

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

On Wed, Jan 15, 2025 at 04:41:23AM +0800, Celeste Liu wrote:
> Commit 673ce00c5d6c ("ARM: omap2plus_defconfig: Add support for distros
> with systemd") said it's because of recommendation from systemd. But
> systemd changed their recommendation later.[1]
> 
> For cgroup v1, if turned on, and there's any cgroup in the "cpu" hierarchy it
> needs an RT budget assigned, otherwise the processes in it will not be able to
> get RT at all. The problem with RT group scheduling is that it requires the
> budget assigned but there's no way we could assign a default budget, since the
> values to assign are both upper and lower time limits, are absolute, and need to
> be sum up to < 1 for each individal cgroup. That means we cannot really come up
> with values that would work by default in the general case.[2]
> 
> For cgroup v2, it's almost unusable as well. If it turned on, the cpu controller
> can only be enabled when all RT processes are in the root cgroup. But it will
> lose the benefits of cgroup v2 if all RT process were placed in the same cgroup.
> 
> Red Hat, Gentoo, Arch Linux and Debian all disable it. systemd also doesn't
> support it.
> 
> [1]: https://github.com/systemd/systemd/commit/f4e74be1856b3ac058acbf1be321c31d5299f69f
> [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1229700
> 
> Tested-by: Stefan Wahren <wahrenst@gmx.net>
> Acked-by: Kevin Hilman <khilman@baylibre.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Celeste Liu <uwu@coelacanthus.name>
> ---
>  arch/arm/configs/bcm2835_defconfig   | 1 -
>  arch/arm/configs/omap2plus_defconfig | 1 -
>  arch/arm/configs/tegra_defconfig     | 1 -
>  3 files changed, 3 deletions(-)

Hi Arnd,

is this something that you could pick up? I think so far only the RISC-V
patch was picked up, but nobody seems to feel responsible for the ARM
patch here.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v4 4/4] arm: defconfig: drop RT_GROUP_SCHED=y from bcm2835/tegra/omap2plus

[Huacai Chen]

On Fri, Mar 7, 2025 at 3:19 AM Thierry Reding <thierry.reding@gmail.com> wrote:
>
> On Wed, Jan 15, 2025 at 04:41:23AM +0800, Celeste Liu wrote:
> > Commit 673ce00c5d6c ("ARM: omap2plus_defconfig: Add support for distros
> > with systemd") said it's because of recommendation from systemd. But
> > systemd changed their recommendation later.[1]
> >
> > For cgroup v1, if turned on, and there's any cgroup in the "cpu" hierarchy it
> > needs an RT budget assigned, otherwise the processes in it will not be able to
> > get RT at all. The problem with RT group scheduling is that it requires the
> > budget assigned but there's no way we could assign a default budget, since the
> > values to assign are both upper and lower time limits, are absolute, and need to
> > be sum up to < 1 for each individal cgroup. That means we cannot really come up
> > with values that would work by default in the general case.[2]
> >
> > For cgroup v2, it's almost unusable as well. If it turned on, the cpu controller
> > can only be enabled when all RT processes are in the root cgroup. But it will
> > lose the benefits of cgroup v2 if all RT process were placed in the same cgroup.
> >
> > Red Hat, Gentoo, Arch Linux and Debian all disable it. systemd also doesn't
> > support it.
> >
> > [1]: https://github.com/systemd/systemd/commit/f4e74be1856b3ac058acbf1be321c31d5299f69f
> > [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1229700
> >
> > Tested-by: Stefan Wahren <wahrenst@gmx.net>
> > Acked-by: Kevin Hilman <khilman@baylibre.com>
> > Acked-by: Thierry Reding <treding@nvidia.com>
> > Signed-off-by: Celeste Liu <uwu@coelacanthus.name>
> > ---
> >  arch/arm/configs/bcm2835_defconfig   | 1 -
> >  arch/arm/configs/omap2plus_defconfig | 1 -
> >  arch/arm/configs/tegra_defconfig     | 1 -
> >  3 files changed, 3 deletions(-)
>
> Hi Arnd,
>
> is this something that you could pick up? I think so far only the RISC-V
> patch was picked up, but nobody seems to feel responsible for the ARM
> patch here.
I will take the LoongArch patch, but may be squashed to another one
about config file update.

Huacai

>
> Thierry

Re: [PATCH v4 4/4] arm: defconfig: drop RT_GROUP_SCHED=y from bcm2835/tegra/omap2plus

[Arnd Bergmann]

On Thu, Mar 6, 2025, at 20:19, Thierry Reding wrote:
> On Wed, Jan 15, 2025 at 04:41:23AM +0800, Celeste Liu wrote:
>> ---
>>  arch/arm/configs/bcm2835_defconfig   | 1 -
>>  arch/arm/configs/omap2plus_defconfig | 1 -
>>  arch/arm/configs/tegra_defconfig     | 1 -
>>  3 files changed, 3 deletions(-)
>
> Hi Arnd,
>
> is this something that you could pick up? I think so far only the RISC-V
> patch was picked up, but nobody seems to feel responsible for the ARM
> patch here.

I've merged it now after going through stuff in my inbox. It's
generally ok for patches like this one to be forwarded to
soc@lists.linux.dev where they end up in patchwork for me to apply,
in case you don't want it to get lost.

     Arnd