From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>, soc@kernel.org
Cc: kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] pinctrl: ep93xx: Fix raster pins typo
Date: Fri, 13 Sep 2024 08:16:50 +0200 [thread overview]
Message-ID: <6bed11e8f75dd2566a47063014b53ee945aff41e.camel@gmail.com> (raw)
In-Reply-To: <20240913045829.11904-1-nikita.shubin@maquefel.me>
Hi Nikita!
On Fri, 2024-09-13 at 07:58 +0300, Nikita Shubin wrote:
> Fix raster_on_sdram0_pins used in PMX_GROUP() instead of
> raster_on_sdram3_pins as it should be.
>
> Fixes: d1661439f5a3 ("pinctrl: add a Cirrus ep93xx SoC pin controller")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202409130426.1OzNAC9M-lkp@intel.com/
> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> ---
> drivers/pinctrl/pinctrl-ep93xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-ep93xx.c b/drivers/pinctrl/pinctrl-ep93xx.c
> index 458cb0e99c65..abafbbb8fd6a 100644
> --- a/drivers/pinctrl/pinctrl-ep93xx.c
> +++ b/drivers/pinctrl/pinctrl-ep93xx.c
> @@ -714,7 +714,7 @@ static const struct ep93xx_pin_group ep9307_pin_groups[] = {
> PMX_GROUP("i2s_on_ac97", ac97_ep9301_pins, EP93XX_SYSCON_DEVCFG_I2SONAC97,
> EP93XX_SYSCON_DEVCFG_I2SONAC97),
> PMX_GROUP("rasteronsdram0grp", raster_on_sdram0_pins, EP93XX_SYSCON_DEVCFG_RASONP3, 0),
> - PMX_GROUP("rasteronsdram3grp", raster_on_sdram0_pins, EP93XX_SYSCON_DEVCFG_RASONP3,
> + PMX_GROUP("rasteronsdram3grp", raster_on_sdram3_pins, EP93XX_SYSCON_DEVCFG_RASONP3,
> EP93XX_SYSCON_DEVCFG_RASONP3),
> PMX_GROUP("gpio2agrp", gpio2a_9307_pins, EP93XX_SYSCON_DEVCFG_GONK,
> EP93XX_SYSCON_DEVCFG_GONK),
> @@ -1159,7 +1159,7 @@ static const struct ep93xx_pin_group ep9312_pin_groups[] = {
> PMX_GROUP("i2s_on_ac97", ac97_ep9312_pins, EP93XX_SYSCON_DEVCFG_I2SONAC97,
> EP93XX_SYSCON_DEVCFG_I2SONAC97),
> PMX_GROUP("rasteronsdram0grp", raster_on_sdram0_pins, EP93XX_SYSCON_DEVCFG_RASONP3, 0),
> - PMX_GROUP("rasteronsdram3grp", raster_on_sdram0_pins, EP93XX_SYSCON_DEVCFG_RASONP3,
> + PMX_GROUP("rasteronsdram3grp", raster_on_sdram3_pins, EP93XX_SYSCON_DEVCFG_RASONP3,
> EP93XX_SYSCON_DEVCFG_RASONP3),
> PMX_GROUP("gpio2agrp", gpio2a_9312_pins, EP93XX_SYSCON_DEVCFG_GONK,
> EP93XX_SYSCON_DEVCFG_GONK),
--
Alexander Sverdlin.
next prev parent reply other threads:[~2024-09-13 6:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 4:58 [PATCH] pinctrl: ep93xx: Fix raster pins typo Nikita Shubin
2024-09-13 6:16 ` Alexander Sverdlin [this message]
2024-09-16 12:50 ` patchwork-bot+linux-soc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bed11e8f75dd2566a47063014b53ee945aff41e.camel@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=lkp@intel.com \
--cc=nikita.shubin@maquefel.me \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox