Linux SOC development
 help / color / mirror / Atom feed
* [PATCH] pinctrl: ep93xx: Fix raster pins typo
@ 2024-09-13  4:58 Nikita Shubin
  2024-09-13  6:16 ` Alexander Sverdlin
  2024-09-16 12:50 ` patchwork-bot+linux-soc
  0 siblings, 2 replies; 3+ messages in thread
From: Nikita Shubin @ 2024-09-13  4:58 UTC (permalink / raw)
  To: soc; +Cc: Alexander Sverdlin, Nikita Shubin, kernel test robot

Fix raster_on_sdram0_pins used in PMX_GROUP() instead of
raster_on_sdram3_pins as it should be.

Fixes: d1661439f5a3 ("pinctrl: add a Cirrus ep93xx SoC pin controller")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202409130426.1OzNAC9M-lkp@intel.com/
Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
---
 drivers/pinctrl/pinctrl-ep93xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-ep93xx.c b/drivers/pinctrl/pinctrl-ep93xx.c
index 458cb0e99c65..abafbbb8fd6a 100644
--- a/drivers/pinctrl/pinctrl-ep93xx.c
+++ b/drivers/pinctrl/pinctrl-ep93xx.c
@@ -714,7 +714,7 @@ static const struct ep93xx_pin_group ep9307_pin_groups[] = {
 	PMX_GROUP("i2s_on_ac97", ac97_ep9301_pins, EP93XX_SYSCON_DEVCFG_I2SONAC97,
 						EP93XX_SYSCON_DEVCFG_I2SONAC97),
 	PMX_GROUP("rasteronsdram0grp", raster_on_sdram0_pins, EP93XX_SYSCON_DEVCFG_RASONP3, 0),
-	PMX_GROUP("rasteronsdram3grp", raster_on_sdram0_pins, EP93XX_SYSCON_DEVCFG_RASONP3,
+	PMX_GROUP("rasteronsdram3grp", raster_on_sdram3_pins, EP93XX_SYSCON_DEVCFG_RASONP3,
 							EP93XX_SYSCON_DEVCFG_RASONP3),
 	PMX_GROUP("gpio2agrp", gpio2a_9307_pins, EP93XX_SYSCON_DEVCFG_GONK,
 						EP93XX_SYSCON_DEVCFG_GONK),
@@ -1159,7 +1159,7 @@ static const struct ep93xx_pin_group ep9312_pin_groups[] = {
 	PMX_GROUP("i2s_on_ac97", ac97_ep9312_pins, EP93XX_SYSCON_DEVCFG_I2SONAC97,
 						EP93XX_SYSCON_DEVCFG_I2SONAC97),
 	PMX_GROUP("rasteronsdram0grp", raster_on_sdram0_pins, EP93XX_SYSCON_DEVCFG_RASONP3, 0),
-	PMX_GROUP("rasteronsdram3grp", raster_on_sdram0_pins, EP93XX_SYSCON_DEVCFG_RASONP3,
+	PMX_GROUP("rasteronsdram3grp", raster_on_sdram3_pins, EP93XX_SYSCON_DEVCFG_RASONP3,
 							EP93XX_SYSCON_DEVCFG_RASONP3),
 	PMX_GROUP("gpio2agrp", gpio2a_9312_pins, EP93XX_SYSCON_DEVCFG_GONK,
 						EP93XX_SYSCON_DEVCFG_GONK),
-- 
2.43.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: ep93xx: Fix raster pins typo
  2024-09-13  4:58 [PATCH] pinctrl: ep93xx: Fix raster pins typo Nikita Shubin
@ 2024-09-13  6:16 ` Alexander Sverdlin
  2024-09-16 12:50 ` patchwork-bot+linux-soc
  1 sibling, 0 replies; 3+ messages in thread
From: Alexander Sverdlin @ 2024-09-13  6:16 UTC (permalink / raw)
  To: Nikita Shubin, soc; +Cc: kernel test robot

Hi Nikita!

On Fri, 2024-09-13 at 07:58 +0300, Nikita Shubin wrote:
> Fix raster_on_sdram0_pins used in PMX_GROUP() instead of
> raster_on_sdram3_pins as it should be.
> 
> Fixes: d1661439f5a3 ("pinctrl: add a Cirrus ep93xx SoC pin controller")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202409130426.1OzNAC9M-lkp@intel.com/
> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>

Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>

> ---
>  drivers/pinctrl/pinctrl-ep93xx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-ep93xx.c b/drivers/pinctrl/pinctrl-ep93xx.c
> index 458cb0e99c65..abafbbb8fd6a 100644
> --- a/drivers/pinctrl/pinctrl-ep93xx.c
> +++ b/drivers/pinctrl/pinctrl-ep93xx.c
> @@ -714,7 +714,7 @@ static const struct ep93xx_pin_group ep9307_pin_groups[] = {
>  	PMX_GROUP("i2s_on_ac97", ac97_ep9301_pins, EP93XX_SYSCON_DEVCFG_I2SONAC97,
>  						EP93XX_SYSCON_DEVCFG_I2SONAC97),
>  	PMX_GROUP("rasteronsdram0grp", raster_on_sdram0_pins, EP93XX_SYSCON_DEVCFG_RASONP3, 0),
> -	PMX_GROUP("rasteronsdram3grp", raster_on_sdram0_pins, EP93XX_SYSCON_DEVCFG_RASONP3,
> +	PMX_GROUP("rasteronsdram3grp", raster_on_sdram3_pins, EP93XX_SYSCON_DEVCFG_RASONP3,
>  							EP93XX_SYSCON_DEVCFG_RASONP3),
>  	PMX_GROUP("gpio2agrp", gpio2a_9307_pins, EP93XX_SYSCON_DEVCFG_GONK,
>  						EP93XX_SYSCON_DEVCFG_GONK),
> @@ -1159,7 +1159,7 @@ static const struct ep93xx_pin_group ep9312_pin_groups[] = {
>  	PMX_GROUP("i2s_on_ac97", ac97_ep9312_pins, EP93XX_SYSCON_DEVCFG_I2SONAC97,
>  						EP93XX_SYSCON_DEVCFG_I2SONAC97),
>  	PMX_GROUP("rasteronsdram0grp", raster_on_sdram0_pins, EP93XX_SYSCON_DEVCFG_RASONP3, 0),
> -	PMX_GROUP("rasteronsdram3grp", raster_on_sdram0_pins, EP93XX_SYSCON_DEVCFG_RASONP3,
> +	PMX_GROUP("rasteronsdram3grp", raster_on_sdram3_pins, EP93XX_SYSCON_DEVCFG_RASONP3,
>  							EP93XX_SYSCON_DEVCFG_RASONP3),
>  	PMX_GROUP("gpio2agrp", gpio2a_9312_pins, EP93XX_SYSCON_DEVCFG_GONK,
>  						EP93XX_SYSCON_DEVCFG_GONK),

-- 
Alexander Sverdlin.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: ep93xx: Fix raster pins typo
  2024-09-13  4:58 [PATCH] pinctrl: ep93xx: Fix raster pins typo Nikita Shubin
  2024-09-13  6:16 ` Alexander Sverdlin
@ 2024-09-16 12:50 ` patchwork-bot+linux-soc
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-soc @ 2024-09-16 12:50 UTC (permalink / raw)
  To: Nikita Shubin; +Cc: soc

Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Fri, 13 Sep 2024 07:58:29 +0300 you wrote:
> Fix raster_on_sdram0_pins used in PMX_GROUP() instead of
> raster_on_sdram3_pins as it should be.
> 
> Fixes: d1661439f5a3 ("pinctrl: add a Cirrus ep93xx SoC pin controller")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202409130426.1OzNAC9M-lkp@intel.com/
> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> 
> [...]

Here is the summary with links:
  - pinctrl: ep93xx: Fix raster pins typo
    https://git.kernel.org/soc/soc/c/7427c5b34fbe

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-16 12:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-13  4:58 [PATCH] pinctrl: ep93xx: Fix raster pins typo Nikita Shubin
2024-09-13  6:16 ` Alexander Sverdlin
2024-09-16 12:50 ` patchwork-bot+linux-soc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox