* [PATCH 0/5] ARM: dts: fix faulty ohci/ehci node names
@ 2025-03-30 12:13 Wolfram Sang
2025-03-30 12:13 ` [PATCH 3/5] ARM: dts: st: " Wolfram Sang
2025-03-30 15:57 ` [PATCH 0/5] ARM: dts: " Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Wolfram Sang @ 2025-03-30 12:13 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Wolfram Sang, Alexey Charkov, Andrew Lunn, Conor Dooley,
devicetree, Gregory Clement, Krzysztof Kozlowski,
Krzysztof Kozlowski, linux-omap, Piotr Wojtaszczyk, Rob Herring,
Sebastian Hesselbarth, Shiraz Hashim, soc, Tony Lindgren,
Viresh Kumar, Vladimir Zapolskiy
After I fixed this for the at91-boards I was interested in, I let the
scripts run for the other boards, too, of course. Here is the outcome.
49 less dtbs_check errors. Build bots were happy. No dependencies, I
suggest sub-trees apply them on their own. Thanks!
Happy hacking,
Wolfram
Wolfram Sang (5):
ARM: dts: marvell: fix faulty ohci/ehci node names
ARM: dts: nxp: lpc: fix faulty ohci/ehci node names
ARM: dts: st: fix faulty ohci/ehci node names
ARM: dts: ti: omap: fix faulty ohci/ehci node names
ARM: dts: vt8500: fix faulty ohci/ehci node names
arch/arm/boot/dts/marvell/kirkwood-db.dtsi | 2 +-
arch/arm/boot/dts/marvell/kirkwood-dir665.dts | 2 +-
arch/arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts | 2 +-
arch/arm/boot/dts/marvell/kirkwood.dtsi | 2 +-
arch/arm/boot/dts/marvell/orion5x.dtsi | 4 ++--
arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 2 +-
arch/arm/boot/dts/st/spear1310-evb.dts | 8 ++++----
arch/arm/boot/dts/st/spear1340-evb.dts | 8 ++++----
arch/arm/boot/dts/st/spear13xx.dtsi | 8 ++++----
arch/arm/boot/dts/st/spear300-evb.dts | 6 +++---
arch/arm/boot/dts/st/spear310-evb.dts | 6 +++---
arch/arm/boot/dts/st/spear320-evb.dts | 6 +++---
arch/arm/boot/dts/st/spear320-hmi.dts | 6 +++---
arch/arm/boot/dts/st/spear3xx.dtsi | 6 +++---
arch/arm/boot/dts/st/spear600.dtsi | 8 ++++----
arch/arm/boot/dts/ti/omap/omap3.dtsi | 4 ++--
arch/arm/boot/dts/ti/omap/omap4-l4.dtsi | 4 ++--
arch/arm/boot/dts/ti/omap/omap5-l4.dtsi | 4 ++--
arch/arm/boot/dts/vt8500/vt8500.dtsi | 2 +-
arch/arm/boot/dts/vt8500/wm8505.dtsi | 2 +-
arch/arm/boot/dts/vt8500/wm8650.dtsi | 2 +-
arch/arm/boot/dts/vt8500/wm8750.dtsi | 2 +-
arch/arm/boot/dts/vt8500/wm8850.dtsi | 2 +-
23 files changed, 49 insertions(+), 49 deletions(-)
--
2.47.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/5] ARM: dts: st: fix faulty ohci/ehci node names
2025-03-30 12:13 [PATCH 0/5] ARM: dts: fix faulty ohci/ehci node names Wolfram Sang
@ 2025-03-30 12:13 ` Wolfram Sang
2025-03-30 15:57 ` [PATCH 0/5] ARM: dts: " Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2025-03-30 12:13 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Wolfram Sang, Viresh Kumar, Shiraz Hashim, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, soc, devicetree
They should be named "usb@".
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm/boot/dts/st/spear1310-evb.dts | 8 ++++----
arch/arm/boot/dts/st/spear1340-evb.dts | 8 ++++----
arch/arm/boot/dts/st/spear13xx.dtsi | 8 ++++----
arch/arm/boot/dts/st/spear300-evb.dts | 6 +++---
arch/arm/boot/dts/st/spear310-evb.dts | 6 +++---
arch/arm/boot/dts/st/spear320-evb.dts | 6 +++---
arch/arm/boot/dts/st/spear320-hmi.dts | 6 +++---
arch/arm/boot/dts/st/spear3xx.dtsi | 6 +++---
arch/arm/boot/dts/st/spear600.dtsi | 8 ++++----
9 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/arch/arm/boot/dts/st/spear1310-evb.dts b/arch/arm/boot/dts/st/spear1310-evb.dts
index ad216571ba57..089bd7db55c7 100644
--- a/arch/arm/boot/dts/st/spear1310-evb.dts
+++ b/arch/arm/boot/dts/st/spear1310-evb.dts
@@ -205,19 +205,19 @@ partition@390000 {
};
};
- ehci@e4800000 {
+ usb@e4800000 {
status = "okay";
};
- ehci@e5800000 {
+ usb@e5800000 {
status = "okay";
};
- ohci@e4000000 {
+ usb@e4000000 {
status = "okay";
};
- ohci@e5000000 {
+ usb@e5000000 {
status = "okay";
};
diff --git a/arch/arm/boot/dts/st/spear1340-evb.dts b/arch/arm/boot/dts/st/spear1340-evb.dts
index 9b515b21a633..d24146c3c9e8 100644
--- a/arch/arm/boot/dts/st/spear1340-evb.dts
+++ b/arch/arm/boot/dts/st/spear1340-evb.dts
@@ -203,7 +203,7 @@ partition@390000 {
};
};
- ehci@e4800000 {
+ usb@e4800000 {
status = "okay";
};
@@ -221,7 +221,7 @@ button@1 {
};
};
- ehci@e5800000 {
+ usb@e5800000 {
status = "okay";
};
@@ -238,11 +238,11 @@ incodec: dir-hifi {
status = "okay";
};
- ohci@e4000000 {
+ usb@e4000000 {
status = "okay";
};
- ohci@e5000000 {
+ usb@e5000000 {
status = "okay";
};
diff --git a/arch/arm/boot/dts/st/spear13xx.dtsi b/arch/arm/boot/dts/st/spear13xx.dtsi
index 3b6897084e26..76749992394d 100644
--- a/arch/arm/boot/dts/st/spear13xx.dtsi
+++ b/arch/arm/boot/dts/st/spear13xx.dtsi
@@ -174,7 +174,7 @@ smi: flash@ea000000 {
status = "disabled";
};
- ehci@e4800000 {
+ usb@e4800000 {
compatible = "st,spear600-ehci", "usb-ehci";
reg = <0xe4800000 0x1000>;
interrupts = <0 64 0x4>;
@@ -182,7 +182,7 @@ ehci@e4800000 {
status = "disabled";
};
- ehci@e5800000 {
+ usb@e5800000 {
compatible = "st,spear600-ehci", "usb-ehci";
reg = <0xe5800000 0x1000>;
interrupts = <0 66 0x4>;
@@ -190,7 +190,7 @@ ehci@e5800000 {
status = "disabled";
};
- ohci@e4000000 {
+ usb@e4000000 {
compatible = "st,spear600-ohci", "usb-ohci";
reg = <0xe4000000 0x1000>;
interrupts = <0 65 0x4>;
@@ -198,7 +198,7 @@ ohci@e4000000 {
status = "disabled";
};
- ohci@e5000000 {
+ usb@e5000000 {
compatible = "st,spear600-ohci", "usb-ohci";
reg = <0xe5000000 0x1000>;
interrupts = <0 67 0x4>;
diff --git a/arch/arm/boot/dts/st/spear300-evb.dts b/arch/arm/boot/dts/st/spear300-evb.dts
index 303ef29fb805..7d4e6412d558 100644
--- a/arch/arm/boot/dts/st/spear300-evb.dts
+++ b/arch/arm/boot/dts/st/spear300-evb.dts
@@ -119,15 +119,15 @@ spi0: spi@d0100000 {
status = "okay";
};
- ehci@e1800000 {
+ usb@e1800000 {
status = "okay";
};
- ohci@e1900000 {
+ usb@e1900000 {
status = "okay";
};
- ohci@e2100000 {
+ usb@e2100000 {
status = "okay";
};
diff --git a/arch/arm/boot/dts/st/spear310-evb.dts b/arch/arm/boot/dts/st/spear310-evb.dts
index ea0b53036f7b..459182210825 100644
--- a/arch/arm/boot/dts/st/spear310-evb.dts
+++ b/arch/arm/boot/dts/st/spear310-evb.dts
@@ -133,15 +133,15 @@ spi0: spi@d0100000 {
status = "okay";
};
- ehci@e1800000 {
+ usb@e1800000 {
status = "okay";
};
- ohci@e1900000 {
+ usb@e1900000 {
status = "okay";
};
- ohci@e2100000 {
+ usb@e2100000 {
status = "okay";
};
diff --git a/arch/arm/boot/dts/st/spear320-evb.dts b/arch/arm/boot/dts/st/spear320-evb.dts
index 3c026d021c92..6ac53d993cf3 100644
--- a/arch/arm/boot/dts/st/spear320-evb.dts
+++ b/arch/arm/boot/dts/st/spear320-evb.dts
@@ -142,15 +142,15 @@ spi2: spi@a6000000 {
status = "okay";
};
- ehci@e1800000 {
+ usb@e1800000 {
status = "okay";
};
- ohci@e1900000 {
+ usb@e1900000 {
status = "okay";
};
- ohci@e2100000 {
+ usb@e2100000 {
status = "okay";
};
diff --git a/arch/arm/boot/dts/st/spear320-hmi.dts b/arch/arm/boot/dts/st/spear320-hmi.dts
index 721e5ee7b680..8010918e5257 100644
--- a/arch/arm/boot/dts/st/spear320-hmi.dts
+++ b/arch/arm/boot/dts/st/spear320-hmi.dts
@@ -92,7 +92,7 @@ dma@fc400000 {
status = "okay";
};
- ehci@e1800000 {
+ usb@e1800000 {
status = "okay";
};
@@ -147,11 +147,11 @@ button@2 {
};
};
- ohci@e1900000 {
+ usb@e1900000 {
status = "okay";
};
- ohci@e2100000 {
+ usb@e2100000 {
status = "okay";
};
diff --git a/arch/arm/boot/dts/st/spear3xx.dtsi b/arch/arm/boot/dts/st/spear3xx.dtsi
index cc88ebe7a60c..f54bb80ba28a 100644
--- a/arch/arm/boot/dts/st/spear3xx.dtsi
+++ b/arch/arm/boot/dts/st/spear3xx.dtsi
@@ -73,21 +73,21 @@ spi0: spi@d0100000 {
status = "disabled";
};
- ehci@e1800000 {
+ usb@e1800000 {
compatible = "st,spear600-ehci", "usb-ehci";
reg = <0xe1800000 0x1000>;
interrupts = <26>;
status = "disabled";
};
- ohci@e1900000 {
+ usb@e1900000 {
compatible = "st,spear600-ohci", "usb-ohci";
reg = <0xe1900000 0x1000>;
interrupts = <25>;
status = "disabled";
};
- ohci@e2100000 {
+ usb@e2100000 {
compatible = "st,spear600-ohci", "usb-ohci";
reg = <0xe2100000 0x1000>;
interrupts = <27>;
diff --git a/arch/arm/boot/dts/st/spear600.dtsi b/arch/arm/boot/dts/st/spear600.dtsi
index 6b67c0ceaed9..9a93367445ca 100644
--- a/arch/arm/boot/dts/st/spear600.dtsi
+++ b/arch/arm/boot/dts/st/spear600.dtsi
@@ -91,7 +91,7 @@ smi: flash@fc000000 {
status = "disabled";
};
- ehci_usb0: ehci@e1800000 {
+ ehci_usb0: usb@e1800000 {
compatible = "st,spear600-ehci", "usb-ehci";
reg = <0xe1800000 0x1000>;
interrupt-parent = <&vic1>;
@@ -99,7 +99,7 @@ ehci_usb0: ehci@e1800000 {
status = "disabled";
};
- ehci_usb1: ehci@e2000000 {
+ ehci_usb1: usb@e2000000 {
compatible = "st,spear600-ehci", "usb-ehci";
reg = <0xe2000000 0x1000>;
interrupt-parent = <&vic1>;
@@ -107,7 +107,7 @@ ehci_usb1: ehci@e2000000 {
status = "disabled";
};
- ohci_usb0: ohci@e1900000 {
+ ohci_usb0: usb@e1900000 {
compatible = "st,spear600-ohci", "usb-ohci";
reg = <0xe1900000 0x1000>;
interrupt-parent = <&vic1>;
@@ -115,7 +115,7 @@ ohci_usb0: ohci@e1900000 {
status = "disabled";
};
- ohci_usb1: ohci@e2100000 {
+ ohci_usb1: usb@e2100000 {
compatible = "st,spear600-ohci", "usb-ohci";
reg = <0xe2100000 0x1000>;
interrupt-parent = <&vic1>;
--
2.47.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 0/5] ARM: dts: fix faulty ohci/ehci node names
2025-03-30 12:13 [PATCH 0/5] ARM: dts: fix faulty ohci/ehci node names Wolfram Sang
2025-03-30 12:13 ` [PATCH 3/5] ARM: dts: st: " Wolfram Sang
@ 2025-03-30 15:57 ` Krzysztof Kozlowski
2025-03-30 15:59 ` Krzysztof Kozlowski
2025-03-30 16:38 ` Wolfram Sang
1 sibling, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-30 15:57 UTC (permalink / raw)
To: Wolfram Sang, linux-arm-kernel
Cc: Alexey Charkov, Andrew Lunn, Conor Dooley, devicetree,
Gregory Clement, Krzysztof Kozlowski, linux-omap,
Piotr Wojtaszczyk, Rob Herring, Sebastian Hesselbarth,
Shiraz Hashim, soc, Tony Lindgren, Viresh Kumar,
Vladimir Zapolskiy
On 30/03/2025 14:13, Wolfram Sang wrote:
> After I fixed this for the at91-boards I was interested in, I let the
> scripts run for the other boards, too, of course. Here is the outcome.
> 49 less dtbs_check errors. Build bots were happy. No dependencies, I
> suggest sub-trees apply them on their own. Thanks!
>
For this and the rest patches, I would not call it "fix" in the subject
because there is no bug to fix here and you just might confuse AUTOSEL.
What's more backporting this might actually cause regressions, because
in rare cases node name is an ABI. Therefore avoid calling anything here
fix.
You just adjust or align them with coding style or what
bindings/dtschema expect (but it expects due to generic naming
convention which is still just convention).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/5] ARM: dts: fix faulty ohci/ehci node names
2025-03-30 15:57 ` [PATCH 0/5] ARM: dts: " Krzysztof Kozlowski
@ 2025-03-30 15:59 ` Krzysztof Kozlowski
2025-03-30 16:38 ` Wolfram Sang
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-30 15:59 UTC (permalink / raw)
To: Wolfram Sang, linux-arm-kernel
Cc: Alexey Charkov, Andrew Lunn, Conor Dooley, devicetree,
Gregory Clement, Krzysztof Kozlowski, linux-omap,
Piotr Wojtaszczyk, Rob Herring, Sebastian Hesselbarth,
Shiraz Hashim, soc, Tony Lindgren, Viresh Kumar,
Vladimir Zapolskiy
On 30/03/2025 17:57, Krzysztof Kozlowski wrote:
> On 30/03/2025 14:13, Wolfram Sang wrote:
>> After I fixed this for the at91-boards I was interested in, I let the
>> scripts run for the other boards, too, of course. Here is the outcome.
>> 49 less dtbs_check errors. Build bots were happy. No dependencies, I
>> suggest sub-trees apply them on their own. Thanks!
>>
>
> For this and the rest patches, I would not call it "fix" in the subject
> because there is no bug to fix here and you just might confuse AUTOSEL.
> What's more backporting this might actually cause regressions, because
> in rare cases node name is an ABI. Therefore avoid calling anything here
> fix.
>
> You just adjust or align them with coding style or what
> bindings/dtschema expect (but it expects due to generic naming
> convention which is still just convention).
>
And I forgot:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/5] ARM: dts: fix faulty ohci/ehci node names
2025-03-30 15:57 ` [PATCH 0/5] ARM: dts: " Krzysztof Kozlowski
2025-03-30 15:59 ` Krzysztof Kozlowski
@ 2025-03-30 16:38 ` Wolfram Sang
1 sibling, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2025-03-30 16:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-kernel, Alexey Charkov, Andrew Lunn, Conor Dooley,
devicetree, Gregory Clement, Krzysztof Kozlowski, linux-omap,
Piotr Wojtaszczyk, Rob Herring, Sebastian Hesselbarth,
Shiraz Hashim, soc, Tony Lindgren, Viresh Kumar,
Vladimir Zapolskiy
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
> You just adjust or align them with coding style or what
> bindings/dtschema expect (but it expects due to generic naming
> convention which is still just convention).
Ack, I will "fix" :) the subjects and add your tag. Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-03-30 16:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-30 12:13 [PATCH 0/5] ARM: dts: fix faulty ohci/ehci node names Wolfram Sang
2025-03-30 12:13 ` [PATCH 3/5] ARM: dts: st: " Wolfram Sang
2025-03-30 15:57 ` [PATCH 0/5] ARM: dts: " Krzysztof Kozlowski
2025-03-30 15:59 ` Krzysztof Kozlowski
2025-03-30 16:38 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox