* [PATCH 2/2] riscv: dts: sophgo: cv180x: Fix internal ephy node name
@ 2026-08-03 16:34 Chen-Yu Yeh
2026-08-22 2:15 ` Inochi Amaoto
0 siblings, 1 reply; 2+ messages in thread
From: Chen-Yu Yeh @ 2026-08-03 16:34 UTC (permalink / raw)
To: chen.wang, inochiama
Cc: Chen-Yu Yeh, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
Longbin Li, Anton D. Stavinskii,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:RISC-V ARCHITECTURE,
open list:SOPHGO DEVICETREES and DRIVERS, open list
The internal EPHY node is named "phy@0" while its reg property is <1>.
The unit-address should match the first entry of the reg property, but
this is not checked by dtc for MDIO buses. The kernel confirms the PHY
is indeed at address 1:
eth0: PHY [mdio_mux-0.0:01] driver [Generic PHY]
Rename the node to ethernet-phy@1, which also follows the common naming
convention for ethernet PHY nodes.
Fixes: ba1abacc57cb ("riscv: dts: sophgo: Add mdio multiplexer device for cv18xx")
Signed-off-by: Chen-Yu Yeh <chenyou910331@gmail.com>
---
arch/riscv/boot/dts/sophgo/cv180x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/boot/dts/sophgo/cv180x.dtsi b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
index ec3bf305274a..cf672cc6b935 100644
--- a/arch/riscv/boot/dts/sophgo/cv180x.dtsi
+++ b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
@@ -71,7 +71,7 @@ internal_mdio: mdio@0 {
#size-cells = <0>;
reg = <0>;
- internal_ephy: phy@0 {
+ internal_ephy: phy@1 {
compatible = "ethernet-phy-ieee802.3-c22";
reg = <1>;
};
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] riscv: dts: sophgo: cv180x: Fix internal ephy node name
2026-08-03 16:34 [PATCH 2/2] riscv: dts: sophgo: cv180x: Fix internal ephy node name Chen-Yu Yeh
@ 2026-08-22 2:15 ` Inochi Amaoto
0 siblings, 0 replies; 2+ messages in thread
From: Inochi Amaoto @ 2026-08-22 2:15 UTC (permalink / raw)
To: Chen-Yu Yeh, chen.wang, inochiama
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Longbin Li,
Anton D. Stavinskii,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:RISC-V ARCHITECTURE,
open list:SOPHGO DEVICETREES and DRIVERS, open list
On Tue, Aug 04, 2026 at 12:34:24AM +0800, Chen-Yu Yeh wrote:
> The internal EPHY node is named "phy@0" while its reg property is <1>.
> The unit-address should match the first entry of the reg property, but
> this is not checked by dtc for MDIO buses. The kernel confirms the PHY
> is indeed at address 1:
>
> eth0: PHY [mdio_mux-0.0:01] driver [Generic PHY]
>
> Rename the node to ethernet-phy@1, which also follows the common naming
> convention for ethernet PHY nodes.
>
> Fixes: ba1abacc57cb ("riscv: dts: sophgo: Add mdio multiplexer device for cv18xx")
>
> Signed-off-by: Chen-Yu Yeh <chenyou910331@gmail.com>
> ---
> arch/riscv/boot/dts/sophgo/cv180x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/sophgo/cv180x.dtsi b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
> index ec3bf305274a..cf672cc6b935 100644
> --- a/arch/riscv/boot/dts/sophgo/cv180x.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
> @@ -71,7 +71,7 @@ internal_mdio: mdio@0 {
> #size-cells = <0>;
> reg = <0>;
>
> - internal_ephy: phy@0 {
> + internal_ephy: phy@1 {
> compatible = "ethernet-phy-ieee802.3-c22";
> reg = <1>;
> };
> --
> 2.43.0
>
Please send this with the same thread of PATCH 1. Otherwise, LGTM
Reviewed-by: Inochi Amaoto <inochiama@gmail.com>
Regards,
Inochi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-22 2:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-03 16:34 [PATCH 2/2] riscv: dts: sophgo: cv180x: Fix internal ephy node name Chen-Yu Yeh
2026-08-22 2:15 ` Inochi Amaoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox