From: Lorne Li <lorneli at 163.com>
To: spdk@lists.01.org
Subject: [SPDK] Report a potential race condition in nvmf target
Date: Sat, 28 Sep 2019 02:06:19 +0000 [thread overview]
Message-ID: <30664e6c.96b4.16b8856c4a9.Coremail.lorneli@163.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
Hi all,
I think there may exist a race condition in nvmf target.
When adding or removing a namespace, nvmf target using `spdk_nvmf_ctrlr_ns_changed` to notify its ctrlr that ns has been changed from subsystem's thread('app thread'). But I think func `spdk_nvmf_ctrlr_ns_changed` should be called in ctrlr's thread, since it touches ctrlr's variables and even transfers out ctrlr's aer_req.
Last week, I launched a issue https://github.com/spdk/spdk/issues/837 in github to describe this race condition in detail and a panic likely caused by this.
It would be great if someone could take a look at it. Thanks in advance.
|
Lorne Li
lorneli(a)163.com
|
签名由网易邮箱大师定制
next reply other threads:[~2019-09-28 2:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-28 2:06 Lorne Li [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-09-28 2:06 [SPDK] Report a potential race condition in nvmf target Lorne Li
2019-06-25 12:22 Sasha Kotchubievsky
2019-06-24 8:27 Sasha Kotchubievsky
2019-06-24 8:22 Yang, Ziye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30664e6c.96b4.16b8856c4a9.Coremail.lorneli@163.com \
--to=spdk@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox