From: "Yeongjin Gil" <youngjin.gil@samsung.com>
To: "'Greg KH'" <gregkh@linuxfoundation.org>
Cc: <stable@vger.kernel.org>,
"'Sungjong Seo'" <sj1557.seo@samsung.com>,
"'Mike Snitzer'" <snitzer@kernel.org>
Subject: RE: [PATCH v2] dm verity: fix error handling for check_at_most_once on FEC
Date: Mon, 15 May 2023 13:06:07 +0900 [thread overview]
Message-ID: <001701d986e2$934c1cb0$b9e45610$@samsung.com> (raw)
In-Reply-To: <2023051508-payphone-dimly-b417@gregkh>
> On Mon, May 15, 2023 at 10:18:16AM +0900, Yeongjin Gil wrote:
> > In verity_end_io(), if bi_status is not BLK_STS_OK, it can be return
> > directly. But if FEC configured, it is desired to correct the data
> > page through verity_verify_io. And the return value will be converted
> > to blk_status and passed to verity_finish_io().
> >
> > BTW, when a bit is set in v->validated_blocks, verity_verify_io()
> > skips verification regardless of I/O error for the corresponding bio.
> > In this case, the I/O error could not be returned properly, and as a
> > result, there is a problem that abnormal data could be read for the
> > corresponding block.
> >
> > To fix this problem, when an I/O error occurs, do not skip
> > verification even if the bit related is set in v->validated_blocks.
> >
> > Fixes: 843f38d382b1 ("dm verity: add 'check_at_most_once' option to
> > only validate hashes once")
> > Cc: stable@vger.kernel.org
> > Reviewed-by: Sungjong Seo <sj1557.seo@samsung.com>
> > Signed-off-by: Yeongjin Gil <youngjin.gil@samsung.com>
> > Signed-off-by: Mike Snitzer <snitzer@kernel.org> (cherry picked from
> > commit e8c5d45f82ce0c238a4817739892fe8897a3dcc3)
>
> Why did you send this 3 times?
>
> And what kernel(s) is this to be applied to?
>
> confused,
I'm sorry for the confusion.
I've got patch failure mail 3 times from 4.19-stable, 5.4-stable,
5.10-stable.
So I replied to each mail after conflict resolution.
--in-reply-to '2023050708-verdict-proton-a5f0@gregkh'
--in-reply-to '2023050709-dry-stand-f81b@gregkh'
--in-reply-to '2023050701-epileptic-unethical-f46c@gregkh'
The stable kernel branches that I want to be applied are the above kernels.
>
> greg k-h
next prev parent reply other threads:[~2023-05-15 4:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230509110646epcas1p3026b0edd96ed52fc29d40f8d389915d3@epcas1p3.samsung.com>
2023-05-07 13:48 ` FAILED: patch "[PATCH] dm verity: fix error handling for check_at_most_once on FEC" failed to apply to 5.10-stable tree gregkh
2023-05-09 11:06 ` [PATCH 5.10.y] dm verity: fix error handling for check_at_most_once on FEC Yeongjin Gil
2023-05-09 12:16 ` Yeongjin Gil
2023-05-15 1:18 ` [PATCH v2] " Yeongjin Gil
2023-05-15 3:51 ` Greg KH
2023-05-15 4:06 ` Yeongjin Gil [this message]
2023-05-15 4:18 ` 'Greg KH'
[not found] <CGME20230515011922epcas1p3b2e3748b9953d9c6c5d36a0f059d92f9@epcas1p3.samsung.com>
2023-05-07 13:23 ` FAILED: patch "[PATCH] dm verity: fix error handling for check_at_most_once on FEC" failed to apply to 4.19-stable tree gregkh
2023-05-15 1:19 ` [PATCH v2] dm verity: fix error handling for check_at_most_once on FEC Yeongjin Gil
[not found] <CGME20230515011855epcas1p325968c8eaf11fdabd7a41996df8abc6f@epcas1p3.samsung.com>
2023-05-07 13:23 ` FAILED: patch "[PATCH] dm verity: fix error handling for check_at_most_once on FEC" failed to apply to 5.4-stable tree gregkh
2023-05-15 1:18 ` [PATCH v2] dm verity: fix error handling for check_at_most_once on FEC Yeongjin Gil
[not found] <CGME20230320070011epcas1p12f0fe9f9f417dd1a3441efdde55a4132@epcas1p1.samsung.com>
2023-03-20 6:59 ` Yeongjin Gil
2023-03-20 21:23 ` Eric Biggers
[not found] <CGME20230320065416epcas1p2511cb60bfb14ed2048e5d39677490c78@epcas1p2.samsung.com>
2023-03-20 6:54 ` Yeongjin Gil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001701d986e2$934c1cb0$b9e45610$@samsung.com' \
--to=youngjin.gil@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=sj1557.seo@samsung.com \
--cc=snitzer@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox